August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix incorrect value of migrating_to_vds
by ofrenkel＠redhat.com 19 Aug '14

19 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix incorrect value of migrating_to_vds ...................................................................... core: fix incorrect value of migrating_to_vds Since we retried to switch host to maintenance as part of the monitoring thread but before the updated data from the monitoring was saved, the migrating_to_vds could have been overridden and set back to its previous value. This bug caused NPE in VURTI#handOver method sometimes and sometimes it produced a VM which is not migrating with some wrong value in its migrating_to_vds field. The solution is to retry to switch host to maintenance in the after-refresh-treatment part of the monitoring. Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090 Bug-Url: https://bugzilla.redhat.com/1112359 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fix redundant synch print message for admin user
by yzaslavs＠redhat.com 19 Aug '14

19 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix redundant synch print message for admin user ...................................................................... aaa: Fix redundant synch print message for admin user Change-Id: Id95552f0e7602a520d33f6d46687405327dca7f4 Topic: AAAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id95552f0e7602a520d33f6d46687405327dca7f4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Removing unused method from DbUser
by yzaslavs＠redhat.com 19 Aug '14

19 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Removing unused method from DbUser ...................................................................... aaa: Removing unused method from DbUser Change-Id: I4268675f1859ef53c2513c76729792fb980c9815 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4268675f1859ef53c2513c76729792fb980c9815 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Coverity fixing
by yzaslavs＠redhat.com 19 Aug '14

19 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Coverity fixing ...................................................................... aaa: Coverity fixing Topic: AAA Change-Id: I1bb986dd9df608cac00f9387cfee7c84b65b2631 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/KrbConfCreator.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java 4 files changed, 56 insertions(+), 41 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bb986dd9df608cac00f9387cfee7c84b65b2631 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: handling exception from uuid validation
by sbonazzo＠redhat.com 19 Aug '14

19 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: handling exception from uuid validation ...................................................................... packaging: setup: handling exception from uuid validation Better handling of exception from UUID validation to provide an easier to read and more consistent error. Change-Id: I505a4f01d41c218a572f6e42682b57875712f1c0 Bug-Url: https://bugzilla.redhat.com/1125834 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py 1 file changed, 19 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a4f01d41c218a572f6e42682b57875712f1c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix Fencing Policy look
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix Fencing Policy look ...................................................................... webadmin: Fix Fencing Policy look Fixes the look of Fencing Policy tab in Cluster detail popup. Change-Id: Ie1c4cb496bf3a324ecd311a03a090945c679060d Bug-Url: https://bugzilla.redhat.com/1120829 Bug-Url: https://bugzilla.redhat.com/1090799 Bug-Url: https://bugzilla.redhat.com/1120858 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 17 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1c4cb496bf3a324ecd311a03a090945c679060d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix FencingPolicy copy constructor
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix FencingPolicy copy constructor ...................................................................... core: Fix FencingPolicy copy constructor Properly initializes hostsWithBrokenConnectivityThreshold when instance is created using copy constructor with null parameter. Change-Id: I3b1445e404887704562d9d8bbfdf733b75924f22 Bug-Url: https://bugzilla.redhat.com/1120829 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b1445e404887704562d9d8bbfdf733b75924f22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Display warning when fencing is disabled in cluster
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Display warning when fencing is disabled in cluster ...................................................................... core: Display warning when fencing is disabled in cluster Displays warning during add/update cluster if fencing is disabled in fencing policy of the cluster. Change-Id: I4853b349571523fbb4dac54cae45d9d6a9df01f3 Bug-Url: https://bugzilla.redhat.com/1120858 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 19 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4853b349571523fbb4dac54cae45d9d6a9df01f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Suppress VdsNotResponding execution if fencing is disa...
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Suppress VdsNotResponding execution if fencing is disabled ...................................................................... core: Suppress VdsNotResponding execution if fencing is disabled Suppress VdsNotRespondingCommand execution if fencing is disabled in fencing policy of the cluster. Change-Id: I784564e41c89b4a95eff3377cd6545cf907ecdce Bug-Url: https://bugzilla.redhat.com/1120858 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 33 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I784564e41c89b4a95eff3377cd6545cf907ecdce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add option disable fencing in cluster
by tnisan＠redhat.com 19 Aug '14

19 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add option disable fencing in cluster ...................................................................... webadmin: Add option disable fencing in cluster Adds option to cluster fencing policy which disabled fencing for all hosts in cluster. By default fencing in cluster is enabled. Change-Id: Idd373c344e767306526b2af3955c2d0d33027736 Bug-Url: https://bugzilla.redhat.com/1120858 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 71 insertions(+), 44 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd373c344e767306526b2af3955c2d0d33027736 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0