Change in ovirt-engine[ovirt-engine-3.5]: webadmin: There are no splitters in the Host>Interface header
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: There are no splitters in the Host>Interface header
......................................................................
webadmin: There are no splitters in the Host>Interface header
Change-Id: Icb276a805508b5f2729f609ec2861504a561acea
Bug-Url: https://bugzilla.redhat.com/1115310
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
(cherry picked from commit b0238c4650745a8fae5764b9f3d864200c162330)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb276a805508b5f2729f609ec2861504a561acea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine-cli[cli_3.5]: cli: Prepare for next release
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Prepare for next release
......................................................................
cli: Prepare for next release
In preparation for the next release this patch increases the version
number and sets the RPM release number to 0.1.
Change-Id: I21cbd57401b094edc072eb523956c81af919edbb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M setup.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21cbd57401b094edc072eb523956c81af919edbb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine-cli[cli_3.5]: cli: Release 3.5.0.3
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Release 3.5.0.3
......................................................................
cli: Release 3.5.0.3
Change-Id: Icebd7f692af82e9374db8334baed991bf0fb647f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icebd7f692af82e9374db8334baed991bf0fb647f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: require tty over ssh
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: require tty over ssh
......................................................................
packaging: setup: require tty over ssh
Running ssh -lroot hostname "hosted-engine --deploy"
cause an error while testing storage.
Added a check to ensure tty is available.
Change-Id: I8ecf0248ea6120acd8d6e624cf8114cc0a29efa8
Bug-Url: https://bugzilla.redhat.com/1105249
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 82c553f714fc185aedf0fdb834ba10e80e762756)
---
M src/plugins/ovirt-hosted-engine-setup/core/shell.py
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ecf0248ea6120acd8d6e624cf8114cc0a29efa8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: aaa: Adding namespace sorting
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Adding namespace sorting
......................................................................
aaa: Adding namespace sorting
Adding sorting to namespaces presented at AdElementList model
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
Change-Id: I24015f7116f0cd307f9969c89744fdab14f27fa6
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableNamespacesQuery.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24015f7116f0cd307f9969c89744fdab14f27fa6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine-cli[cli_3.5]: cli: No regular expression for IP, UUID or number
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: No regular expression for IP, UUID or number
......................................................................
cli: No regular expression for IP, UUID or number
Currently the command line lexer uses regular expressions to match IP
addresses, UUIDs and numbers. But in the parser grammar there is no
production that accepts those terminal symbols and doesn't accept also
plain words. The only special treatment is that numeric values are
converted to "int".
This behaviour means that some words that happen to start like IP
addresses, UUIDS or numbers are split into two tokens. For example, the
following command line:
update host 10.10.10.10a --name 10.10.10.10
Will be split into the following tokens:
WORD: update
WORD: host
IPADDR: 10.10.10.10
WORD: a
OPTION: --name
IPADDR: 10.10.10.10
But it should have been as follows:
WORD: update
WORD: host
WORD: 10.10.10.10a
OPTION: --name
IPADDR: 10.10.10.10
To avoid this issue, and simplify the lexer, this patch removes these
regular expressions for IP addresses, UUIDs and numbers, and replaces
them with a single expression that matches words. The action for this
expression will check if the value is actually an integer and convert it
to "int".
Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9
Bug-Url: https://bugzilla.redhat.com/1110366
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit e160c941231e84638253fae0e90df4dc976ad980)
---
M src/cli/parser.py
1 file changed, 17 insertions(+), 24 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine-cli[master]: cli: No regular expression for IP, UUID or number
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: No regular expression for IP, UUID or number
......................................................................
cli: No regular expression for IP, UUID or number
Currently the command line lexer uses regular expressions to match IP
addresses, UUIDs and numbers. But in the parser grammar there is no
production that accepts those terminal symbols and doesn't accept also
plain words. The only special treatment is that numeric values are
converted to "int".
This behaviour means that some words that happen to start like IP
addresses, UUIDS or numbers are split into two tokens. For example, the
following command line:
update host 10.10.10.10a --name 10.10.10.10
Will be split into the following tokens:
WORD: update
WORD: host
IPADDR: 10.10.10.10
WORD: a
OPTION: --name
IPADDR: 10.10.10.10
But it should have been as follows:
WORD: update
WORD: host
WORD: 10.10.10.10a
OPTION: --name
IPADDR: 10.10.10.10
To avoid this issue, and simplify the lexer, this patch removes these
regular expressions for IP addresses, UUIDs and numbers, and replaces
them with a single expression that matches words. The action for this
expression will check if the value is actually an integer and convert it
to "int".
Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9
Bug-Url: https://bugzilla.redhat.com/1110366
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/parser.py
1 file changed, 17 insertions(+), 24 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified
Ilia Meerovich: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Ilia Meerovich <imeerovi(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Don't store Neutron physical network on import
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Don't store Neutron physical network on import
......................................................................
core: Don't store Neutron physical network on import
This allowed Neutron physical network entries to sneak into our
DB. Except for eliminating that possibility, such existing entries are
cleared from the DB.
Change-Id: Icb8751f06690ffb34cc72f1f2e5e14e66b4d40f1
Bug-Url: https://bugzilla.redhat.com/1127687
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
A packaging/dbscripts/upgrade/03_05_0920_remove_external_network_labels.sql
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb8751f06690ffb34cc72f1f2e5e14e66b4d40f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-guest-agent[ovirt-3.5]: Fix username handling on Windows
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Fix username handling on Windows
......................................................................
Fix username handling on Windows
We forcibly encoded the unicode string to UTF-8 right after retrieval
which broke the encoding later on.
This patch fixes this issue.
Change-Id: I65b33e4f38f801f1770cf94a5ed36234c2fae90d
Bug-Url: https://bugzilla.redhat.com/1010201
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit 6fc1a18b2be2e93070fce2cd3cb0d5e23e2ecc5e)
---
M ovirt-guest-agent/GuestAgentWin32.py
M ovirt-guest-agent/OVirtAgentLogic.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65b33e4f38f801f1770cf94a5ed36234c2fae90d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: setting default protocol to XMLRPC
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: setting default protocol to XMLRPC
......................................................................
core: setting default protocol to XMLRPC
Due to some unresolved issues, changing the default back to XMLRPC, by
setting json as not-supported in 3.5. Once the issues are resolved we
will change it back.
This patch doesn't block you from working with JSONRPC, just setting the
default.
Change-Id: Ic9e298bf2d00ff63f40af65e97d9326135bfbc6a
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31704
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9e298bf2d00ff63f40af65e97d9326135bfbc6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
10 years, 4 months