Change in ovirt-engine[ovirt-engine-3.5]: core: pass MaxNumberOfSockets to create verb
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: pass MaxNumberOfSockets to create verb
......................................................................
core: pass MaxNumberOfSockets to create verb
in order to generate a correct topology xml-node for libvirt
VDSM needs also the MaxNumberOfSockets
Change-Id: I68368fdd40f0e43df18465c15faf2626789ee1c7
Bug-Url: https://bugzilla.redhat.com/1121295
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
2 files changed, 17 insertions(+), 8 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68368fdd40f0e43df18465c15faf2626789ee1c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: audit logging support for mac pools.
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: audit logging support for mac pools.
......................................................................
core: audit logging support for mac pools.
Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad
Bug-Url: https://bugzilla.redhat.com/1078844
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 77 insertions(+), 5 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: properly set the FilesystemBackend parameters when using NFS
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: properly set the FilesystemBackend parameters when using NFS
......................................................................
properly set the FilesystemBackend parameters when using NFS
Change-Id: Ie4a00ebbb760738bcae11a527c671ee7f715313e
Bug-Url: https://bugzilla.redhat.com/1125244
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
(cherry picked from commit 7aa85ae9eb80302a1d6c4c063030961e485761e4)
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/31056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4a00ebbb760738bcae11a527c671ee7f715313e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-hosted-engine-ha[master]: properly set the FilesystemBackend parameters when using NFS
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: properly set the FilesystemBackend parameters when using NFS
......................................................................
properly set the FilesystemBackend parameters when using NFS
Change-Id: Ie4a00ebbb760738bcae11a527c671ee7f715313e
Bug-Url: https://bugzilla.redhat.com/1125244
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4a00ebbb760738bcae11a527c671ee7f715313e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: ui: Changing foreman provider data loading
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: Changing foreman provider data loading
......................................................................
ui: Changing foreman provider data loading
When selected new provider the addHost external provider form fields will
be cleaned and blocked till all provider's info will be loaded.
In this patch we also change the update method which now retrieves all
provider's info in each call, instead of loading only part of the
information.
Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java
2 files changed, 63 insertions(+), 63 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: add host_provider_id to vdsStatic
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: add host_provider_id to vdsStatic
......................................................................
core: add host_provider_id to vdsStatic
This allows to sign the provider id, which in hosts mostly foreman
server id that added as external provider. With saving the ID we'll be
able to gather more info about the host later on.
Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113003
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_0100_add_provider_host_id_vdsstatic.sql
M packaging/dbscripts/vds_sp.sql
12 files changed, 56 insertions(+), 22 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Suppress kdump not configured warning when PM is off
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Suppress kdump not configured warning when PM is off
......................................................................
core: Suppress kdump not configured warning when PM is off
Suppresses displaying warning "Kdump integration is enabled for host
'dev-21', but kdump is not configured properly on host." when host
become Up and its power management is turned off.
Change-Id: I8989c83bf7b9c08bd839c81c30f6f1b0edf31322
Bug-Url: https://bugzilla.redhat.com/1125206
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8989c83bf7b9c08bd839c81c30f6f1b0edf31322
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: add 30 px the the height of event notifier dialog.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: add 30 px the the height of event notifier dialog.
......................................................................
webadmin: add 30 px the the height of event notifier dialog.
Added height is needed so that the dialog warning will not overflow.
("Note: To receive email notifications, ensure that the mail server
is configured and the ovirt-event-notifier service is running.")
Change-Id: Ie249bc96f467ee765e579a134763d61e1aa4b29a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122017
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
mooli tayer: Verified
Gilad Chaplik: Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31016
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie249bc96f467ee765e579a134763d61e1aa4b29a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Adding context ctor to UpgradeOvirtNodeInternalCommand
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Adding context ctor to UpgradeOvirtNodeInternalCommand
......................................................................
core: Adding context ctor to UpgradeOvirtNodeInternalCommand
I still fail to understand why not add to all commands.
Change-Id: I0555fd221f1fd3dfd8c4dbd35e5cc0fc919b3906
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0555fd221f1fd3dfd8c4dbd35e5cc0fc919b3906
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: userportal, webadmin: increase branding interface number
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: increase branding interface number
......................................................................
userportal,webadmin: increase branding interface number
- Incremented the branding interface version due to new use
of patternfly being incompatible with old version.
Change-Id: Ic951d79db8dfcf24a5e3af6ebf11056b87c436da
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingManager.java
M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/01-test.brand/branding.properties
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/02-test2.brand/branding.properties
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/03-test3.brand/branding.properties
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/04-test4.brand/branding.properties
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/05-test5.brand/branding.properties
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/06-test6.brand/branding.properties
M packaging/branding/ovirt.brand/branding.properties
9 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic951d79db8dfcf24a5e3af6ebf11056b87c436da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months