Change in ovirt-engine[ovirt-engine-3.4]: core: Fix audit log constructor
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix audit log constructor
......................................................................
core: Fix audit log constructor
Fix a regression merged in commit 7bb86ca81ace8960f0d34ab14fe85a93a4541b02.
Change-Id: I9b1b6130bddd380522cbe92287d9d27a2069c7af
Bug-Url: https://bugzilla.redhat.com/1126428
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/31040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b1b6130bddd380522cbe92287d9d27a2069c7af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: engine : Use java naming conventions
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Use java naming conventions
......................................................................
engine : Use java naming conventions
Use java naming conventions for method
names instead of csharp naming convention
Change-Id: I8ab86d97dbf1c94dd887c5ccc2a438a41ccd1f37
Bug-Url: https://bugzilla.redhat.com/1122639
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java
2 files changed, 60 insertions(+), 60 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ab86d97dbf1c94dd887c5ccc2a438a41ccd1f37
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in mom[master]: Add HostTime Collector for writing time based mom policies.
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: Add HostTime Collector for writing time based mom policies.
......................................................................
Add HostTime Collector for writing time based mom policies.
It returns host time statistics using python datetime module.
These stats would be useful for creating a time based policy.
Host Collector time interval is controlled in config file.
It provides the following stats -
time_year, time_month, time_day, time_hour,
time_minute, time_second, time_microsecond
Change-Id: I88a9d87d5f7e5a5c5baae2c20518a26a513dcda4
Signed-off-by: Meghal Gosalia <meghal(a)yahoo-inc.com>
Reviewed-on: http://gerrit.ovirt.org/28613
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Tested-by: Adam Litke <alitke(a)redhat.com>
---
A mom/Collectors/HostTime.py
1 file changed, 37 insertions(+), 0 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a9d87d5f7e5a5c5baae2c20518a26a513dcda4
Gerrit-PatchSet: 5
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Meghal .B. Gosalia <meghalgosalia(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Meghal .B. Gosalia <meghalgosalia(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Add audit log when removing networks from iSCSI bond.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Add audit log when removing networks from iSCSI bond.
......................................................................
core: Add audit log when removing networks from iSCSI bond.
Adding an audit log to indicate the user that the removed networks
from the iSCSI bond, will only take affect, after the Hosts will be
moved to maintenance and activated again.
Change-Id: I087818bb48cc9243e76b2cb850e6262104537f3c
Bug-Url: https://bugzilla.redhat.com/1126428
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/31026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I087818bb48cc9243e76b2cb850e6262104537f3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: packaging: spec: fix packaging issue
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: fix packaging issue
......................................................................
packaging: spec: fix packaging issue
Fixes:
error: File not found: /lib/systemd/systemd-ovirt-ha-agent
error: File not found: /lib/systemd/systemd-ovirt-ha-broker
Change-Id: I28ac68184f1f6519a4dddcd6c40a6f0285aa98b9
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-ha.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28ac68184f1f6519a4dddcd6c40a6f0285aa98b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-hosted-engine-ha[master]: packaging: spec: fix packaging issue
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: fix packaging issue
......................................................................
packaging: spec: fix packaging issue
Fixes:
error: File not found: /lib/systemd/systemd-ovirt-ha-agent
error: File not found: /lib/systemd/systemd-ovirt-ha-broker
Change-Id: I28ac68184f1f6519a4dddcd6c40a6f0285aa98b9
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-ha.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28ac68184f1f6519a4dddcd6c40a6f0285aa98b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-release[master]: packaging: spec: fix EL7 detection
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: fix EL7 detection
......................................................................
packaging: spec: fix EL7 detection
Change-Id: I04146665776c8ddb223cf42b85f1de9f7e36d320
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-release-3.5/ovirt-release35.spec.in
M ovirt-release-master/ovirt-release-master.spec.in
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04146665776c8ddb223cf42b85f1de9f7e36d320
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: I18N - fix misalignment in import domain
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: I18N - fix misalignment in import domain
......................................................................
webadmin: I18N - fix misalignment in import domain
Modify style of 'Activate Domain in Data Center' check-box
in import storage domain dialog (to fix misalignment
in French localization).
Change-Id: Ic489c119d4cf5fa4cc8f169d76442a0d8143ff53
Bug-Url: https://bugzilla.redhat.com/1123701
Bug-Url: https://bugzilla.redhat.com/1123702
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/31027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic489c119d4cf5fa4cc8f169d76442a0d8143ff53
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: frontend: Sorting columns in VM subtabs
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: frontend: Sorting columns in VM subtabs
......................................................................
frontend: Sorting columns in VM subtabs
This patch contains sorting columns in "Network Interface" VM subtab.
Change-Id: I6b55d40f4978f994cc2c84f3a99d46294b7928fc
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineNetworkInterfaceView.java
2 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Frank Kobzik: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b55d40f4978f994cc2c84f3a99d46294b7928fc
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: coverity issue fix.
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: coverity issue fix.
......................................................................
core: coverity issue fix.
- inlined variable, which can be null from static analysis point of
view, but such scenario would be a bug in system. Inlining variable
should convince coverity not to consider this as a problem.
Change-Id: I6751881c8b72e400f898ddd631b34106742db3b8
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6751881c8b72e400f898ddd631b34106742db3b8
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months