September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: null safe StorageDomainFreeSpaceRenderer
by tnisan＠redhat.com 01 Sep '14

01 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: null safe StorageDomainFreeSpaceRenderer ...................................................................... webadmin: null safe StorageDomainFreeSpaceRenderer StorageDomainFreeSpaceRenderer: verify getAvailableDiskSize's value before rendering. Change-Id: Ica5bd15bb939ec86502e406dcdd56f4dcf604ac7 Bug-Url: https://bugzilla.redhat.com/1079710 Bug-Url: https://bugzilla.redhat.com/1132406 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/StorageDomainFreeSpaceRenderer.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5bd15bb939ec86502e406dcdd56f4dcf604ac7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fixing other_dc proxy preference implementation
by tnisan＠redhat.com 01 Sep '14

01 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fixing other_dc proxy preference implementation ...................................................................... core: fixing other_dc proxy preference implementation Fencing with proxy from other_dc is actually performed by a proxy in the same dc This patch actually issues two things 1) the selected proxy preferences where not passed by the HostModel so always the "cluster,dc" default was treated 2) when searching for a proxy on other_dc, hosts from the fenced host DC where not filtered out. Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131411 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 4 files changed, 19 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: avoid removing a vm also when migratingTo
by tnisan＠redhat.com 01 Sep '14

01 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: avoid removing a vm also when migratingTo ...................................................................... core: avoid removing a vm also when migratingTo The fix simplifies the check and states what states we CAN delete the VM , otherwise fail canDoAction Change-Id: I6d97fbe84a81a3a4704ed1d80d9b52da752c108a Bug-Url: https://bugzilla.redhat.com/947965 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit a957c4825f1af750ae641d0c9d3abe7dee151110) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d97fbe84a81a3a4704ed1d80d9b52da752c108a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: centos: updated make file
by sbonazzo＠redhat.com 01 Sep '14

01 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos: updated make file ...................................................................... centos: updated make file - Use latest yad now built for epel 6 in koji - Call setenforce 0 avoiding selinux issues while creating the live cd - Use tee for writing the log so progress can be seen in the console Change-Id: If2d798af84718640f273036c62002a122e286993 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2d798af84718640f273036c62002a122e286993 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: kickstart: drop dependencies
by sbonazzo＠redhat.com 01 Sep '14

01 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: kickstart: drop dependencies ...................................................................... kickstart: drop dependencies jboss-as is not needed anymore since ovirt-engine-jboss-as exists. Other dependencies are automatically pulled in. Change-Id: Ib460c33b6dfca61cef55ce315ec3f07133814f77 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4558beaac38ca1cdcd626227d2767df78f499ed4) --- M centos/kickstart/ovirt-live-gnome.ks 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib460c33b6dfca61cef55ce315ec3f07133814f77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: centos: updated make file
by sbonazzo＠redhat.com 01 Sep '14

01 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos: updated make file ...................................................................... centos: updated make file - Use latest yad now built for epel 6 in koji - Call setenforce 0 avoiding selinux issues while creating the live cd - Use tee for writing the log so progress can be seen in the console Change-Id: If2d798af84718640f273036c62002a122e286993 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2d798af84718640f273036c62002a122e286993 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: kickstart: drop dependencies
by sbonazzo＠redhat.com 01 Sep '14

01 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: kickstart: drop dependencies ...................................................................... kickstart: drop dependencies jboss-as is not needed anymore since ovirt-engine-jboss-as exists. Other dependencies are automatically pulled in. Change-Id: Ib460c33b6dfca61cef55ce315ec3f07133814f77 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/kickstart/ovirt-live-gnome.ks 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib460c33b6dfca61cef55ce315ec3f07133814f77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: avoid removing a vm also when migratingTo
by ofrenkel＠redhat.com 01 Sep '14

01 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: avoid removing a vm also when migratingTo ...................................................................... core: avoid removing a vm also when migratingTo The fix simplifies the check and states what states we CAN delete the VM , otherwise fail canDoAction Change-Id: I6d97fbe84a81a3a4704ed1d80d9b52da752c108a Bug-Url: https://bugzilla.redhat.com/947965 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d97fbe84a81a3a4704ed1d80d9b52da752c108a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extapi: ExtMap.get() allow null default value
by tnisan＠redhat.com 01 Sep '14

01 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: extapi: ExtMap.get() allow null default value ...................................................................... extapi: ExtMap.get() allow null default value Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I2ad729b4e271d1b594fcd1485bd61667f6cbd2a1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ad729b4e271d1b594fcd1485bd61667f6cbd2a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core,webadmin: wording. "... mac range." ——>"... MAC address...
by lvernia＠redhat.com 01 Sep '14

01 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core,webadmin: wording. "... mac range." ——>"... MAC address range." ...................................................................... core,webadmin: wording. "... mac range." ——>"... MAC address range." Change-Id: I5225b2c2bcfbe5932c4a5279384a235ea54394a5 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved Lior Vernia: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5225b2c2bcfbe5932c4a5279384a235ea54394a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0