Change in ovirt-engine[master]: extapi: ExtMap.get() allow null default value
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: extapi: ExtMap.get() allow null default value
......................................................................
extapi: ExtMap.get() allow null default value
Change-Id: I2ad729b4e271d1b594fcd1485bd61667f6cbd2a1
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ad729b4e271d1b594fcd1485bd61667f6cbd2a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[master]: call validation when creating/editing Provider URL for Netwo...
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: call validation when creating/editing Provider URL for Network Provider
......................................................................
call validation when creating/editing Provider URL for Network Provider
added call to validate connection details when testing settings from
ProviderModel.
Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df
Bug-Url: https://bugzilla.redhat.com/1111974
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 18 insertions(+), 3 deletions(-)
Approvals:
Martin Mucha: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b9e9a6b66d800c973334629fa34b3b5443290df
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: Checking isProvisioned instead of the redundant entity isDis...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Checking isProvisioned instead of the redundant entity isDiscovered
......................................................................
Checking isProvisioned instead of the redundant entity isDiscovered
isDiscovered was a mistake which checked only the textbox entity. The
entity is filled with value when there are discovered host, so that
check was wrong.
This patch checks if the flow is for discovered or provisioning based on
the isProvisioned entity, which is set when changing the radio buttons.
Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133540
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: notifier: send sysUpTime in snmp notifications.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: notifier: send sysUpTime in snmp notifications.
......................................................................
notifier: send sysUpTime in snmp notifications.
Sysuptime is measured since the notification service was started.
Time ticks represent a100th of a second.
Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131175
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
(cherry picked from commit cbafd6fc63ab7861b164948775d9e5730963c469)
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
mooli tayer: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Fix layout issues in vNIC dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal,webadmin: Fix layout issues in vNIC dialog
......................................................................
userportal,webadmin: Fix layout issues in vNIC dialog
There were all sorts of layout issues in the dialog in different
locales. This fixes all of them; more space is allocated to the radio
button labels which fixes breakage, and it's put at the end of the
dialog (so all aligned text boxes will appear first).
Change-Id: I31877f7f2370bd92161d2792533e410f16bf0254
Bug-Url: https://bugzilla.redhat.com/1032519
Bug-Url: https://bugzilla.redhat.com/1079877
Bug-Url: https://bugzilla.redhat.com/1115018
Bug-Url: https://bugzilla.redhat.com/1120976
Bug-Url: https://bugzilla.redhat.com/1123747
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
(cherry picked from commit f3dc89c433c9aa5c7eb4a08a9f7fb4d8b967e2ad)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
2 files changed, 24 insertions(+), 41 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31690
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31877f7f2370bd92161d2792533e410f16bf0254
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Slightly amend checkbox header logic
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Slightly amend checkbox header logic
......................................................................
webadmin: Slightly amend checkbox header logic
Previously the logic only relied on enabled entries to determine
whether the checkbox header should be checked or not, however this
produced inconsistent results when all entries are disabled. Special
attention is now paid to that case.
Also, the logic for determining whether an entry is enabled seemed to
be out-of-date and wasn't functioning properly.
Change-Id: I2e7786d55c0f639c0e2f4af4685d125462724175
Bug-Url: https://bugzilla.redhat.com/1100292
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7786d55c0f639c0e2f4af4685d125462724175
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Add some spacing to checkbox cell labels
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add some spacing to checkbox cell labels
......................................................................
webadmin: Add some spacing to checkbox cell labels
Some regression occurred in 3.5 where labels in checkbox cells too
close to the actual checkbox (presumably due to the Look & Feel
patches). This adds some space between them.
Change-Id: I2e345fcfdfb18c8305598e0affc87c2e6c196092
Bug-Url: https://bugzilla.redhat.com/1120984
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/31694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e345fcfdfb18c8305598e0affc87c2e6c196092
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: restapi: Control\view Soundcard property
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Control\view Soundcard property
......................................................................
restapi: Control\view Soundcard property
* Added 'soundcard_enabled' property to REST VM/template/vmpool resource
(accessible via 'All-Content' header)
* Added support for property in:
VM/Template/Instance - Add / Update
Pool - Add
* Updated rsdl
* Updated tests
Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460
Bug-Url: https://bugzilla.redhat.com/1021186
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
16 files changed, 172 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: notifier: send sysUpTime in snmp notifications.
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: notifier: send sysUpTime in snmp notifications.
......................................................................
notifier: send sysUpTime in snmp notifications.
Sysuptime is measured since the notification service was started.
Time ticks represent a100th of a second.
Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131175
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
mooli tayer: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: Fix watchdog configuration for localized webadmin
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: Fix watchdog configuration for localized webadmin
......................................................................
Fix watchdog configuration for localized webadmin
Watchdog settings for type and action were directly translating
the possible values. That caused issues during saving as the
selected enum value could not be detected due to localization.
This updates the code to use the proper way of rendering localized
enums.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135467
Change-Id: Id1ff4c839c112d4a8956cc40f5ee30294c67cc08
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
8 files changed, 100 insertions(+), 96 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Sivák: Verified
--
To view, visit http://gerrit.ovirt.org/32131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1ff4c839c112d4a8956cc40f5ee30294c67cc08
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months