Change in ovirt-engine[master]: restapi: Discard blank "from" parameter
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Discard blank "from" parameter
......................................................................
restapi: Discard blank "from" parameter
Currently when the RESTAPI receives a query with an empth "from"
parameter it generates an exception because it tries to parse the value
as a numeric value. Well behaved callers shouldn't generate this kind of
request, but anyhow the RESTAPI shouldn't fail in this case, it should
just ignore the parameter completely.
Change-Id: I1a909193d17503bb7eb7025b40a56243c6a044bf
Bug-Url: https://bugzilla.redhat.com/1179171
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
1 file changed, 14 insertions(+), 9 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36608
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a909193d17503bb7eb7025b40a56243c6a044bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine-cli[master]: cli: Don't depend on optparse
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Don't depend on optparse
......................................................................
cli: Don't depend on optparse
Currently the dependency on the "optparse" module is deep in the
implementation of the CLI. This causes issues, like unexpected exit from
the "connect" command when passing incorrect options. To avoid these
issues this patch isolates the use of the "optparse" module to the main
program, so that the rest of the code will just receive the already
parsed options.
Change-Id: If3d71de72f929125229e8c8d0e86df5239fad07d
Bug-Url: https://bugzilla.redhat.com/1135550
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/context.py
M src/ovirtcli/infrastructure/context.py
M src/ovirtcli/infrastructure/settings.py
M src/ovirtcli/main.py
M src/ovirtcli/shell/actioncmdshell.py
M src/ovirtcli/shell/addcmdshell.py
M src/ovirtcli/shell/capabilitiescmdshell.py
M src/ovirtcli/shell/clearcmdshell.py
M src/ovirtcli/shell/cmdshell.py
M src/ovirtcli/shell/connectcmdshell.py
M src/ovirtcli/shell/consolecmdshell.py
M src/ovirtcli/shell/disconnectcmdshell.py
M src/ovirtcli/shell/engineshell.py
M src/ovirtcli/shell/filecmdshell.py
M src/ovirtcli/shell/historycmdshell.py
M src/ovirtcli/shell/infocmdshell.py
M src/ovirtcli/shell/listcmdshell.py
M src/ovirtcli/shell/pingcmdshell.py
M src/ovirtcli/shell/removecmdshell.py
M src/ovirtcli/shell/showcmdshell.py
M src/ovirtcli/shell/statuscmdshell.py
M src/ovirtcli/shell/summarycmdshell.py
M src/ovirtcli/shell/updatecmdshell.py
23 files changed, 99 insertions(+), 111 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3d71de72f929125229e8c8d0e86df5239fad07d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine-cli[master]: cli: Remove completely the -p and --password options
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Remove completely the -p and --password options
......................................................................
cli: Remove completely the -p and --password options
These options have already been hidden to the user in previous changes.
This patch removes them completely, and also the overriden methods in
the options parser that were required to support them.
Change-Id: Ic08f2849ef6209819c4b72c26606ec5be1f8248c
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/context.py
M src/ovirtcli/infrastructure/context.py
M src/ovirtcli/infrastructure/options.py
M src/ovirtcli/main.py
4 files changed, 5 insertions(+), 97 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic08f2849ef6209819c4b72c26606ec5be1f8248c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: restapi: Reduce RESTEasy warnings
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Reduce RESTEasy warnings
......................................................................
restapi: Reduce RESTEasy warnings
By default RESTEasy produces a warning message for any failed HTTP
request. This polutes the log and doesn't help, as the generated log
message doesn't contain useful information.
Change-Id: I467f188326b0ee9b0027f151ae4598623d2cbac5
Bug-Url: https://bugzilla.redhat.com/1172197
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.xml.in
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/36196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I467f188326b0ee9b0027f151ae4598623d2cbac5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix UI plugin REST API / Engine session refresh issue
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue
......................................................................
webadmin: Fix UI plugin REST API / Engine session refresh issue
Patch http://gerrit.ovirt.org/#/c/35185/ ensured that UI plugin
REST API session uses the existing Engine user session, instead
of creating a separate one.
This caused REST API session heartbeat mechanism to eventually
keep the Engine user session alive, effectively preventing GUI
from auto-logout due to GUI user's inactivity.
This patch syncs REST API session with Engine user session:
upon each backend call that refreshes Engine session (action
or query with refresh=true), REST API session is refreshed.
REST API session refresh is done max. once per 1 minute to
prevent flooding the backend.
Change-Id: I2ffd3198239040f67313238a837af98db16e79ea
Bug-Url: https://bugzilla.redhat.com/1172726
Bug-Url: https://bugzilla.redhat.com/1168842
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/exclude-filters.xml
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/EngineSessionRefreshed.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManagerTest.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
7 files changed, 89 insertions(+), 12 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit http://gerrit.ovirt.org/36710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Replace ANTLRv4 with JavaCC in OsInfo validation
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Replace ANTLRv4 with JavaCC in OsInfo validation
......................................................................
core: Replace ANTLRv4 with JavaCC in OsInfo validation
A replacement for the ANTLRv4-based validator for the OsInfo properties
file. It uses JavaCC instead, this has the following advantages:
- Generates code that does not depend on any external dependency
- The build dependency is already properly packaged in most distros
On the other hand, the syntax for the grammar file is not as clean as
the ANTLR version.
Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1170258
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
D backend/manager/dependencies/src/main/modules/org/antlr/antlr4-runtime/main/module.xml
M backend/manager/modules/utils/exclude-filters.xml
M backend/manager/modules/utils/pom.xml
D backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java
A backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
M pom.xml
9 files changed, 238 insertions(+), 283 deletions(-)
Approvals:
Vitor de Lima: Verified
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: gluster: Enable RDMA transport type config
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Enable RDMA transport type config
......................................................................
gluster: Enable RDMA transport type config
Enable selection of RDMA transport type while
creating gluster volume
Change-Id: I7142dfef56f2ca7daadd11b162b8210d56d55070
Bug-Url: https://bugzilla.redhat.com/1179074
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
anmolbabu: Looks good to me, but someone else must approve
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/36599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7142dfef56f2ca7daadd11b162b8210d56d55070
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: packaging: spec: fix java-openjdk requirements
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: fix java-openjdk requirements
......................................................................
packaging: spec: fix java-openjdk requirements
Requiring java-openjdk >= 1.7.0 instead of
java-1.7.0-openjdk which is not available on F21
Also requiring a recent java-openjdk instead of
conflicting with an obsolete jdk.
Change-Id: I429f7fffbb551241748b867b9c456c0733ccc705
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/36303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I429f7fffbb551241748b867b9c456c0733ccc705
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin: Fix UI plugin REST API / Engine session refresh issue
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue
......................................................................
webadmin: Fix UI plugin REST API / Engine session refresh issue
Patch http://gerrit.ovirt.org/#/c/35185/ ensured that UI plugin
REST API session uses the existing Engine user session, instead
of creating a separate one.
This caused REST API session heartbeat mechanism to eventually
keep the Engine user session alive, effectively preventing GUI
from auto-logout due to GUI user's inactivity.
This patch syncs REST API session with Engine user session:
upon each backend call that refreshes Engine session (action
or query with refresh=true), REST API session is refreshed.
REST API session refresh is done max. once per 1 minute to
prevent flooding the backend.
Change-Id: I2ffd3198239040f67313238a837af98db16e79ea
Bug-Url: https://bugzilla.redhat.com/1172726
Bug-Url: https://bugzilla.redhat.com/1168842
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/exclude-filters.xml
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/EngineSessionRefreshed.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManagerTest.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
7 files changed, 90 insertions(+), 11 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: wrong cpu_profile on change template cluster
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: wrong cpu_profile on change template cluster
......................................................................
restapi: wrong cpu_profile on change template cluster
When creating VM from template and selecting a cluster
that the template doens't reside on, causes wrong cpu_profile
error.
Fix resets cpu profile when vm's cluster and template's cluster
are not equal.
Change-Id: Ib2cdac29a9cfbe1d6b5fb5ccdb1be68c0f98c038
Bug-Url: https://bugzilla.redhat.com/1172207
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/36696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2cdac29a9cfbe1d6b5fb5ccdb1be68c0f98c038
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months