January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-backup: Do not backup jboss_runtime
by sbonazzo＠redhat.com 08 Jan '15

08 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not backup jboss_runtime ...................................................................... packaging: engine-backup: Do not backup jboss_runtime Do not backup /var/lib/ovirt-engine/jboss_runtime . It's recreated on engine service start and needlessly takes space in the backup. Change-Id: I60a4779ed77fc370ddf1279c3267275d2d338372 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a4779ed77fc370ddf1279c3267275d2d338372 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm AddVmPoolWithVmsCommand.checkDestDomains
by tnisan＠redhat.com 08 Jan '15

08 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: rm AddVmPoolWithVmsCommand.checkDestDomains ...................................................................... core: rm AddVmPoolWithVmsCommand.checkDestDomains Remove the redundant implementation of AddVmPoolWithVmsCommand.checkDestDomains() which did nothing but call its super's implementation. Change-Id: Ib46d484611e41d6328c94426a577c63a10f6f656 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Vered Volansky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib46d484611e41d6328c94426a577c63a10f6f656 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Allow upgrading from 3.6
by sbonazzo＠redhat.com 08 Jan '15

08 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Allow upgrading from 3.6 ...................................................................... packaging: setup: Allow upgrading from 3.6 Change-Id: If8e5e87f107248dba09daade09a8167e470c6222 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e5e87f107248dba09daade09a8167e470c6222 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Override firewall configurations on deploy for provisioned h...
by oourfali＠redhat.com 08 Jan '15

08 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: Override firewall configurations on deploy for provisioned hosts ...................................................................... Override firewall configurations on deploy for provisioned hosts Currently we don't have parameter for override-firewall configurations in hosts\[id]\install restapi. Therefore we cannot pass this parameter along the way from foreman to engine. Until adding the parameter to the API this patch hacks the code to always override the firewall configurations for vdsm deploy for each foreman installation when updateVdsCommand is initiated by the reinstall request. This is monitored by checking that the host in InstallingOS status, which can be only if the host is firstly being provisioned by foreman. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177126 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Change-Id: I2634c33d87e9ef8ef41deeac28287b3b7ae1344a --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2634c33d87e9ef8ef41deeac28287b3b7ae1344a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Update only name and address fields when picking foreman par...
by oourfali＠redhat.com 08 Jan '15

08 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: Update only name and address fields when picking foreman parameters ...................................................................... Update only name and address fields when picking foreman parameters With updateModelFromVds we change other fields with no intention. Change-Id: Ia7eadb533dd02698f07103fa61e076b46d054522 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1178009 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 1 file changed, 8 insertions(+), 11 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7eadb533dd02698f07103fa61e076b46d054522 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Override firewall configurations on deploy for provisioned h...
by oourfali＠redhat.com 08 Jan '15

08 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: Override firewall configurations on deploy for provisioned hosts ...................................................................... Override firewall configurations on deploy for provisioned hosts Currently we don't have parameter for override-firewall configurations in hosts\[id]\install restapi. Therefore we cannot pass this parameter along the way from foreman to engine. Until adding the parameter to the API this patch hacks the code to always override the firewall configurations for vdsm deploy for each foreman installation when updateVdsCommand is initiated by the reinstall request. This is monitored by checking that the host in InstallingOS status, which can be only if the host is firstly being provisioned by foreman. https://bugzilla.redhat.com/show_bug.cgi?id=1177126 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Change-Id: I2634c33d87e9ef8ef41deeac28287b3b7ae1344a --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2634c33d87e9ef8ef41deeac28287b3b7ae1344a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Update only name and address fields when picking foreman par...
by oourfali＠redhat.com 08 Jan '15

08 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: Update only name and address fields when picking foreman parameters ...................................................................... Update only name and address fields when picking foreman parameters With updateModelFromVds we change other fields with no intention. Change-Id: Ia7eadb533dd02698f07103fa61e076b46d054522 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1178009 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 1 file changed, 8 insertions(+), 11 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7eadb533dd02698f07103fa61e076b46d054522 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removing redundant method midifier
by mlipchuk＠redhat.com 08 Jan '15

08 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Removing redundant method midifier ...................................................................... core: Removing redundant method midifier Removing public modifier in the StorageServerConnectionDAO interface. Quoting from the JLS: It is permitted, but discouraged as a matter of style, to redundantly specify the public and/or abstract modifier for a method declared in an interface. Change-Id: Ia0b950da2434379b2c23c6dc878bd613fbbef4b5 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/36666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0b950da2434379b2c23c6dc878bd613fbbef4b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: Use hostname for host address
by sbonazzo＠redhat.com 08 Jan '15

08 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Use hostname for host address ...................................................................... packaging: setup: Use hostname for host address And not IP address. Remove _getIPAddress which isn't used anymore. Change-Id: I6a2fc79fe6e57892f0cb9327da1ab8d44b15f29f Bug-Url: https://bugzilla.redhat.com/1178535 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit dc8d1a67aec35914a4a16b74ef1a60ddd111a857) --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py 2 files changed, 11 insertions(+), 40 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a2fc79fe6e57892f0cb9327da1ab8d44b15f29f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Storage allocation validation fix on new VMs
by amureini＠redhat.com 08 Jan '15

08 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Storage allocation validation fix on new VMs ...................................................................... core: Storage allocation validation fix on new VMs In the current situation, allocation checks are done on the template disk, which may be of the wrong storage type/format. Updating the image's data to support the allocation validations. Change-Id: I13f8585a04157a55528ad4331455c3f156bdb84b Bug-Url: https://bugzilla.redhat.com/1179688 Bug-Url: https://bugzilla.redhat.com/1178021 Bug-Url: https://bugzilla.redhat.com/1179690 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommandTest.java 9 files changed, 111 insertions(+), 99 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f8585a04157a55528ad4331455c3f156bdb84b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0