January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine: Cache VM from configuration when cloning from snapshot
by tnisan＠redhat.com 06 Jan '15

06 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Cache VM from configuration when cloning from snapshot ...................................................................... engine: Cache VM from configuration when cloning from snapshot The previous implementation didn't cache the VM from configuration, therefore though its interfaces' vNIC profile IDs were updated, that didn't really take effect when looking for the profile to assign to the cloned interfaces. Change-Id: I37096b1e8596c7c52fc5ced61008ab1e17a6051d Bug-Url: https://bugzilla.redhat.com/1178508 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Lior Vernia: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37096b1e8596c7c52fc5ced61008ab1e17a6051d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove unused imports in AddVdsCommand
by laravot＠redhat.com 06 Jan '15

06 Jan '15

Liron Aravot has submitted this change and it was merged. Change subject: core: remove unused imports in AddVdsCommand ...................................................................... core: remove unused imports in AddVdsCommand Change-Id: I827b3e5dcab7741bfadfe8af62b8ee087ce2e0e5 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Vered Volansky: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I827b3e5dcab7741bfadfe8af62b8ee087ce2e0e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix PM settings in new host
by emesika＠redhat.com 06 Jan '15

06 Jan '15

Eli Mesika has submitted this change and it was merged. Change subject: core: fix PM settings in new host ...................................................................... core: fix PM settings in new host This patch fixes the following issue: 1) Add a new host to cluster, PM tab has these settings: Enable PM: true Kdump integration: false Type: ipmilan UserName, Password: filled in 2) Click to OK, host is deployed with success 3) Check the DB, that host doesn't have any records in fence_agents table 4) Try to Edit the host, PM tab contains these settings: Enable PM: true Kdump integration: false Type: apc UserName, Password: empty 5) Fill in data again and click OK 6) fence_agents table contains record for the host Change-Id: I13ebea573105b7e8f6f8e7a33251e40ec11c165b Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13ebea573105b7e8f6f8e7a33251e40ec11c165b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Cache VM from configuration when cloning from snapshot
by lvernia＠redhat.com 06 Jan '15

06 Jan '15

Lior Vernia has submitted this change and it was merged. Change subject: engine: Cache VM from configuration when cloning from snapshot ...................................................................... engine: Cache VM from configuration when cloning from snapshot The previous implementation didn't cache the VM from configuration, therefore though its interfaces' vNIC profile IDs were updated, that didn't really take effect when looking for the profile to assign to the cloned interfaces. Change-Id: I37096b1e8596c7c52fc5ced61008ab1e17a6051d Bug-Url: https://bugzilla.redhat.com/1178508 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Lior Vernia: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37096b1e8596c7c52fc5ced61008ab1e17a6051d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Add validation for engine_data
by dougsland＠redhat.com 06 Jan '15

06 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Add validation for engine_data ...................................................................... engine_page: Add validation for engine_data Avoid engine_data getting non valid data. Change-Id: I75b9c20ab4bed89509da569ee6e3de0bf4c8779f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Anatoly Litovsky: Verified -- To view, visit http://gerrit.ovirt.org/36583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75b9c20ab4bed89509da569ee6e3de0bf4c8779f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: Fixing dao error and unit test break
by emesika＠redhat.com 06 Jan '15

06 Jan '15

Eli Mesika has submitted this change and it was merged. Change subject: db: Fixing dao error and unit test break ...................................................................... db: Fixing dao error and unit test break Changing stored procedure to return view as gluster_volume_name is queried from resultset Change-Id: I7fa91c7b12d2de12469f06b680a10dfa462ef98c Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/dbscripts/gluster_georep_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/36611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa91c7b12d2de12469f06b680a10dfa462ef98c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: bll: stop and delete geo-rep session
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: bll: stop and delete geo-rep session ...................................................................... bll: stop and delete geo-rep session Stop and delete geo-replication sessions for a volume Change-Id: I537a11bde7c412599a00269d44764f554bb4618d Bug-Url: https://bugzilla.redhat.com/1125845 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 261 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/33038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I537a11bde7c412599a00269d44764f554bb4618d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : VDS Command to start geo-rep session
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine : VDS Command to start geo-rep session ...................................................................... engine : VDS Command to start geo-rep session VDS Command to start geo-rep session Change-Id: Ifb18e64dfcf66d61361f958ded9824213e9847a0 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeGeoRepVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 10 files changed, 48 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb18e64dfcf66d61361f958ded9824213e9847a0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Allow simultaneous add of gluster host
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Allow simultaneous add of gluster host ...................................................................... engine: Allow simultaneous add of gluster host If multiple hosts are being provisioned using Foreman and being added to the cluster, then this should be allowed The peer probe of hosts to the cluster, will happen when the host finished installation and first moves to UP state Change-Id: I3f1f81c90d2ec727159a2ed4d147a0acffd60ab9 Bug-Url: https://bugzilla.redhat.com/1142779 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/35635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f1f81c90d2ec727159a2ed4d147a0acffd60ab9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: UI button to refresh geo-rep sessions
by kmayilsa＠redhat.com 06 Jan '15

06 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: UI button to refresh geo-rep sessions ...................................................................... webadmin: UI button to refresh geo-rep sessions Added a button in the Geo-replication sub-tab that will enable users to invoke syncing of geo-replication sessions for a volume with Gluster backend. Change-Id: Ia15b611a0a5ceae6678062f7f789d0642aa757f9 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java 3 files changed, 33 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/34691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia15b611a0a5ceae6678062f7f789d0642aa757f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0