October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: engine: Update command associated entities instantly
by tnisan＠redhat.com 19 Oct '15

19 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Update command associated entities instantly ...................................................................... engine: Update command associated entities instantly The command associated entities shouldn't be considered as part of any command's transaction. The root cause of this bug is a difference between the behavior of postgres 8.4 and 9.1. In the described scenarios (and other similar to this issue as we faced on AddVmTemplate) we have the following sequence: On The main thread: Open new transaction (either explicit or as default command's scope): CommandCoordinatorUtil.executeAsyncCommand(...) | +-- coco.persistCommandAssociatedEntities(...) which internally updates command_assoc_entities table On the submitted thread we calls: CommandBase.setCommandStatus() which updates the command_entities table. The first update of 'command_assoc_entities' table is done on transaction Tx1 a, which is open. While Tx1 is open, the update for 'command_entities' is executed in other transaction Tx2. In postgres 9.1, that scenario is permitted without any locking on the command_entities table. However in postgres 8.4, an update for 'command_entities' isn't permitted, unless the referred table 'command_assoc_entities' is closed. In order to make the code compliant for both postgres versions, the first update to 'command_assoc_entities' should be immediately committed. Change-Id: I50496b6bdf0627f74b9458967a52323d377cea7a Bug-Url: https://bugzilla.redhat.com/1264691 Signed-off-by: Moti Asayag <masayag(a)redhat.com> (cherry picked from commit de42c406433b9419c9ad0fcd04d36251b0b29a99) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/47450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50496b6bdf0627f74b9458967a52323d377cea7a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: open log file in append mode
by masayag＠redhat.com 19 Oct '15

19 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: tools: open log file in append mode ...................................................................... tools: open log file in append mode Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1272761 Change-Id: I62840b96def6b446f3adfcbd651d7829aaac75ab Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62840b96def6b446f3adfcbd651d7829aaac75ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: debug version string
by masayag＠redhat.com 19 Oct '15

19 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: debug version string ...................................................................... exttool: debug version string Change-Id: I3f048972f1cdfd40553ec4a97fbbe558f256a55d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f048972f1cdfd40553ec4a97fbbe558f256a55d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: build: post ovirt-engine-3.6.0.1
by piotr.kliczewski＠gmail.com 19 Oct '15

19 Oct '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.0.1 ...................................................................... build: post ovirt-engine-3.6.0.1 Change-Id: I011f620e4eb4897dedc1bf65221d1c88e11031a3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 58 files changed, 65 insertions(+), 62 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I011f620e4eb4897dedc1bf65221d1c88e11031a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: model hibernation volumes as disks in database
by ahadas＠redhat.com 19 Oct '15

19 Oct '15

Arik Hadas has submitted this change and it was merged. Change subject: core: model hibernation volumes as disks in database ...................................................................... core: model hibernation volumes as disks in database Hibernation volumes were represented as comma-separated string: <storage domain>,<storage pool>,<dump disk id>,<dump image id>, <conf disk id>,<conf image id> This patch changes the memory dump and memory conf volumes to be modeled as disks in the database. We distinguish memory related disks from others by checking if the snapshots table refers to them as such that contain memory dump or memory conf. We currently filter all the memory related disks in most of the queries from the database so they are not displayed in the grid of disks for example. We expose them only in queries that must return them in order to be able to restore hibernated VM and to delete them when they are not relevant anymore. The new views are temporary! This patch is only a step towards removing the comma-separated string representation of the memory volumes and to treat them as regular disks in different flows in the system. In addition, this patch converts hibernation volumes that existed before this change to disks. Change-Id: I295bd98ead191c1eab54c471ea28a217dee52051 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/create_views.sql M packaging/dbscripts/disk_images_sp.sql A packaging/dbscripts/upgrade/03_06_1930_convert_hibernation_volumes_to_disks.sql 4 files changed, 354 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295bd98ead191c1eab54c471ea28a217dee52051 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: build: pom.xml: use released ovirt-host-deploy artifact
by sbonazzo＠redhat.com 19 Oct '15

19 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: pom.xml: use released ovirt-host-deploy artifact ...................................................................... build: pom.xml: use released ovirt-host-deploy artifact Change-Id: I657b2e58b17f4aa26027a1149b359c424dfef3c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I657b2e58b17f4aa26027a1149b359c424dfef3c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Update command associated entities instantly
by masayag＠redhat.com 19 Oct '15

19 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Update command associated entities instantly ...................................................................... engine: Update command associated entities instantly The command associated entities shouldn't be considered as part of any command's transaction. The root cause of this bug is a difference between the behavior of postgres 8.4 and 9.1. In the described scenarios (and other similar to this issue as we faced on AddVmTemplate) we have the following sequence: On The main thread: Open new transaction (either explicit or as default command's scope): CommandCoordinatorUtil.executeAsyncCommand(...) | +-- coco.persistCommandAssociatedEntities(...) which internally updates command_assoc_entities table On the submitted thread we calls: CommandBase.setCommandStatus() which updates the command_entities table. The first update of 'command_assoc_entities' table is done on transaction Tx1 a, which is open. While Tx1 is open, the update for 'command_entities' is executed in other transaction Tx2. In postgres 9.1, that scenario is permitted without any locking on the command_entities table. However in postgres 8.4, an update for 'command_entities' isn't permitted, unless the referred table 'command_assoc_entities' is closed. In order to make the code compliant for both postgres versions, the first update to 'command_assoc_entities' should be immediately committed. Change-Id: I50496b6bdf0627f74b9458967a52323d377cea7a Bug-Url: https://bugzilla.redhat.com/1264691 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50496b6bdf0627f74b9458967a52323d377cea7a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove snapshot job remains open
by masayag＠redhat.com 19 Oct '15

19 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove snapshot job remains open ...................................................................... engine: Remove snapshot job remains open The patch fixes few issues with snapshot remove implementation: 1. Commit ad1ac46bf56de9000f6562b7a5d3997326ed9121 has introduced a change in commands with callback behavior regarding closing the job. As a result of that patch, the responsibility of closing the job associated with the command is passed to the callback. 2. The RemoveSnapshotCommand was missing a c'tor which associates the cached command's context with its new instance while retrieved by CoCo. Without this c'tor, the command couldn't monitor the job's progress. 3. Although the command uses compensation, it doesn't introduce the required c'tor for it. Change-Id: Ia1331fc864e001a04c0ac1ec6a2b1f500e8fe59e Bug-Url: https://bugzilla.redhat.com/1257529 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/47444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1331fc864e001a04c0ac1ec6a2b1f500e8fe59e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Update maxSchedulingMemory in VDS when related values ...
by rgolan＠redhat.com 18 Oct '15

18 Oct '15

Roy Golan has submitted this change and it was merged. Change subject: core: Update maxSchedulingMemory in VDS when related values change ...................................................................... core: Update maxSchedulingMemory in VDS when related values change When cloning VDS instances the calculeated maxSchedulingMemory was calculated wrong. Now VDS recalculates maxSchedulingMemory whenever a variable, which is part of the calculation changes. This bug had no consequences because maxSchedulingMemory is currently not read from cloned VDS instances. Change-Id: I903d4c039be052ce0044f2a9eebe889cdfd5cb25 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 3 files changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903d4c039be052ce0044f2a9eebe889cdfd5cb25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : Fix scenario where CoCo child executes Async Tasks
by masayag＠redhat.com 18 Oct '15

18 Oct '15

Moti Asayag has submitted this change and it was merged. Change subject: engine : Fix scenario where CoCo child executes Async Tasks ...................................................................... engine : Fix scenario where CoCo child executes Async Tasks When CoCo command with callback executes a command that starts an async task the endSuccessfully of the CoCo command is being invoked as it is the parent of command that executes the async task. The CoCo command with callback should not be considered parent of the command executing async task. Change-Id: Ib3261800f383a6e3973acab4bd16079594fa4149 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/03_06_1920_add_cmd_entity_parent_command_id.sql 13 files changed, 120 insertions(+), 114 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3261800f383a6e3973acab4bd16079594fa4149 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0