Change in ovirt-engine[master]: core : Remove unsupported create volume call
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core : Remove unsupported create volume call
......................................................................
core : Remove unsupported create volume call
The create volume verb with size as integer (unit are sectors) is not
supported anymore by Vdsm.
The supported verb is with size as String (units are bytes).
Change-Id: If4e8cbd330899f7d8d33689787470da7f20097a1
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4e8cbd330899f7d8d33689787470da7f20097a1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core, restapi: DiskMapper - invalidate ActualSize for Cinder ...
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core,restapi: DiskMapper - invalidate ActualSize for Cinder disks
......................................................................
core,restapi: DiskMapper - invalidate ActualSize for Cinder disks
ActualSize is not applicable for Cinder disks, hence,
setting it in DiskMapper only for DiskImage.
Added 'hasActualSize' flag to CinderDisk/DiskImage
entities accordingly.
Change-Id: Ide510ecd69c57220b87c49b7e4fbf50c22b33708
Bug-Url: https://bugzilla.redhat.com/1271721
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImage.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
3 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47458
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide510ecd69c57220b87c49b7e4fbf50c22b33708
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: restapi: Remove "Movable" and "Copyable" interfaces
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove "Movable" and "Copyable" interfaces
......................................................................
restapi: Remove "Movable" and "Copyable" interfaces
This patch removes the "Copyable" and "Moveable" JAX-RS resource
interfaces, as they don't add anything and they are an obstacle for the
introduction of the new service model.
Change-Id: Idf06d70c1037ecbc6f904bacfa953084b0597982
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CopyableResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/MovableCopyableDiskResource.java
D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/MovableResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
5 files changed, 38 insertions(+), 48 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf06d70c1037ecbc6f904bacfa953084b0597982
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Remove deprecated config value
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove deprecated config value
......................................................................
core: Remove deprecated config value
Change-Id: I373623254bcc368613d4eae80ae40787c9699bf2
Bug-Url: https://bugzilla.redhat.com/1254957
Bug-Url: https://bugzilla.redhat.com/1212461
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerStrategy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/03_06_1910_remove_deprecated_config_value.sql
M packaging/etc/engine-config/engine-config.properties
5 files changed, 5 insertions(+), 24 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46676
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I373623254bcc368613d4eae80ae40787c9699bf2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: avoid asking about mgmt bridge nic on addi...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: avoid asking about mgmt bridge nic on additional hosts
......................................................................
packaging: setup: avoid asking about mgmt bridge nic on additional hosts
On additional host we are not directly creating the management bridge.
We simply call host.add via REST API and the engine will do the rest
via host-deploy. So avoid asking about the interface to create the
management bridge on cause we are not honoring it.
The engine will choose it exactly as it does for regular non HE hosts.
Bug-Url: https://bugzilla.redhat.com/1269430
Change-Id: Ibcb56997b17fe04dbccf25fa2a3bd9c79e5da8e9
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcb56997b17fe04dbccf25fa2a3bd9c79e5da8e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-hosted-engine-setup[master]: setup: avoid restart and destroy VM options at the add_host ...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: avoid restart and destroy VM options at the add_host plugin
......................................................................
setup: avoid restart and destroy VM options at the add_host plugin
Restart and destroy VM options make sense only if on the first
host and at initial stages.
If already at add_host plugin we have simply to add the host to the
engine.
So:
- reordering options cause only 1 and 2 are always significative
- avoiding options 3 and 4 if already at add_host
Change-Id: I8d57245ccfc5c1f66bf03699acb3f197c9068ff1
Bug-Url: https://bugzilla.redhat.com/1271511
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/check_liveliness.py
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47371
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d57245ccfc5c1f66bf03699acb3f197c9068ff1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: services: ovirt-engine: set jdwp only for the eng...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: services: ovirt-engine: set jdwp only for the engine process
......................................................................
packaging: services: ovirt-engine: set jdwp only for the engine process
avoid conflict when already run and trying to detect jboss version when
debug enabled.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1271521
Change-Id: I7e060dc867ea1aac10f944826b9172231f60b982
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.py
1 file changed, 18 insertions(+), 20 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e060dc867ea1aac10f944826b9172231f60b982
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6.0]: packaging: spec: make docker optional
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: spec: make docker optional
......................................................................
packaging: spec: make docker optional
Make docker packaging optional
Change-Id: I912c7044ad696edebfe08c7452f06456c3f8733a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I912c7044ad696edebfe08c7452f06456c3f8733a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: spec: make docker optional
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: spec: make docker optional
......................................................................
packaging: spec: make docker optional
Make docker packaging optional
Change-Id: I912c7044ad696edebfe08c7452f06456c3f8733a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I912c7044ad696edebfe08c7452f06456c3f8733a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 3 months
Change in ovirt-engine[master]: core: Remove deprecated config value
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove deprecated config value
......................................................................
core: Remove deprecated config value
Change-Id: I373623254bcc368613d4eae80ae40787c9699bf2
Bug-Url: https://bugzilla.redhat.com/1254957
Bug-Url: https://bugzilla.redhat.com/1212461
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerStrategy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/03_06_1940_remove_deprecated_config_value.sql
M packaging/etc/engine-config/engine-config.properties
5 files changed, 5 insertions(+), 24 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/46672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I373623254bcc368613d4eae80ae40787c9699bf2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months