October 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: Refactoring initialization of VmInit in RunVmCommand

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: Refactoring initialization of VmInit in RunVmCommand ...................................................................... Refactoring initialization of VmInit in RunVmCommand Loading of VmInit should not be in CanDoAction. Change-Id: I47a6272649be8a4e3d3429fe0d5d29b8e3b519ae Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 6 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47a6272649be8a4e3d3429fe0d5d29b8e3b519ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: spec: make docker optional

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: make docker optional ...................................................................... packaging: spec: make docker optional Make docker packaging optional Change-Id: I912c7044ad696edebfe08c7452f06456c3f8733a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I912c7044ad696edebfe08c7452f06456c3f8733a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: engine : Can't remove vm template - the disks are removed an...

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine : Can't remove vm template - the disks are removed and the template stays locked ...................................................................... engine : Can't remove vm template - the disks are removed and the template stays locked The patch Ib3261800f383a6e3973acab4bd1 caused regression in commands that ran Async Tasks. This patch reverts the changes in CommandBase related to AsyncTasks and implements a simpler solution using existing shouldBeEndedByParent flag in VdcActionParametersBase. Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667 Bug-Url: https://bugzilla.redhat.com/1273094 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 2 files changed, 16 insertions(+), 81 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Make the Format checkbox false by default.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Make the Format checkbox false by default. ...................................................................... webadmin: Make the Format checkbox false by default. The default value of the format checkbox when removing a Storage Domain should be false by default. Change-Id: I554a98897c50dbbdd158616089d1d96ec065976b Bug-Url: https://bugzilla.redhat.com/1268824 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RemoveStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I554a98897c50dbbdd158616089d1d96ec065976b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Wrap GeneralFormPanel labels

by awels＠redhat.com

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Wrap GeneralFormPanel labels ...................................................................... webadmin: Wrap GeneralFormPanel labels - We were forcing labels to not wrap, which causes overlapping issues when there is not enough room to contain the text. This patch removes the nowrap which now allows the labels to wrap if needed. Change-Id: Ie99882dc32308361879c3ba603d8d9af03289860 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269415 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie99882dc32308361879c3ba603d8d9af03289860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: tools: open log file in append mode

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: tools: open log file in append mode ...................................................................... tools: open log file in append mode Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1272761 Change-Id: I62840b96def6b446f3adfcbd651d7829aaac75ab Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/JavaLoggingUtils.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62840b96def6b446f3adfcbd651d7829aaac75ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: webadmin: Configure local storage does not work

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Configure local storage does not work ...................................................................... webadmin: Configure local storage does not work Fixed the cluster and data center validations to validate only the stuff needed for configure local storage, that way we also avoid the exceptions that are breaking the dialog functionality Bug-Url: https://bugzilla.redhat.com/1270826 Change-Id: I424a6f618c3c3968b169fc49e1140cddf3c57bb6 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 3 files changed, 30 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I424a6f618c3c3968b169fc49e1140cddf3c57bb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: standardization of hibernate command

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: standardization of hibernate command ...................................................................... core: standardization of hibernate command 1. Just start to create the disks in the execute phase, no need to update the active snapshot's memory in advance - will do it in the end-action phase, in case we managed to create the disks. 2. Change the way we get the created disks: instead of querying the DB in the parent command, the add-disk command returns the created disk in its end-action phase. This is a better approach since we will need to have the same logic in import from external provider command. 3. Cleanup the end-with-failure case: in case of a failure, just need to make sure we clean the memory from the active snapshot and remove the disks (revert tasks). Change-Id: Ib7c97fb3907b155eb5d5d03b665ab80814da8229 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 3 files changed, 66 insertions(+), 72 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7c97fb3907b155eb5d5d03b665ab80814da8229 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: build: pom.xml: use released ovirt-host-deploy artifact

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: build: pom.xml: use released ovirt-host-deploy artifact ...................................................................... build: pom.xml: use released ovirt-host-deploy artifact Change-Id: I657b2e58b17f4aa26027a1149b359c424dfef3c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I657b2e58b17f4aa26027a1149b359c424dfef3c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Make the Format checkbox false by default.

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Make the Format checkbox false by default. ...................................................................... webadmin: Make the Format checkbox false by default. The default value of the format checkbox when removing a Storage Domain should be false by default. Change-Id: I554a98897c50dbbdd158616089d1d96ec065976b Bug-Url: https://bugzilla.redhat.com/1268824 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RemoveStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I554a98897c50dbbdd158616089d1d96ec065976b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2015