October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: get rid of obsoleted getVolumePath calls
by msivak＠redhat.com 09 Oct '15

09 Oct '15

Martin Sivák has submitted this change and it was merged. Change subject: get rid of obsoleted getVolumePath calls ...................................................................... get rid of obsoleted getVolumePath calls Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269837 Change-Id: Ia0f4663141a9901af9edd9361ac9fe55f8c918bc Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 44 insertions(+), 42 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f4663141a9901af9edd9361ac9fe55f8c918bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: fix login form locale box
by tnisan＠redhat.com 09 Oct '15

09 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fix login form locale box ...................................................................... userportal, webadmin: fix login form locale box Login form locale select box needed an extra bootstrap column to prevent all values from being truncated. Change-Id: Iedc126ead5fd474aaf5caa58df28dcd6e5603823 Bug-Url: https://bugzilla.redhat.com/1255606 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/47145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedc126ead5fd474aaf5caa58df28dcd6e5603823 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Mock cleanup fix
by dcaroest＠redhat.com 09 Oct '15

09 Oct '15

David Caro has submitted this change and it was merged. Change subject: Mock cleanup fix ...................................................................... Mock cleanup fix Change-Id: Ic3fc1d158aff1b3579277b13b8ebdb4348727b7d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/47131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3fc1d158aff1b3579277b13b8ebdb4348727b7d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix login form locale box
by gshereme＠redhat.com 08 Oct '15

08 Oct '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: fix login form locale box ...................................................................... userportal, webadmin: fix login form locale box Login form locale select box needed an extra bootstrap column to prevent all values from being truncated. Change-Id: Iedc126ead5fd474aaf5caa58df28dcd6e5603823 Bug-Url: https://bugzilla.redhat.com/1255606 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/47143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedc126ead5fd474aaf5caa58df28dcd6e5603823 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: fix scheduler, ignoring white list if there are dedica...
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix scheduler, ignoring white list if there are dedicates hosts ...................................................................... core: fix scheduler, ignoring white list if there are dedicates hosts Fixed the case when there are dedicated hosts, but non available. Then take the best host from the white list (from available hosts on cluster). Bug due to wrong 'else' condition. Change-Id: I05e1c322f01563db2e08a362acee2395dde14b22 Bug-Url: https://bugzilla.redhat.com/1243811 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05e1c322f01563db2e08a362acee2395dde14b22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: untranslated errata-related error messages
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: untranslated errata-related error messages ...................................................................... webadmin: untranslated errata-related error messages Some errata-related error messages were missing from the web-admin's AppError.properties file. As a result, those error messages were retrieved from the English defaults as they appear in AppErrors.java for all locales. This patch adds the missing (English) error messages to the web-admin's AppError.properties file (as instructed in [1]). Once these messages will be translated, the messages will appear in the relevant locale in the GUI (will be performed separately in a different patch). [1] http://www.ovirt.org/Engine_Adding_Messages Change-Id: Ibc642033b996c081982b2155e1bef150b1afaa5a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269090 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Einav Cohen: Verified -- To view, visit https://gerrit.ovirt.org/47142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc642033b996c081982b2155e1bef150b1afaa5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix scheduler, ignoring white list if there are dedica...
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix scheduler, ignoring white list if there are dedicates hosts ...................................................................... core: fix scheduler, ignoring white list if there are dedicates hosts Fixed the case when there are dedicated hosts, but non available. Then take the best host from the white list (from available hosts on cluster). Bug due to wrong 'else' condition. Change-Id: I05e1c322f01563db2e08a362acee2395dde14b22 Bug-Url: https://bugzilla.redhat.com/1243811 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05e1c322f01563db2e08a362acee2395dde14b22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: sercon: servlet: db: send correct login name
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: sercon: servlet: db: send correct login name ...................................................................... sercon: servlet: db: send correct login name According to the ovirt-vmconsole API, the user name should be provided in entity not username json field. This patch makes sure this is true. This patch also includes commit 8bd9459 to fix tests. Change-Id: I403da73da8cbeb1931ac67909e3a4431a49a2909 Bug-Url: https://bugzilla.redhat.com/1266135 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UserProfileDaoTest.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java M packaging/dbscripts/create_views.sql 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Passed CI tests Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I403da73da8cbeb1931ac67909e3a4431a49a2909 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: sercon: backend: always use serial console type
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: sercon: backend: always use serial console type ...................................................................... sercon: backend: always use serial console type VirtIO console device type is still unsafe to use as default. There even was reports of Guests crashing at boot. We should use 'serial' type as default. Bug-Url: https://bugzilla.redhat.com/1223671 Change-Id: Ida22d08ddf7115b431bb477c7e34c19c2271e3da Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A packaging/dbscripts/upgrade/03_06_1860_add_type_spec_param_to_console_devices.sql 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Verified Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida22d08ddf7115b431bb477c7e34c19c2271e3da Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: Correctly finish Remove VM Pool job
by tnisan＠redhat.com 08 Oct '15

08 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Correctly finish Remove VM Pool job ...................................................................... core: Correctly finish Remove VM Pool job For every VM in the pool removed, the endAction() of the corresponding RemoveVmCommand must be called. For this purpose, RemoveVmCommand must be parent command of all async tasks, not RemoveVmPoolCommand. Also, adding IDs of all async tasks to the return value of RemoveVmPoolCommand (RemoveVmCommand also needed to be fixed to add the IDs to the correct list if RemoveVmCommand is executed as internal command). Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257132 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Peřina: Looks good to me, approved Shmuel Leib Melamud: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/47126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0