Change in ovirt-engine[ovirt-engine-3.5]: JsonRpcVdsServer: spmStart() to pass the needed domain version
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: JsonRpcVdsServer: spmStart() to pass the needed domain version
......................................................................
JsonRpcVdsServer: spmStart() to pass the needed domain version
Currently JsonRpcVdsServer.spmStart() isn't passing the domVersion
parameter to vdsm, that parameter is used by vdsm for verification and
for running an upgrade on all the relevant domains to match the version.
Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f
Bug-Url: https://bugzilla.redhat.com/1269411
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/46027
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in jenkins[master]: Add job to build the JBoss Modules Maven Plugin
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Add job to build the JBoss Modules Maven Plugin
......................................................................
Add job to build the JBoss Modules Maven Plugin
This patch adds the SCM configuration and the stardard-ci jobs
including the job required to build the JBoss Modules Maven Plugin.
Also added to the master publisher
Change-Id: I706b4d1ca60926bb3645a14d650c13ea174d6ff4
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A jobs/confs/projects/ovirt-jboss-modules-maven-plugin/ovirt-jboss-modules-maven-plugin_build-artifacts.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
A jobs/confs/yaml/scms/ovirt-jboss-modules-maven-plugin.yaml
3 files changed, 27 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me; Ready for review
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for merge
--
To view, visit https://gerrit.ovirt.org/47072
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I706b4d1ca60926bb3645a14d650c13ea174d6ff4
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: revert dc version if no update occured.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: revert dc version if no update occured.
......................................................................
core: revert dc version if no update occured.
When failing to upgrade the storage pool the engine can revert back the
updated db in case it's known that no upgrade occured, we can also avoid
refresh the pool metadata on the hosts as nothing was executed.
Change-Id: I76caab42815f5f7bb7627979ba5d25059fd88617
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261956
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 35 insertions(+), 20 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/46021
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76caab42815f5f7bb7627979ba5d25059fd88617
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: spmStart failure when clusterlock inquire isn't supported
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: spmStart failure when clusterlock inquire isn't supported
......................................................................
core: spmStart failure when clusterlock inquire isn't supported
As part of the SPM selection flow in the engine we run getSpmStatus()
on the candidate host to get the current spm status (if possible) and
we act according to the result.
After an "offline" (when the dc is down) DC upgrade from DC that uses
V1 for it's domain (3.0 for example) to a version that uses the
StoragePoolMemoryBackend we might fail when attempting to get the current
spm status, that's because StoragePoolMemoryBackend relies on the fact
that the used clusterlock supports inquiring while it might not.
This patch ignores the failure of getSpmStatus() if the failure is
InquireNotSupportedError and attempts to start the spm, if the cluster
lock is acquired we'll fail on the spmStart flow.
Change-Id: I996fc4454c210dd278dafa9d94a13c4981162f5b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242092
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
2 files changed, 119 insertions(+), 73 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/46020
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I996fc4454c210dd278dafa9d94a13c4981162f5b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: JsonRpcVdsServer: spmStart() to pass the needed domain version
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: JsonRpcVdsServer: spmStart() to pass the needed domain version
......................................................................
JsonRpcVdsServer: spmStart() to pass the needed domain version
Currently JsonRpcVdsServer.spmStart() isn't passing the domVersion
parameter to vdsm, that parameter is used by vdsm for verification and
for running an upgrade on all the relevant domains to match the version.
Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242092
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/46019
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core: use @Inject instead of Injector
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: use @Inject instead of Injector
......................................................................
core: use @Inject instead of Injector
Use @Inject to introduce BackendInternal in CommandBase instead of using
Injector.
Change-Id: Id076abafe06fbc7d56a3ba8417429e4471082a42
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47036
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id076abafe06fbc7d56a3ba8417429e4471082a42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: engine, webadmin: Clear all option in RHEV admin portal does...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine, webadmin: Clear all option in RHEV admin portal does not clear any alerts
......................................................................
engine, webadmin: Clear all option in RHEV admin portal does not clear any alerts
The events footer table show both events and alerts.
The events footer table should display only events and
the clear and display operations on this table should
only work with events.
Change-Id: If98e235beb4283da359782c79fc5e1598a9f0579
Bug-Url: https://bugzilla.redhat.com/1206264
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDaoImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/EventModelProvider.java
M packaging/dbscripts/audit_log_sp.sql
5 files changed, 31 insertions(+), 5 deletions(-)
Approvals:
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If98e235beb4283da359782c79fc5e1598a9f0579
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: engine : CoCo infrastructure should provide a timeout for ea...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : CoCo infrastructure should provide a timeout for each command
......................................................................
engine : CoCo infrastructure should provide a timeout for each command
A new vdc_option in the database CoCoCommandLifeInMinutes
determines the lifetime of a command. A command that is
still in Active status after the lifetime is marked as Failed.
The onFailed method is invoked on the command's callback which
is responsible for releasing any locks on the entities.
Commands can fine tune the life time of a command by
invoking VdcActionParametersBase.setLifeInMinutes
Change-Id: I984f06d05f1ac43985cb9a8bda6dad7cfa5ed3ef
Bug-Url: https://bugzilla.redhat.com/1261733
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java
M packaging/dbscripts/command_entities_sp.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
7 files changed, 55 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I984f06d05f1ac43985cb9a8bda6dad7cfa5ed3ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core: revert dc version if no update occured.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: revert dc version if no update occured.
......................................................................
core: revert dc version if no update occured.
When failing to upgrade the storage pool the engine can revert back the
updated db in case it's known that no upgrade occured, we can also avoid
refresh the pool metadata on the hosts as nothing was executed.
Change-Id: I76caab42815f5f7bb7627979ba5d25059fd88617
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261956
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 35 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76caab42815f5f7bb7627979ba5d25059fd88617
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core: spmStart failure when clusterlock inquire isn't supported
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: spmStart failure when clusterlock inquire isn't supported
......................................................................
core: spmStart failure when clusterlock inquire isn't supported
As part of the SPM selection flow in the engine we run getSpmStatus()
on the candidate host to get the current spm status (if possible) and
we act according to the result.
After an "offline" (when the dc is down) DC upgrade from DC that uses
V1 for it's domain (3.0 for example) to a version that uses the
StoragePoolMemoryBackend we might fail when attempting to get the current
spm status, that's because StoragePoolMemoryBackend relies on the fact
that the used clusterlock supports inquiring while it might not.
This patch ignores the failure of getSpmStatus() if the failure is
InquireNotSupportedError and attempts to start the spm, if the cluster
lock is acquired we'll fail on the spmStart flow.
Change-Id: I996fc4454c210dd278dafa9d94a13c4981162f5b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242092
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
2 files changed, 119 insertions(+), 73 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I996fc4454c210dd278dafa9d94a13c4981162f5b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months