October 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.0]: core: remove addVmTemplateCinderDisks from transaction

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: remove addVmTemplateCinderDisks from transaction ...................................................................... core: remove addVmTemplateCinderDisks from transaction AddVmTemplateCommand: Extracted 'addVmTemplateCinderDisks' invocation from within transaction. Change-Id: I847d80d4798aafd59b92e060039b25efd71840b9 Bug-Url: https://bugzilla.redhat.com/1264677 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 5 files changed, 17 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I847d80d4798aafd59b92e060039b25efd71840b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: webadmin: Allow edit of wipe after delete when the VM is not...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow edit of wipe after delete when the VM is not down ...................................................................... webadmin: Allow edit of wipe after delete when the VM is not down In fact, wipe after delete is possible in any case unless when the VM is a part of a pool Change-Id: Ic7030fd98045d624cba048ca6f0eeb1c85a58f62 Bug-Url: https://bugzilla.redhat.com/1258901 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7030fd98045d624cba048ca6f0eeb1c85a58f62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: revert dc version if no update occured.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: revert dc version if no update occured. ...................................................................... core: revert dc version if no update occured. When failing to upgrade the storage pool the engine can revert back the updated db in case it's known that no upgrade occured, we can also avoid refresh the pool metadata on the hosts as nothing was executed. Change-Id: I76caab42815f5f7bb7627979ba5d25059fd88617 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261956 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 35 insertions(+), 20 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76caab42815f5f7bb7627979ba5d25059fd88617 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: spmStart failure when clusterlock inquire isn't supported

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: spmStart failure when clusterlock inquire isn't supported ...................................................................... core: spmStart failure when clusterlock inquire isn't supported As part of the SPM selection flow in the engine we run getSpmStatus() on the candidate host to get the current spm status (if possible) and we act according to the result. After an "offline" (when the dc is down) DC upgrade from DC that uses V1 for it's domain (3.0 for example) to a version that uses the StoragePoolMemoryBackend we might fail when attempting to get the current spm status, that's because StoragePoolMemoryBackend relies on the fact that the used clusterlock supports inquiring while it might not. This patch ignores the failure of getSpmStatus() if the failure is InquireNotSupportedError and attempts to start the spm, if the cluster lock is acquired we'll fail on the spmStart flow. Change-Id: I996fc4454c210dd278dafa9d94a13c4981162f5b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242092 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 2 files changed, 119 insertions(+), 73 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I996fc4454c210dd278dafa9d94a13c4981162f5b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: JsonRpcVdsServer: spmStart() to pass the needed domain version

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: JsonRpcVdsServer: spmStart() to pass the needed domain version ...................................................................... JsonRpcVdsServer: spmStart() to pass the needed domain version Currently JsonRpcVdsServer.spmStart() isn't passing the domVersion parameter to vdsm, that parameter is used by vdsm for verification and for running an upgrade on all the relevant domains to match the version. Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242092 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47120 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Catch SC_NOT_FOUND status on cinder disk remove

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Catch SC_NOT_FOUND status on cinder disk remove ...................................................................... core: Catch SC_NOT_FOUND status on cinder disk remove Add catch for OpenStackResponseException on getDiskStatus once we got SC_NOT_FOUND status. The disk, which was being removed, might already get removed when we check the status so there is no reason to mark it as illegal. also, fix the error log by replacing brackets to valid ones. Change-Id: Id576359151e7e617d926e4d2dd83f32baa91625a Bug-Url: https://bugzilla.redhat.com/1269439 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id576359151e7e617d926e4d2dd83f32baa91625a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: core: spice proxy not present in .vv file

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: spice proxy not present in .vv file ...................................................................... core: spice proxy not present in .vv file Just incorrect negation Change-Id: Ica120223b50bc8befd4387a0ba491c50e9e5f4b7 Bug-Url: https://bugzilla.redhat.com/1266497 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica120223b50bc8befd4387a0ba491c50e9e5f4b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Catch SC_NOT_FOUND status on cinder disk remove

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Catch SC_NOT_FOUND status on cinder disk remove ...................................................................... core: Catch SC_NOT_FOUND status on cinder disk remove Add catch for OpenStackResponseException on getDiskStatus once we got SC_NOT_FOUND status. The disk, which was being removed, might already get removed when we check the status so there is no reason to mark it as illegal. also, fix the error log by replacing brackets to valid ones. Change-Id: Id576359151e7e617d926e4d2dd83f32baa91625a Bug-Url: https://bugzilla.redhat.com/1269439 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id576359151e7e617d926e4d2dd83f32baa91625a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: setup: adding an hint about serial console configuration

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: adding an hint about serial console configuration ...................................................................... setup: adding an hint about serial console configuration If the user wants to manually install the Guest OS and no graphical connection is available, he could stll use the serial console but it has also to be enabled on guest side. Change-Id: Iec235fb4755ee88bd190c5b6a2a666e661d99b79 Bug-Url: https://bugzilla.redhat.com/1215436 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec235fb4755ee88bd190c5b6a2a666e661d99b79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Disable warnings about private modules

by mperina＠redhat.com

Martin Peřina has submitted this change and it was merged. Change subject: core: Disable warnings about private modules ...................................................................... core: Disable warnings about private modules The application server marks its modules as "private" using the "jaxb.api" property: <property name="jboss.api" value="private"/> When one of these "private" modules is used by an application the server issues the following warning during deployment of the application: JBAS018567: Deployment "deployment.myapp.ear" is using a private module ("org.apache.commons.lang:main") which may be changed or removed in future versions without notice. We are well aware of this, and we don't consider it problematic. This patch modifies the configuration of the logging subsystem so that warnings issued for that category will be ignred. Change-Id: I28ba11f34f1864500cf9e6f69b6765c3049cdf3e Bug-Url: https://bugzilla.redhat.com/1269413 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ba11f34f1864500cf9e6f69b6765c3049cdf3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2015