Change in ovirt-engine[master]: JsonRpcVdsServer: spmStart() to pass the needed domain version
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: JsonRpcVdsServer: spmStart() to pass the needed domain version
......................................................................
JsonRpcVdsServer: spmStart() to pass the needed domain version
Currently JsonRpcVdsServer.spmStart() isn't passing the domVersion
parameter to vdsm, that parameter is used by vdsm for verification and
for running an upgrade on all the relevant domains to match the version.
Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242092
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46ede487a501d3ccda872e65bf68438a4edba58f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: userportal, webadmin: fixed login form column widths
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fixed login form column widths
......................................................................
userportal, webadmin: fixed login form column widths
Gave more width to labels and less to fields, to prevent text wrapping.
Change-Id: I929f05509547e37fce5c99c4274f8577b390ec45
Bug-Url: https://bugzilla.redhat.com/1253302
Bug-Url: https://bugzilla.redhat.com/1254954
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Greg Sheremeta: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47054
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I929f05509547e37fce5c99c4274f8577b390ec45
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: webadmin: untranslated errata-related error messages
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: untranslated errata-related error messages
......................................................................
webadmin: untranslated errata-related error messages
Some errata-related error messages were missing from the web-admin's
AppError.properties file. As a result, those error messages were
retrieved from the English defaults as they appear in AppErrors.java for
all locales.
This patch adds the missing (English) error messages to the web-admin's
AppError.properties file (as instructed in [1]).
Once these messages will be translated, the messages will appear in the
relevant locale in the GUI (will be performed separately in a different
patch).
[1] http://www.ovirt.org/Engine_Adding_Messages
Change-Id: Ibc642033b996c081982b2155e1bef150b1afaa5a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269090
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Einav Cohen: Verified
--
To view, visit https://gerrit.ovirt.org/47081
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc642033b996c081982b2155e1bef150b1afaa5a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: webadmin: Fix scrolling in attach disk panel
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix scrolling in attach disk panel
......................................................................
webadmin: Fix scrolling in attach disk panel
Change-Id: Iea9505bbe95b3f160fed4c554aa677717d4762ee
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1269206
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml
2 files changed, 8 insertions(+), 13 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47048
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea9505bbe95b3f160fed4c554aa677717d4762ee
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core: spice proxy not present in .vv file
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: spice proxy not present in .vv file
......................................................................
core: spice proxy not present in .vv file
Just incorrect negation
Change-Id: Ica120223b50bc8befd4387a0ba491c50e9e5f4b7
Bug-Url: https://bugzilla.redhat.com/1266497
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica120223b50bc8befd4387a0ba491c50e9e5f4b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: webadmin: Prevent auto-refresh engine's errata
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Prevent auto-refresh engine's errata
......................................................................
webadmin: Prevent auto-refresh engine's errata
Auto-refresh of engine's errata causes the webadmin
(and the engine) to behave slowly. The errata should
be fetched for the engine only if the 'Errata' node
is clicked on the system tree.
Change-Id: I74d9ee14bc21c2b561ed651f7e5649b8c8ce9311
Bug-Url: https://bugzilla.redhat.com/1260499
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEngineErrataPresenter.java
2 files changed, 0 insertions(+), 20 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d9ee14bc21c2b561ed651f7e5649b8c8ce9311
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Disable sound card for ppc64
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disable sound card for ppc64
......................................................................
core: Disable sound card for ppc64
Added canDoAction checks to Add/Import/UpdateVM commands using new flag in
os-info.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253261
Change-Id: I848686fb88e9a2128c9308546f1e26711b48654d
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/conf/osinfo-defaults.properties
20 files changed, 171 insertions(+), 26 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I848686fb88e9a2128c9308546f1e26711b48654d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: engine, webadmin: Clear all option in RHEV admin portal does...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine, webadmin: Clear all option in RHEV admin portal does not clear any alerts
......................................................................
engine, webadmin: Clear all option in RHEV admin portal does not clear any alerts
The events footer table show both events and alerts.
The events footer table should display only events and
the clear and display operations on this table should
only work with events.
Change-Id: If98e235beb4283da359782c79fc5e1598a9f0579
Bug-Url: https://bugzilla.redhat.com/1206264
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDaoImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/EventModelProvider.java
M packaging/dbscripts/audit_log_sp.sql
5 files changed, 31 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If98e235beb4283da359782c79fc5e1598a9f0579
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: engine : CoCo infrastructure should provide a timeout for ea...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : CoCo infrastructure should provide a timeout for each command
......................................................................
engine : CoCo infrastructure should provide a timeout for each command
A new vdc_option in the database CoCoCommandLifeInMinutes
determines the lifetime of a command. A command that is
still in Active status after the lifetime is marked as Failed.
The onFailed method is invoked on the command's callback which
is responsible for releasing any locks on the entities.
Commands can fine tune the life time of a command by
invoking VdcActionParametersBase.setLifeInMinutes
Change-Id: I984f06d05f1ac43985cb9a8bda6dad7cfa5ed3ef
Bug-Url: https://bugzilla.redhat.com/1261733
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java
M packaging/dbscripts/command_entities_sp.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
7 files changed, 55 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I984f06d05f1ac43985cb9a8bda6dad7cfa5ed3ef
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: userportal, webadmin: fixed login form validation
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fixed login form validation
......................................................................
userportal, webadmin: fixed login form validation
Login form was submitting blank fields, but not returning a
"fields cannot be blank" message to the user. Fixed.
Change-Id: I5bf7a3ea682a8e769d84aa590820c441d4fa178f
Bug-Url: https://bugzilla.redhat.com/1251003
Bug-Url: https://bugzilla.redhat.com/1254940
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/47053
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bf7a3ea682a8e769d84aa590820c441d4fa178f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months