Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDiskCommand - do not pass same parameters in...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveOrCopyDiskCommand - do not pass same parameters instance
......................................................................
core: MoveOrCopyDiskCommand - do not pass same parameters instance
The parameters instance of each command contains information that is
unique to the command (for example - the command id). In
MoveOrCopyDiskCommand the parameters of the command are passed to to
child command which is problematic - the infra doesn't support that and
it causes the endAction() of the wrong command to be executed, for
entities to stay locked and so on.
This patch solves that by adding a copy constructor to the parameters
class hirerchy excluding the base parameters class that contains command
specific information. That is the taken approach to minimize the risk of
influecing one of the command usages as we'll backport this change.
Later on we can remove the copy constructor and just create the child
parameters manually without relying on the fact that they are of the
same type of the parent command.
Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282693
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java
6 files changed, 80 insertions(+), 29 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/49089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-reports[master]: build: after build reports for 3.6.1
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: after build reports for 3.6.1
......................................................................
build: after build reports for 3.6.1
Change-Id: Iff329d54fc3e7878c05e042d27a5251e68791483
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff329d54fc3e7878c05e042d27a5251e68791483
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-dwh[master]: build: post ovirt-engine-dwh-3.6.1
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: post ovirt-engine-dwh-3.6.1
......................................................................
build: post ovirt-engine-dwh-3.6.1
Change-Id: I5d6062d360ad2b832197aecd041afb3c738a745c
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d6062d360ad2b832197aecd041afb3c738a745c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-dwh[master]: build: ovirt-engine-dwh-3.6.1
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: ovirt-engine-dwh-3.6.1
......................................................................
build: ovirt-engine-dwh-3.6.1
Change-Id: I412458958b8d234990e9be2b70e28f1f0070659f
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
M version.mak
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49100
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I412458958b8d234990e9be2b70e28f1f0070659f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in jenkins[master]: Enabled concurrent builds in standard-ci
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Enabled concurrent builds in standard-ci
......................................................................
Enabled concurrent builds in standard-ci
Enabled concurrent builds in standard-ci, limiting each job to
max 3 concurrent builds.
Change-Id: Ic5049c8819a99d09b6bb61b166b0b8d17b8200be
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/yaml/templates/standard-stage.yaml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sharon Naftaly: Verified
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/48760
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5049c8819a99d09b6bb61b166b0b8d17b8200be
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in jenkins[master]: add all infra team git repos to nudge & abandon
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: add all infra team git repos to nudge & abandon
......................................................................
add all infra team git repos to nudge & abandon
Change-Id: I5d6b6e0ee14abd4e940ee077bbf3ed2f8e109e54
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Eyal Edri: Verified; Passed CI tests; Ready for merge
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Looks good to me
--
To view, visit https://gerrit.ovirt.org/49015
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d6b6e0ee14abd4e940ee077bbf3ed2f8e109e54
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-reports[master]: build: build reports for 3.6.1
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: build reports for 3.6.1
......................................................................
build: build reports for 3.6.1
Change-Id: I431ecdf5778fe0fca3918ab0c3c9d0a3796e1f3a
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I431ecdf5778fe0fca3918ab0c3c9d0a3796e1f3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: edit pool dialog was not always filled properly
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: edit pool dialog was not always filled properly
......................................................................
webadmin: edit pool dialog was not always filled properly
The HW part should be filled by InstanceTypeManager and the SW part by behavior
classes. In the current implementation the instance type manager was bypassed
in some cases and only used as a signal when to pass the control back to it.
Fixed by moving the HW related logic to Instance TypeManager where it belongs
to and let the SW part in the behavior.
Change-Id: I0866a3d23ba946c5a9f497b03a9b4537aea750ee
Bug-Url: https://bugzilla.redhat.com/1282853
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingPoolInstanceTypeManager.java
2 files changed, 33 insertions(+), 26 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49071
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0866a3d23ba946c5a9f497b03a9b4537aea750ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: backend: Reduce usages of Backend#getResourceManager()
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: backend: Reduce usages of Backend#getResourceManager()
......................................................................
backend: Reduce usages of Backend#getResourceManager()
Replaced accesses to VdsBrokerFrontend via Backend lookup with injection where
possible.
Also introduced runVdsCommand helper in QueriesCommandBase so Queries wouldn't
need to manually inject the VdsBrokerFrontend - similary as it is done in
CommandBase.
Change-Id: Ibaedc7f03c530db054883393db35e735f43043a9
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromOvaQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StopVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DiscoverSendTargetsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetAllFromExportDomainQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
45 files changed, 109 insertions(+), 170 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48329
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaedc7f03c530db054883393db35e735f43043a9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: webadmin: Unpin numa nodes when preferred host changes
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Unpin numa nodes when preferred host changes
......................................................................
webadmin: Unpin numa nodes when preferred host changes
* Pin VM numa nodes to new preferred host when possible.
* Unpin all VM numa nodes when new preferred host does not have the
corrseponding host numa node.
* Only show VM numa nodes of VMs which are pinned to the selected host
in the numa node configuration panel.
Bug-Url: https://bugzilla.redhat.com/1177259
Change-Id: Iabb16f1b3dbcb7f821046dddaa3b719314598d06
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
3 files changed, 39 insertions(+), 30 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Roman Mohr: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48721
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabb16f1b3dbcb7f821046dddaa3b719314598d06
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month