November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.1]: core: when switching macPool assigned to DC, MACs has to be ...
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: when switching macPool assigned to DC, MACs has to be moved between pools. ...................................................................... core: when switching macPool assigned to DC, MACs has to be moved between pools. When new mac pool is different from old mac pool, all mac addresses of NICs belonging to this DC has to be released from old mac pool and added to new one. Change-Id: I1a14c49c3af8e7a4268b40f52bba9767c05120cf Bug-Url: https://bugzilla.redhat.com/1269846 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDc.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 2 files changed, 64 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a14c49c3af8e7a4268b40f52bba9767c05120cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extract interfaces by the right key
by rgolan＠redhat.com 30 Nov '15

30 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Extract interfaces by the right key ...................................................................... core: Extract interfaces by the right key Fixing importing the network interfaces from vdsm. It used the wrong dictionatry key ("iface instaed of "interface") Change-Id: I2db437395a2cc303a03a16eb4194df09cac13e20 Bug-Url: https://bugzilla.redhat.com/1273378 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2db437395a2cc303a03a16eb4194df09cac13e20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ProviderId is not set for existing foreman host
by oourfali＠redhat.com 30 Nov '15

30 Nov '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: ProviderId is not set for existing foreman host ...................................................................... webadmin: ProviderId is not set for existing foreman host When adding an existing foreman host (provisioned host), the provider ID isn't passed to the engine, leading to not being able to identify that it is a foreman host. Change-Id: I15cf2b0e2968b5f130405c902e5d785233b4ef93 Bug-Url: https://bugzilla.redhat.com/1278378 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15cf2b0e2968b5f130405c902e5d785233b4ef93 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: pki: set TEMPORARY_CERT_FILE to None if we deploy in insecur...
by sbonazzo＠redhat.com 30 Nov '15

30 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: set TEMPORARY_CERT_FILE to None if we deploy in insecure mode ...................................................................... pki: set TEMPORARY_CERT_FILE to None if we deploy in insecure mode Deploy additional host in insecure mode failed, because we use empty temorary certificate, when tring to get SSH key. Change-Id: I18886578e57cf2e3061623d50ca6692ead021ef3 Bug-Url: https://bugzilla.redhat.com/1286429 Signed-off-by: Lukianov Artyom <alukiano(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Artyom Lukianov: Verified -- To view, visit https://gerrit.ovirt.org/49360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18886578e57cf2e3061623d50ca6692ead021ef3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: pki: Do not fail if pkcs12 unreadable
by tnisan＠redhat.com 30 Nov '15

30 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: pki: Do not fail if pkcs12 unreadable ...................................................................... packaging: setup: pki: Do not fail if pkcs12 unreadable During upgrade, we check several pkcs12 files to see if they expired or are close to expire. Do not fail upgrade if we failed to read them. This can happen e.g. if some of them were replaced with ones signed by a 3rd party CA, changed their passphrase, etc. Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4 Bug-Url: https://bugzilla.redhat.com/1260752 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 1490f28e5f6ff68bb4bfeabc77581eb1043735e6) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 30 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/49408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: fix: added whitespaces in core.py to pass pep8
by sbonazzo＠redhat.com 30 Nov '15

30 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix: added whitespaces in core.py to pass pep8 ...................................................................... fix: added whitespaces in core.py to pass pep8 Fixed ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/core.py by adding whitespaces around calculations. Change-Id: I66915b3c8a331d0953bb91b6d7e005abfd38910b Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/core.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66915b3c8a331d0953bb91b6d7e005abfd38910b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Simplify GlusterGeoRepUtil conditionals
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Simplify GlusterGeoRepUtil conditionals ...................................................................... core: Simplify GlusterGeoRepUtil conditionals Simplify if conditions and replace them with composite boolean expressions where possible in order to reduce code bloating. Change-Id: I5bc48481f9f0a6e79ac2af06f35f0ccafbe62a05 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java 1 file changed, 3 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bc48481f9f0a6e79ac2af06f35f0ccafbe62a05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterGeoRepUtil lambdas
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterGeoRepUtil lambdas ...................................................................... core: GlusterGeoRepUtil lambdas Modernized the syntax and reduced code bloating by replacing explicit implementations of java.util.function.Predicate with neater inline lambda expressions. Change-Id: I4fa9aeaa99965b71344bc5e783030f63d3146154 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java 1 file changed, 25 insertions(+), 62 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fa9aeaa99965b71344bc5e783030f63d3146154 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterGeoRepUtil predicates
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterGeoRepUtil predicates ...................................................................... core: GlusterGeoRepUtil predicates Replaced the usage of org.ovirt.engine.core.utils.linq.Predicate with the modern java.util.function.Predicate. This patch is a minimalistic in-place replacement of two similar interfaces. Following patches will update, clean up and modernize the code where possible. Change-Id: I83101d123e74b21afa6cf7f76b1d1e05294fc423 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java 3 files changed, 16 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved anmolbabu: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83101d123e74b21afa6cf7f76b1d1e05294fc423 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rm getNonEligibilityReasonsForSlaveVolume1()
by amureini＠redhat.com 30 Nov '15

30 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm getNonEligibilityReasonsForSlaveVolume1() ...................................................................... core: rm getNonEligibilityReasonsForSlaveVolume1() This method just returns an empty ArrayList, and was only used to assert against. Removing it and asserting that various lists are empty makes the code much cleaner and easier to understand. Change-Id: If077e5074c9630f6a8ace24b092902b309ddcc87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If077e5074c9630f6a8ace24b092902b309ddcc87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0