Change in ovirt-engine[ovirt-engine-3.6]: webadmin: set VirtIO type if profile is not passthrough enab...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: set VirtIO type if profile is not passthrough enabled.
......................................................................
webadmin: set VirtIO type if profile is not passthrough enabled.
Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd
Bug-Url: https://bugzilla.redhat.com/1285696
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
3 files changed, 16 insertions(+), 8 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49392
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: core: update network status only if there's at least one hos...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: update network status only if there's at least one host with up status
......................................................................
core: update network status only if there's at least one host with up status
Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc
Bug-Url: https://bugzilla.redhat.com/1250063
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java
1 file changed, 90 insertions(+), 40 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id45135af63e7cf11ffbc22292139fdcc12b3f7dc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: restapi: change "vf" to "virtualfunction"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: change "vf" to "virtualfunction"
......................................................................
restapi: change "vf" to "virtualfunction"
Change "vf" to "virtualfunction"
Change-Id: I85ce1e4d07c8dc4808b15eb37a9174eb3c9cb02e
Bug-Url: https://bugzilla.redhat.com/1286427
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/49382
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85ce1e4d07c8dc4808b15eb37a9174eb3c9cb02e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-hosted-engine-setup[master]: setup: raise after VDSM re-start timeout
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: raise after VDSM re-start timeout
......................................................................
setup: raise after VDSM re-start timeout
If VDSM failed to start within a fixed timeout raise to abort
setup execution.
Increasing the timeout value from 10 to 120 seconds.
Change-Id: I636315a3e5f7a04fb004bf6be56687c362863174
Bug-Url: https://bugzilla.redhat.com/1285738
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I636315a3e5f7a04fb004bf6be56687c362863174
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: engine, webadmin: do not invoke HostSetupNetworksCommand wher...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made
......................................................................
engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made
• discard from HostSetupNetworksCommandParameters all bonds and
network attachments, which are sent to be updated, but they're
equal to already existing Bonds resp. NetworkAttachment in the system.
• added method to HostSetupNetworksCommandParameters to figure out if
there's any change to be done in them, and this method is used both on UI and
bll to figure out, whether changes needs to be done to the system.
Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c
Bug-Url: https://bugzilla.redhat.com/1254320
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
4 files changed, 145 insertions(+), 35 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: Fix failure notifications
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: engine-backup: Fix failure notifications
......................................................................
packaging: engine-backup: Fix failure notifications
Always check and set FAILURE_NOTIFIED before trying to notify.
Without this patch, in certain conditions, we could enter an endless
loop while trying to notify the engine about a failure.
Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5
Bug-Url: https://bugzilla.redhat.com/1240923
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit a1a99f2829ec02ca5a33efad1468592288439265)
---
M packaging/bin/engine-backup.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/49365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: Do not log cmdline parsing errors
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: engine-backup: Do not log cmdline parsing errors
......................................................................
packaging: engine-backup: Do not log cmdline parsing errors
That's especially important for the error about missing log file.
Others are also not important to log - we want to log actual failures
caught during backup.
Bug-Url: https://bugzilla.redhat.com/1240923
Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 208f2cbebf3193cbe64d08423d6aa8c9c68edcdd)
---
M packaging/bin/engine-backup.sh
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/49364
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core, frontend: allow spice+vnc only on 3.6+ cluster
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core,frontend: allow spice+vnc only on 3.6+ cluster
......................................................................
core,frontend: allow spice+vnc only on 3.6+ cluster
Changes:
- do not add the SPICE+VNC option to the dialogs if not allowed
- check on add/edit if more than one graphics are allowed
- check on add new graphics device if it can be added
Change-Id: I4a52ae9f5525578e641e1d039fda048b1f447595
Bug-Url: https://bugzilla.redhat.com/1279524
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
14 files changed, 52 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48855
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a52ae9f5525578e641e1d039fda048b1f447595
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: packaging: setup: pki: Do not fail if pkcs12 unreadable
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: pki: Do not fail if pkcs12 unreadable
......................................................................
packaging: setup: pki: Do not fail if pkcs12 unreadable
During upgrade, we check several pkcs12 files to see if they expired or
are close to expire. Do not fail upgrade if we failed to read them. This
can happen e.g. if some of them were replaced with ones signed by a 3rd
party CA, changed their passphrase, etc.
Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4
Bug-Url: https://bugzilla.redhat.com/1260752
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 30 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/49172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: webadmin: set VirtIO type if profile is not passthrough enab...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: set VirtIO type if profile is not passthrough enabled.
......................................................................
webadmin: set VirtIO type if profile is not passthrough enabled.
Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd
Bug-Url: https://bugzilla.redhat.com/1285696
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
3 files changed, 16 insertions(+), 8 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12a0212c0630e3c44f90fba091e6939877c94afd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month