Change in ovirt-release[master]: ovirt-release-master: add missing builddep on el7
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-release-master: add missing builddep on el7
......................................................................
ovirt-release-master: add missing builddep on el7
- Resolves: BZ#1278398
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1278398
Change-Id: Id2b9e69231e9e780d4317c6933a5a58635fbbba4
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-release-master/configure.ac
M ovirt-release-master/ovirt-el7-deps.repo.in
M ovirt-release-master/ovirt-release-master.spec.in
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2b9e69231e9e780d4317c6933a5a58635fbbba4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: userportal: Attach disk to VM window does not open
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: Attach disk to VM window does not open
......................................................................
userportal: Attach disk to VM window does not open
Since add a disk and attach disk windows has been separated both in
webadmin and in userportal in commit
e0e2161014bf6971fab9ce33f783b57b343fa7cb
the attach window did not open in userportal since it was not added to the
provider, this is fixed in this patch
Change-Id: Ib8dd843017d0eaa8631abb36597199cee236b3c7
Bug-Url: https://bugzilla.redhat.com/1279208
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmDiskListModelProvider.java
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8dd843017d0eaa8631abb36597199cee236b3c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in jenkins[master]: added fedora 23 jobs
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: added fedora 23 jobs
......................................................................
added fedora 23 jobs
- moved jobs meant to be built on latest fedora to fc23
- added fc23 to all the remaining jobs meant to support fedora
Change-Id: I06b47c2fad6b635b79b1a53d65a06a7d4cc21b15
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/fabic-ovirt/fabric-ovirt_standard.yaml
M jobs/confs/projects/infra-docs/infra-docs.yaml
M jobs/confs/projects/ioprocess/ioprocess_create-rpms.yaml
M jobs/confs/projects/jasper-reports/jasper-reports_create-rpms.yaml
M jobs/confs/projects/mom/mom_create-rpms.yaml
M jobs/confs/projects/nsis-simple-service-plugin/nsis-simple-service-plugin.yaml
M jobs/confs/projects/otopi/otopi_create-rpms.yaml
M jobs/confs/projects/ovirt-dwh/ovirt-dwh_create-rpms.yaml
M jobs/confs/projects/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml
M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml
M jobs/confs/projects/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml
M jobs/confs/projects/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml
M jobs/confs/projects/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml
M jobs/confs/projects/ovirt-engine-wildfly/ovirt-engine-wildfly.yaml
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
M jobs/confs/projects/ovirt-guest-agent/ovirt-guest-agent_standard.yaml
M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml
M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml
M jobs/confs/projects/ovirt-hosted-engine-setup/ovirt-hosted-engine_stardard.yaml
M jobs/confs/projects/ovirt-image-uploader/ovirt-image-uploader_standard.yaml
M jobs/confs/projects/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml
M jobs/confs/projects/ovirt-jboss-modules-maven-plugin/ovirt-jboss-modules-maven-plugin_build-artifacts.yaml
M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml
M jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml
M jobs/confs/projects/ovirt-reports/ovirt-reports_create-rpms.yaml
M jobs/confs/projects/ovirt-scheduler-proxy/ovirt-scheduler-proxy_standard.yaml
M jobs/confs/projects/ovirt-setup-lib/ovirt-setup-lib_build-artifacts.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
M jobs/confs/projects/pthreading/pthreading.yaml
M jobs/confs/projects/py2exe-py2.7/py2exe-py2.7.yaml
M jobs/confs/projects/python-windows/python-windows.yaml
M jobs/confs/projects/pywin32-py2.7/pywin32-py2.7.yaml
M jobs/confs/projects/repoman/repoman_build-artifacts.yaml
M jobs/confs/projects/spice-qxl/spice-qxl.yaml
M jobs/confs/projects/vcredist-x86/vcredist-x86.yaml
M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml
M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml
M jobs/confs/projects/vdsm/vdsm_create_libgfapi-rpms.yaml
M jobs/confs/projects/vdsm/vdsm_install-rpm-sanity.yaml
M jobs/confs/projects/vdsm/vdsm_standard.yaml
M jobs/confs/projects/virtio-win-drivers/virtio-win-drivers.yaml
M jobs/confs/yaml/builders/copy-create-job-artifact.yaml
44 files changed, 113 insertions(+), 40 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b47c2fad6b635b79b1a53d65a06a7d4cc21b15
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-image-uploader[master]: ovirt-image-uploader: return non-zero returncodes
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-image-uploader: return non-zero returncodes
......................................................................
ovirt-image-uploader: return non-zero returncodes
Previously we returned returncode of 0 even if something went
wrong during the file upload phase.
This patch fixes this issue and makes the program return
ExitCodes.UPLOAD_ERR code (3) in this case.
Change-Id: I0717ecb13b9cae8331a21f35e1f090698aaac4f3
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1104661
---
M src/__main__.py
1 file changed, 25 insertions(+), 13 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47501
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0717ecb13b9cae8331a21f35e1f090698aaac4f3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Cleanup duplicate references to OsRepository
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Cleanup duplicate references to OsRepository
......................................................................
core: Cleanup duplicate references to OsRepository
Small refactoring of cases when the osRepository was already in scope and was
being accessed in an unnecessarily complicated way.
Change-Id: I1aec5fcf8f5f1c91a5cdb9990404f169c173a259
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
4 files changed, 1 insertion(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1aec5fcf8f5f1c91a5cdb9990404f169c173a259
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Audit log on remove disk should be on failure.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Audit log on remove disk should be on failure.
......................................................................
core: Audit log on remove disk should be on failure.
On remove disk failure, an audit log should still be performed
regardless to the flag shouldBeLogged.
Also, when removing a VM with Cinder disks set the log flag to false, since
the remove of the VM should already log this action.
Change-Id: I831f7bb78ce53586ce4eca1edd61540345536218
Bug-Url: https://bugzilla.redhat.com/1278126
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/48236
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I831f7bb78ce53586ce4eca1edd61540345536218
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Support recursive remove of cinder volumes.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Support recursive remove of cinder volumes.
......................................................................
core: Support recursive remove of cinder volumes.
Implementing a recursive way to remove Cinder volumes.
As part of this implementation the behviour should be as follow:
When trying to remove a Cinder disk we aggragate all the volumes of the
Cinder disk, snapshots and Cinder volumes (commited snapshots).
Then we execute them one at a time, if there is a failure in the middle
we change the disk status to illegal and fail the command.
Once an illegal Cinder disk is being removed we only remove the Cinder
disk and its volumes from the DB, without removing it from the Cinder
provider.
Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3
Bug-Url: https://bugzilla.redhat.com/1278126
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java
5 files changed, 293 insertions(+), 200 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/48235
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Support remove for Cinder volume.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Support remove for Cinder volume.
......................................................................
core: Support remove for Cinder volume.
Adding a new command to support only remove of Cinder volume.
Change-Id: I2a2441480a485436ea85f25679e769333d24c3d7
Bug-Url: https://bugzilla.redhat.com/1278126
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskVolumeCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskVolumeCommandCallback.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskVolumeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 178 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/48234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a2441480a485436ea85f25679e769333d24c3d7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: fix for required checkbox in manage network popup
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: fix for required checkbox in manage network popup
......................................................................
webadmin: fix for required checkbox in manage
network popup
the fix will prevent mark network as required if
the network is not attached to the cluster.
Change-Id: Ib8bb00a953d3085bff032f123cff0b08a34afbe4
Bug-Url: https://bugzilla.redhat.com/1200787
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8bb00a953d3085bff032f123cff0b08a34afbe4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Support recursive remove of cinder volumes.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support recursive remove of cinder volumes.
......................................................................
core: Support recursive remove of cinder volumes.
Implementing a recursive way to remove Cinder volumes.
As part of this implementation the behviour should be as follow:
When trying to remove a Cinder disk we aggragate all the volumes of the
Cinder disk, snapshots and Cinder volumes (commited snapshots).
Then we execute them one at a time, if there is a failure in the middle
we change the disk status to illegal and fail the command.
Once an illegal Cinder disk is being removed we only remove the Cinder
disk and its volumes from the DB, without removing it from the Cinder
provider.
Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3
Bug-Url: https://bugzilla.redhat.com/1278126
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java
5 files changed, 293 insertions(+), 200 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/46042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5c19c0fa06f2fb40423072e609b3c0ca7f28f3
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months