Change in ovirt-engine[ovirt-engine-3.6]: engine: Bonding modes 0, 5 and 6 should be avoided for VM ne...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Bonding modes 0, 5 and 6 should be avoided for VM networks
......................................................................
engine: Bonding modes 0, 5 and 6 should be avoided for VM networks
Bonds with bonding modes 0, 5 and 6 should be prohibited from
having vm networks.
This patch modifies the HostSetupNetworkValidator not to allow to
attach a vm network to a bond with such bonding options, and also
prohibits to change the bonding options to such if a vm network
is attached.
Change-Id: Ie83b633b36de7985df42bc019e602d5f2fbd25dc
Bug-Url: https://bugzilla.redhat.com/1094842
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 240 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48146
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie83b633b36de7985df42bc019e602d5f2fbd25dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: BondMode refactoring
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: BondMode refactoring
......................................................................
engine: BondMode refactoring
Refactoring for BondMode
Change-Id: I094d6a7388c06921d045be4f54735c2d52b1138a
Bug-Url: https://bugzilla.redhat.com/1094842
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/BondModeTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksJoinBondsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
5 files changed, 115 insertions(+), 31 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I094d6a7388c06921d045be4f54735c2d52b1138a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in jenkins[master]: vdsm: add vdsm_build job
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: add vdsm_build job
......................................................................
vdsm: add vdsm_build job
New project vdsm_build-artifacts builds vdsm packages on
F22 and EL7 (fc21 is eol in less than a month, fc23 is missing the
gluster repos for now).
Related to patches:
https://gerrit.ovirt.org/#/c/46135/ master
https://gerrit.ovirt.org/#/c/46929/ ovirt-3.6
https://gerrit.ovirt.org/#/c/46886/ ovirt-3.5
Change-Id: I6ef11043fb931797be748e4eb839eba35348126c
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/projects/vdsm/vdsm_standard.yaml
1 file changed, 44 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/46147
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ef11043fb931797be748e4eb839eba35348126c
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Bonding modes 0, 5 and 6 should be avoided for VM ...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Bonding modes 0, 5 and 6 should be avoided for VM networks
......................................................................
webadmin: Bonding modes 0, 5 and 6 should be avoided for VM networks
Bonds with bonding modes 0, 5 and 6 should be prohibited from
having vm networks.
This patch modifies the setup networks dialog not to allow to
attach a vm network to a bond with such bonding options, and also
prohibits to change the bonding options to such if a vm network
is attached.
Change-Id: I9bc5f0da68ce8cc55bda1c7aaf8568e7bbd9bda0
Bug-Url: https://bugzilla.redhat.com/1094842
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksJoinBondsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
10 files changed, 87 insertions(+), 16 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48144
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bc5f0da68ce8cc55bda1c7aaf8568e7bbd9bda0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Result of GetVmByIdQuery contains vm numa node list
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Result of GetVmByIdQuery contains vm numa node list
......................................................................
engine: Result of GetVmByIdQuery contains vm numa node list
Fixes UpdateVmCommand when called through REST on a VM, that has
numa tune mode set to preferred.
Change-Id: Iaf40b3c42e841be8987033710b266a70c3c29752
Bug-Url: https://bugzilla.redhat.com/1211270
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
2 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/47653
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf40b3c42e841be8987033710b266a70c3c29752
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: Require slf4j-jdk14 on Fedora
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: Require slf4j-jdk14 on Fedora
......................................................................
packaging: Require slf4j-jdk14 on Fedora
On EL6/7 slf4j package contains all part of slf4j library, but on Fedora
slf4j package was split into several packagesi. Besides api part we
need also jdk14 part (for engine command line tools) which is contained
in slf4j-jdk14 package.
This issue is not visibible on 3.6, because of this dependency:
ovirt-engine
-> spring-ldap
-> springframework-ws
-> springframework-webmvc
-> tiles
-> slf4j-jdk14
Engine dependency on spring-ldap was removed on master with removal of
legacy kerbldap provider (engine-manage-domains).
Change-Id: I0448fd16e9ee6b131070ba8d2960c1357ee05744
Bug-Url: https://bugzilla.redhat.com/1264670
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48123
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0448fd16e9ee6b131070ba8d2960c1357ee05744
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Common changes for Bonding mode 0, 5, 6 patches
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Common changes for Bonding mode 0,5,6 patches
......................................................................
engine: Common changes for Bonding mode 0,5,6 patches
Extracting hardcoded strings and values for bond modes.
To be used in patches 46560 and 46251
Change-Id: Id5353a23ace44eef8ce6fd373b239a0d485d831d
Bug-Url: https://bugzilla.redhat.com/1094842
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
3 files changed, 79 insertions(+), 14 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48143
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5353a23ace44eef8ce6fd373b239a0d485d831d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in jenkins[master]: Build Python SDK in Fedora 23 and not in Fedora 21
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Build Python SDK in Fedora 23 and not in Fedora 21
......................................................................
Build Python SDK in Fedora 23 and not in Fedora 21
This patch changes the Python SDK build job so that it builds it in
Fedora 23 and not in Fedora 21.
Change-Id: I2ef15d73f5e54306ef791ef81bc8d673e050efdb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48116
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ef15d73f5e54306ef791ef81bc8d673e050efdb
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
8 years, 6 months
Change in jenkins[master]: Build the CLI in Fedora 23 and not in Fedora 21
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Build the CLI in Fedora 23 and not in Fedora 21
......................................................................
Build the CLI in Fedora 23 and not in Fedora 21
This patch changes the CLI build job so that it is built in Fedora 23
and not in Fedora 21.
Change-Id: I2ae8a3fe19e34efe372689715e25be58645a8e52
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48120
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ae8a3fe19e34efe372689715e25be58645a8e52
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
8 years, 6 months
Change in ovirt-engine[master]: engine: Support cluster level gluster tuned profiles
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Support cluster level gluster tuned profiles
......................................................................
engine: Support cluster level gluster tuned profiles
Allow the ability to populate tuned options based on
cluster level
Change-Id: I7cfa6d8296c0d8b31de2f3e4fc2867653e5c2ad6
Bug-Url: https://bugzilla.redhat.com/1249979
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterTunedProfilesQuery.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 17 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47814
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cfa6d8296c0d8b31de2f3e4fc2867653e5c2ad6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months