November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: packaging: Require WildFly 8 overlay package
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Require WildFly 8 overlay package ...................................................................... packaging: Require WildFly 8 overlay package Require ovirt-engine-wildfly-overlay which is compatible with WildFly 8. Change-Id: I3bedcc49497407018d52f8d76660154a79681750 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bedcc49497407018d52f8d76660154a79681750 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: default volume format selection in new template wi...
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: frontend: default volume format selection in new template window ...................................................................... frontend: default volume format selection in new template window When making a template from a vm via the ui, one can choose the volume format of each template disk (92665e0af829d25273d5d45669847569eae6f5cc). Before this feature, the format of each disk was the same as its base snapshot, but now it's set to QCOW2 by default. This patch restores the old behavior such that the format is chosen to be the same as the base snapshot's format by default. Change-Id: I364a8f23f75b583c1f5b24051d374f32fa53a39d Bug-Url: https://bugzilla.redhat.com/1257240 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M packaging/dbscripts/disk_images_sp.sql 9 files changed, 193 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I364a8f23f75b583c1f5b24051d374f32fa53a39d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: add a parameterized constructor to IdsQueryParameters
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: add a parameterized constructor to IdsQueryParameters ...................................................................... backend: add a parameterized constructor to IdsQueryParameters Change-Id: I47d09f6576ec995607c70268a67baa6655d3e450 Related-To: https://bugzilla.redhat.com/1257240 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdsQueryParameters.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47d09f6576ec995607c70268a67baa6655d3e450 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: fix naming and spacing in IdsQueryParameters
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: fix naming and spacing in IdsQueryParameters ...................................................................... backend: fix naming and spacing in IdsQueryParameters Change-Id: I7e99e4c5d3ef1db7ff80416acf5ed4b5035c7b93 Related-To: https://bugzilla.redhat.com/1257240 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdsQueryParameters.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e99e4c5d3ef1db7ff80416acf5ed4b5035c7b93 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Java 8's Predicates in StorageDomainFilters
by amureini＠redhat.com 05 Nov '15

05 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Java 8's Predicates in StorageDomainFilters ...................................................................... core: Java 8's Predicates in StorageDomainFilters The StorageDomainFilter abstract is currently using org.ovirt.engine.core.utils.linq.Predicate. This patch migrates it to use the modern java.util.function.Predicate, resulting in code that is shorter, easier to read and easier to maintain. Change-Id: I9d43e5576263e1bc70720f192e4166eda48dd4f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainSpaceRequirementsFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainStatusFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainTypeFilter.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainFilterTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainSpaceRequirementsFilterTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainStatusFilterTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdfilters/StorageDomainTypeFilterTest.java 9 files changed, 25 insertions(+), 48 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Roy Golan: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d43e5576263e1bc70720f192e4166eda48dd4f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Bond modes correction for SetupNetworksJoinBondsModel
by alkaplan＠redhat.com 05 Nov '15

05 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Bond modes correction for SetupNetworksJoinBondsModel ...................................................................... engine: Bond modes correction for SetupNetworksJoinBondsModel Correcting the condition for adding previous bond options when joining bonds Change-Id: I18d583778c1312846d9ffe73d9f8fc293d109eab Bug-Url: https://bugzilla.redhat.com/1094842 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksJoinBondsModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48148 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18d583778c1312846d9ffe73d9f8fc293d109eab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding lago fc23 builds
by dcaro＠redhat.com 05 Nov '15

05 Nov '15

David Caro has submitted this change and it was merged. Change subject: Adding lago fc23 builds ...................................................................... Adding lago fc23 builds Change-Id: I715736d63b72d69bd5fd4732d9b793b38852b904 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/lago/lago_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/48096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715736d63b72d69bd5fd4732d9b793b38852b904 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.6_rc2
by sbonazzo＠redhat.com 05 Nov '15

05 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.6_rc2 ...................................................................... build: ovirt-live-3.5.6_rc2 Change-Id: Ic7f797e797e328181d41cf3c3831daf3fb0e3e5a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f797e797e328181d41cf3c3831daf3fb0e3e5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix NPE when break bond and remove label from it in ...
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix NPE when break bond and remove label from it in one action ...................................................................... engine: Fix NPE when break bond and remove label from it in one action Bug-Url: https://bugzilla.redhat.com/1275717 Change-Id: I96f7918d5424d3f4684e82d5f9be8c64ed91ac68 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit cfa9d5feb21dbcca438f60ec967f332743ef8dc2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96f7918d5424d3f4684e82d5f9be8c64ed91ac68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: unable to add/remove slaves from bond using rest api
by juan.hernandez＠redhat.com 05 Nov '15

05 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: unable to add/remove slaves from bond using rest api ...................................................................... restapi: unable to add/remove slaves from bond using rest api A bug in the rest api did not allow to: -add new slaves to a bond using the slave id -specify exising slaves which are to remains in a bond using the slave name -remove existing slaves from a bond by either name or id Another problem was that specyfing an existing slave in a rest request caused the engine to try and add the slave again. Change-Id: I9c55817d94e85fc10a33971043487dcad2c2c5af Bug-Url: https://bugzilla.redhat.com/1262275 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c55817d94e85fc10a33971043487dcad2c2c5af Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0