December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: "id" as XML attribute
by juan.hernandez＠redhat.com 14 Dec '15

14 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: "id" as XML attribute ...................................................................... restapi: "id" as XML attribute Currently some of the entities of the model explicity define an "id" attribute instead of extending the "Identified" interface. For example, the "LogicalUnit" entity defines its own "id" attribute. As a result the generated XML complex type contains an inner "id" element: <xs:complexType name="LogicalUnit"> <xs:sequence> <xs:element name="id" type="xs:string" .../> ... </xs:sequence> </xs:complexType> But the "id" attribute should always be represented as an XML attribute, as that is what was done in previous versions of the API, and it is a common practice in other usages of XML. To solve this problem this patch changes the XML schema generator so that it will take into account that some model attributes need to be represented as XML attributes instead of inner elements. The "id" attribute is the only one that needs this special treatment at the moment, but the pach implements a more generic approach, just in case. The resulting representation, for example for "LogicalUnit", will be the following: <xs:complexType name="LogicalUnit"> <xs:sequence> ... </xs:sequence> <xs:attribute name="id" type="xs:string"/> </xs:complexType> Change-Id: I046b8bd2f71e0add754e4193885aeb8ba7110e70 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaNames.java 2 files changed, 48 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I046b8bd2f71e0add754e4193885aeb8ba7110e70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix potential NPE
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE ...................................................................... webadmin: Fix potential NPE Fix potential NPE in ImportExportImagePopupView. Issue found by coverity #1201902 Change-Id: Id3ada81481349cbcc530057524a58a5faba05b9b Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3ada81481349cbcc530057524a58a5faba05b9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Failing to run VM with network host device
by masayag＠redhat.com 14 Dec '15

14 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Failing to run VM with network host device ...................................................................... engine: Failing to run VM with network host device Change-Id: Ieb20fd1332285407e4069b1a3d64a5d0281a8813 Bug-Url: https://bugzilla.redhat.com/1273058 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50175 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb20fd1332285407e4069b1a3d64a5d0281a8813 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Cleaning up any vm or network libvirt leftovers
by dcaro＠redhat.com 14 Dec '15

14 Dec '15

David Caro has submitted this change and it was merged. Change subject: Cleaning up any vm or network libvirt leftovers ...................................................................... Cleaning up any vm or network libvirt leftovers Sometimes if a set of tests that run lago are aborted, it has no opportunity to clean up after it, this takes a lazy approach and cleans it up whenever it's going to be used again Change-Id: Ifea081babbb7e34c48c192e18efc94ccd92d98b2 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/cleanup_slave.sh 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/50020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea081babbb7e34c48c192e18efc94ccd92d98b2 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix of labels of checkboxes in virt dialogs
by tjelinek＠redhat.com 14 Dec '15

14 Dec '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of labels of checkboxes in virt dialogs ...................................................................... webadmin: Fix of labels of checkboxes in virt dialogs It adds back labels for for checkboxes 'Stateless', 'Start in Pause Mode', 'Delete Protection', 'Copy VM permissions' in virt dialogs (VM, Template). Labels were accidentally removed by https://gerrit.ovirt.org/#/c/49658. Change-Id: I8744a54b2fe8c442c736c25f828ac5c6f2858ebe Bug-Url: https://bugzilla.redhat.com/1231159 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8744a54b2fe8c442c736c25f828ac5c6f2858ebe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Support NFS v4.1 connections
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Support NFS v4.1 connections ...................................................................... core: Support NFS v4.1 connections Support connections of v4.1 and their creation through webadmin/REST api Bug-Url: https://bugzilla.redhat.com/1283964 Change-Id: I66ba5703a035f9cd5bbec8ac01a266c9b2653ccd Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NfsVersion.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NfsVersion.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 8 files changed, 32 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66ba5703a035f9cd5bbec8ac01a266c9b2653ccd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DataCenterWithoutSpm should be disabled always
by laravot＠redhat.com 14 Dec '15

14 Dec '15

Liron Aravot has submitted this change and it was merged. Change subject: core: DataCenterWithoutSpm should be disabled always ...................................................................... core: DataCenterWithoutSpm should be disabled always The config value DataCenterWithoutSpm was added with false value for dc version <= 3.6 but with default value of true for other versions, as version 4.0 was added code that was relevant for dc without spm ran automatically. this patch disables this config value for all versions. Change-Id: I37887f5ac4c928c1202311df5948f1e28512b1b7 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/50419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37887f5ac4c928c1202311df5948f1e28512b1b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused VdsFenceOptions methods
by amureini＠redhat.com 14 Dec '15

14 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused VdsFenceOptions methods ...................................................................... core: Remove unused VdsFenceOptions methods Change-Id: I511b3db810924039f06c6b25e2d90df7d5ffa86a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java 1 file changed, 0 insertions(+), 116 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511b3db810924039f06c6b25e2d90df7d5ffa86a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: IrsProxyData methods naming conventions
by amureini＠redhat.com 14 Dec '15

14 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: IrsProxyData methods naming conventions ...................................................................... core: IrsProxyData methods naming conventions Fixed naming conventions of the IrsProxyData class' methods as per the recommended Java naming conventions. Change-Id: Ie87720029a6824740918b7c97e42042438d22a4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie87720029a6824740918b7c97e42042438d22a4d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LocaleUtilsTest methods naming conventions
by amureini＠redhat.com 14 Dec '15

14 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: LocaleUtilsTest methods naming conventions ...................................................................... core: LocaleUtilsTest methods naming conventions Fixed naming conventions of the LocaleUtilsTest class' methods as per the recommended Java naming conventions. Change-Id: Ib81defced36d46066a785ccc046dc11ab1d458cb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocaleUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib81defced36d46066a785ccc046dc11ab1d458cb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0