December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VdsFenceOptions methods naming conventions
by amureini＠redhat.com 14 Dec '15

14 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VdsFenceOptions methods naming conventions ...................................................................... core: VdsFenceOptions methods naming conventions Fixed naming conventions of the VdsFenceOptions class' methods as per the recommended Java naming conventions. Change-Id: I0a249f921bc33fc6738d671f8bd851c5f80a3882 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java 2 files changed, 21 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a249f921bc33fc6738d671f8bd851c5f80a3882 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Vm/Template dialog: Random generator label fixes
by tjelinek＠redhat.com 14 Dec '15

14 Dec '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Vm/Template dialog: Random generator label fixes ...................................................................... webadmin: Vm/Template dialog: Random generator label fixes * "Random generator enabled" label in Vm/Template/Pool dialog horizontally aligned. * Fix "Random generator enabled" label and corresponding checkbox being splitted to two rows. Change-Id: Ib0dd5c8e74854c38caf53eebda686e4041058e65 Bug-Url: https://bugzilla.redhat.com/1231159 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0dd5c8e74854c38caf53eebda686e4041058e65 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Handle ClassCastException in import VM/template po...
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Handle ClassCastException in import VM/template popups ...................................................................... webadmin: Handle ClassCastException in import VM/template popups When importing a VM or template, before there was the possibility to select a destination storage domain per disk we had a default storage domain selection, this is not used or visible for quite some time now and aside for throwing ClassCastException this model did nothing. Up till recently, UI exceptions did not propagate to the client and was ignored, now when UI exceptions are logged at the client it is visible to the user, this patch removes the remnant of this redundant model thus preventing the ClassCastException. Bug-Url: https://bugzilla.redhat.com/1289037 Change-Id: I9c1b69b81e01bd82265927fefb4e781969f15b14 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.ui.xml 4 files changed, 8 insertions(+), 54 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1b69b81e01bd82265927fefb4e781969f15b14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Enable initialization via run-once
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Enable initialization via run-once ...................................................................... restapi: Enable initialization via run-once Run-once needs to support initialization in order to rerun cloud-init (same as UI) This patch enables to set users others then root via rest. Change-Id: I70ba0d8c4308d2e91540777a2406627d3c79af22 Bug-Url: https://bugzilla.redhat.com/1287122 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 1 file changed, 4 insertions(+), 17 deletions(-) Approvals: Ori Liel: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70ba0d8c4308d2e91540777a2406627d3c79af22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix RSDL metadata for "provisioned_size"
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix RSDL metadata for "provisioned_size" ...................................................................... restapi: Fix RSDL metadata for "provisioned_size" The "provisioned_size" RSDL metadata didn't include the "disk" prefix, and thus the RSDL document generated was incorrect. This patch fixes that problem. Change-Id: Icef11f5bd5d7a70ab632bea17295a3708179ab7e Bug-Url: https://bugzilla.redhat.com/1290012 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 34b894b58a75d92c3d4ccc37341fb211bd85391f) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 19 insertions(+), 7 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef11f5bd5d7a70ab632bea17295a3708179ab7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused code in destroy-vm
by ahadas＠redhat.com 14 Dec '15

14 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused code in destroy-vm ...................................................................... core: remove unused code in destroy-vm Change-Id: I5f25845b4296d332fdce88f819f2f3bbf590501a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 3 files changed, 7 insertions(+), 26 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/50392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f25845b4296d332fdce88f819f2f3bbf590501a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: cleanup: removed accessor from data members names (2)
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: cleanup: removed accessor from data members names (2) ...................................................................... cleanup: removed accessor from data members names (2) This patch did this for anything left of this form in engine/ui/uicommonweb/models/storage. Change-Id: Ica241d3f4f883df2a9ae1fcb238d39e90178c839 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RemoveStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDomainModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 11 files changed, 87 insertions(+), 87 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vered Volansky: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica241d3f4f883df2a9ae1fcb238d39e90178c839 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gdpadgett(a)gmail.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Fix potential NPE in IrsProxyData
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine : Fix potential NPE in IrsProxyData ...................................................................... engine : Fix potential NPE in IrsProxyData Fixing potential NPE in IrsProxyData. Issue found in coverity #1224088 Change-Id: I7b8c92c6ef5ac52e64d325c21a213e1a00b3d8d4 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8c92c6ef5ac52e64d325c21a213e1a00b3d8d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Change String to static in Gluster tests
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Change String to static in Gluster tests ...................................................................... engine: Change String to static in Gluster tests Fixing "serverName" string field to static. Coverity: 1288900, 1288901, 1288902 Change-Id: Ibbf1bcc81c6ca0da53ccf52e7691e1693e36a32a Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbf1bcc81c6ca0da53ccf52e7691e1693e36a32a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix potential NPE in SD column
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE in SD column ...................................................................... webadmin: Fix potential NPE in SD column Fix potential NPE in StorageDomainAdditionalStatusColumn. Issue found by coverity #1306702 Change-Id: I156af5f8533fc444b6aba1188cabb50deccbfc04 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainAdditionalStatusColumn.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I156af5f8533fc444b6aba1188cabb50deccbfc04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0