March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: integrate @mask to VdsNetworkInterface
by lvernia＠redhat.com 31 Mar '15

31 Mar '15

Lior Vernia has submitted this change and it was merged. Change subject: backend: integrate @mask to VdsNetworkInterface ...................................................................... backend: integrate @mask to VdsNetworkInterface adding annotation to subnet field Change-Id: I27141b469edfbc696d8c72279e876d2474753af6 Bug-Url: https://bugzilla.redhat.com/1012881 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27141b469edfbc696d8c72279e876d2474753af6 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: adding @Mask annotation
by lvernia＠redhat.com 31 Mar '15

31 Mar '15

Lior Vernia has submitted this change and it was merged. Change subject: backend: adding @Mask annotation ...................................................................... backend: adding @Mask annotation adding @Mask annotation using MaskValidator util Change-Id: If92f2ec51f9cb647d6008b2fd2b1ab4c3db1d3f1 Bug-Url: https://bugzilla.redhat.com/1012881 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/MaskConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ValidatorConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Mask.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MaskAnnotationTest.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/MaskConstraintTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 347 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If92f2ec51f9cb647d6008b2fd2b1ab4c3db1d3f1 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: allowing prefix as mask staticIP conf
by lvernia＠redhat.com 31 Mar '15

31 Mar '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: allowing prefix as mask staticIP conf ...................................................................... webadmin: allowing prefix as mask staticIP conf allowing having prefix as mask of static IP configuration field, using maskValidation utill Change-Id: If909eda53a61bda5030c342156a01e53576e77cb Bug-Url: https://bugzilla.redhat.com/1012881 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidation.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java 7 files changed, 228 insertions(+), 70 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If909eda53a61bda5030c342156a01e53576e77cb Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: allowing mask as prefix
by lvernia＠redhat.com 31 Mar '15

31 Mar '15

Lior Vernia has submitted this change and it was merged. Change subject: backend: allowing mask as prefix ...................................................................... backend: allowing mask as prefix add prefix support to setupNetworks Change-Id: I6a33148aa297a9ba592466a827a987d256a83017 Bug-Url: https://bugzilla.redhat.com/1012881 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a33148aa297a9ba592466a827a987d256a83017 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: common: adding maskValidator util
by lvernia＠redhat.com 31 Mar '15

31 Mar '15

Lior Vernia has submitted this change and it was merged. Change subject: common: adding maskValidator util ...................................................................... common: adding maskValidator util Change-Id: I04fb0aa2193801688f1bfc5dc7684cabdfa2827d Bug-Url: https://bugzilla.redhat.com/1012881 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IpAddressConverter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/MaskValidator.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/MaskValidatorTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 7 files changed, 259 insertions(+), 28 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/35144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04fb0aa2193801688f1bfc5dc7684cabdfa2827d Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Report failure for missing system host provider
by masayag＠redhat.com 31 Mar '15

31 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Report failure for missing system host provider ...................................................................... engine: Report failure for missing system host provider If the ovirt-engine has no host provider associated with, the return value of the query should be a failure instead of an empty list of errata. Change-Id: Ica47f1d1c73cb41e672be9aea8be4f65a25f578f Bug-Url: https://bugzilla.redhat.com/1157377 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForSystemQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 13 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica47f1d1c73cb41e672be9aea8be4f65a25f578f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Added tables for geo replication entities
by sabose＠redhat.com 31 Mar '15

31 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Added tables for geo replication entities ...................................................................... engine: Added tables for geo replication entities Added sql script to create tables for geo-rep related entities Adding stored procs and database methods to access and update georeplication entities Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125845 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/gluster_georep_sp.sql A packaging/dbscripts/upgrade/03_05_1250_gluster_georep_tables.sql 9 files changed, 664 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shubhendu Tripathi: Looks good to me, but someone else must approve Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Change to geo-replication entities
by sabose＠redhat.com 31 Mar '15

31 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Change to geo-replication entities ...................................................................... engine: Change to geo-replication entities Added a collection of GeoRepSessionDetail objects to GeoRepSession and introduced volumeName as a property GeoRepSessionDetail is not a business entity on its own. So changed the interface implemented Change-Id: I5367f24dd677b8628d90459b4ba8115c665bfde7 Bug-Url: https://bugzilla.redhat.com/1125845 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java 4 files changed, 80 insertions(+), 15 deletions(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5367f24dd677b8628d90459b4ba8115c665bfde7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: gluster volume geo replication entities
by sabose＠redhat.com 31 Mar '15

31 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: gluster volume geo replication entities ...................................................................... engine: gluster volume geo replication entities Gluster volume geo replication entities Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 6 files changed, 374 insertions(+), 0 deletions(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Corrected ownership of the directories
by sabose＠redhat.com 31 Mar '15

31 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Corrected ownership of the directories ...................................................................... engine: Corrected ownership of the directories Added entries for directories for correct ownership Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Bug-Url: https://bugzilla.redhat.com/1104128 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Shubhendu Tripathi: Verified -- To view, visit https://gerrit.ovirt.org/39268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0