Change in ovirt-node-plugin-vdsm[master]: engine_page: Catch exception KeyError
by fabiand＠redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: engine_page: Catch exception KeyError
......................................................................
engine_page: Catch exception KeyError
If VDSM is not ready to provide network data via vdscli.getVdsCaps()['info']['networks']
and fail with KeyError we should throw an error message and not stuck in the login.
Additionally, for unexpected exceptions in vdscli we should log as error and not use
raise to avoid users getting blocked into the login page.
Change-Id: I4b7666c2020307c6119f96a2935684bc268e459b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198029
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, approved
Douglas Schilling Landgraf: Verified
--
To view, visit https://gerrit.ovirt.org/38428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b7666c2020307c6119f96a2935684bc268e459b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-engine[master]: webadmin: Make updateActionAvailability in VmListModel more ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Make updateActionAvailability in VmListModel more readable
......................................................................
webadmin: Make updateActionAvailability in VmListModel more readable
Change-Id: I6882f2312a246e02b1b1caa960864b30197d14af
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 21 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6882f2312a246e02b1b1caa960864b30197d14af
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-engine[master]: webadmin: Allow actions on a VM list even if not available o...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Allow actions on a VM list even if not available on all VMs
......................................................................
webadmin: Allow actions on a VM list even if not available on all VMs
When selecting multiple VMs in the VM main tab, allow to run certain
actions (Run, Suspend, Shutdown, Power Off, Reboot, Migrate,
Cancel Migration) even if not all the selected VMs are elegible for running
those actions
Change-Id: Ic2f10f1992838ecef796989b83a6fa1f2e34d443
Bug-Url: https://bugzilla.redhat.com/1051388
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 28 insertions(+), 7 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Verified
--
To view, visit https://gerrit.ovirt.org/38415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2f10f1992838ecef796989b83a6fa1f2e34d443
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-hosted-engine-setup[master]: glusterfs: better error messages
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: glusterfs: better error messages
......................................................................
glusterfs: better error messages
Added volume info to Volume not found error.
Moved the warning about replica3 needed to info level.
Change-Id: I0a8622ede6be78a4fa58b6cea3032975315024d6
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/nfs.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a8622ede6be78a4fa58b6cea3032975315024d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: setting an ISO image for cloud-init config...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: setting an ISO image for cloud-init configuration
......................................................................
packaging: setup: setting an ISO image for cloud-init configuration
cloud-init could be used to configure the engine VM.
With no-cloud datasource, cloud-init simply requires an
iso9660 image with /user-data and /meta-data yaml formatted
files without additional network requirements.
Let the user configure it.
Change-Id: I1a2cce9c47f4e6a6279dcb1657dbbcc9a3e5f04e
Bug-Url: https://bugzilla.redhat.com/1198138
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
4 files changed, 50 insertions(+), 12 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/38350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a2cce9c47f4e6a6279dcb1657dbbcc9a3e5f04e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-hosted-engine-setup[master]: bin: connect-storage: rebase on vdsClient vdsm-cli-4.17.0-415
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: bin: connect-storage: rebase on vdsClient vdsm-cli-4.17.0-415
......................................................................
bin: connect-storage: rebase on vdsClient vdsm-cli-4.17.0-415
The command line parser used within vdsClient
changed causing several parameters to be
badly interpreted.
Fixed also the connection command line for glusterfs.
Change-Id: Ia574d3d73b03b4f9d82d07ba7b73bf9faf8cec76
Bug-Url: https://bugzilla.redhat.com/1173669
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/bin/hosted-engine.in
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/37772
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia574d3d73b03b4f9d82d07ba7b73bf9faf8cec76
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: fixing VM parameters type when read from a...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing VM parameters type when read from an OVF file
......................................................................
packaging: setup: fixing VM parameters type when read from an OVF file
If manually entered (booting from CD), VCPUS and MEM_SIZE_MB
are stored in the enviroment as strings, if read from OVF
they should be stored in the same way cause everything else assume that
they are strings.
Change-Id: Ie9adf2248995a5e9e12d01065d4d5d4e4acdaa9d
Bug-Url: https://bugzilla.redhat.com/1198725
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
1 file changed, 7 insertions(+), 9 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/38389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9adf2248995a5e9e12d01065d4d5d4e4acdaa9d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in jenkins[master]: jobs: ovirt-engine-wildfly
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: jobs: ovirt-engine-wildfly
......................................................................
jobs: ovirt-engine-wildfly
Issue: https://fedorahosted.org/ovirt/ticket/225
Change-Id: I14c1df2261023adb0dccd6a82d539159495cbb8a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/yaml/jobs/ovirt-engine-wildfly/ovirt-engine-wildfly.yaml
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14c1df2261023adb0dccd6a82d539159495cbb8a
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in jenkins[master]: vdsm: master: fix Fedora updates-testing repos
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: master: fix Fedora updates-testing repos
......................................................................
vdsm: master: fix Fedora updates-testing repos
Fixed Fedora updates-testing repos and use the proxy for them.
Change-Id: I3c9c6772682de9ccfe751a3098f5adae9ce179a7
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml
M jobs/confs/yaml/jobs/vdsm/vdsm_create_libgfapi-rpms.yaml
2 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Barak Korren: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c9c6772682de9ccfe751a3098f5adae9ce179a7
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <kovganm(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months
Change in ovirt-engine[master]: webadmin: Create VM from Templates list view
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Create VM from Templates list view
......................................................................
webadmin: Create VM from Templates list view
Adding a new UI action "New VM" in the Templates list view.
It is enable only when a single template is selected.
When the user clicks on this action, the "New VM" dialog appears.
In the template drop down only the selected template from the list and
all it versions will be available. The selected item in the drop down
will be the template highlighted in the list view.
Change-Id: I0e5fd7e84bbea9405bf7d9e087b4281866daa954
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1117484
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
9 files changed, 462 insertions(+), 227 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Fred Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/38286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e5fd7e84bbea9405bf7d9e087b4281866daa954
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 2 months