March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5.2]: getVMList: introducing onlyUUID parameter
by oourfali＠redhat.com 09 Mar '15

09 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: getVMList: introducing onlyUUID parameter ...................................................................... getVMList: introducing onlyUUID parameter Due to vdsm sending only an array of vmids in a response to getVMList the engine asks separately using VM.getStats which creates unnecessary load. We need to make sure that for newer engines vdsm sends map of vmids and status and for older engines an array as it was before. In order to achieve it we introduce new parameter 'onlyUUID' for getVMList which is ignored by older vdsms and it makes sure that newer vdsms send a map which fixes performance issue. Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1198248 Related-To: https://gerrit.ovirt.org/#/c/38449 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Francesco Romani: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: getVMList: introducing onlyUUID parameter
by oourfali＠redhat.com 09 Mar '15

09 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: getVMList: introducing onlyUUID parameter ...................................................................... getVMList: introducing onlyUUID parameter Due to vdsm sending only an array of vmids in a response to getVMList the engine asks separately using VM.getStats which creates unnecessary load. We need to make sure that for newer engines vdsm sends map of vmids and status and for older engines an array as it was before. In order to achieve it we introduce new parameter 'onlyUUID' for getVMList which is ignored by older vdsms and it makes sure that newer vdsms send a map which fixes performance issue. Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1198248 Related-To: https://gerrit.ovirt.org/#/c/38449 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Francesco Romani: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: getVMList: introducing onlyUUID parameter
by oourfali＠redhat.com 09 Mar '15

09 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: getVMList: introducing onlyUUID parameter ...................................................................... getVMList: introducing onlyUUID parameter Due to vdsm sending only an array of vmids in a response to getVMList the engine asks separately using VM.getStats which creates unnecessary load. We need to make sure that for newer engines vdsm sends map of vmids and status and for older engines an array as it was before. In order to achieve it we introduce new parameter 'onlyUUID' for getVMList which is ignored by older vdsms and it makes sure that newer vdsms send a map which fixes performance issue. Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1198248 Related-To: https://gerrit.ovirt.org/#/c/38449 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Francesco Romani: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: vds command to list storage devices
by sabose＠redhat.com 09 Mar '15

09 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: vds command to list storage devices ...................................................................... engine: vds command to list storage devices VDS Command to list all the storage devices in the host. Change-Id: Id47eadcb57d3f544481b577da7507f4fc9a10c67 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetStorageDeviceListVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StorageDeviceListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 133 insertions(+), 0 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/35313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id47eadcb57d3f544481b577da7507f4fc9a10c67 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Entity and DAO changes for Disk provisioning
by sabose＠redhat.com 09 Mar '15

09 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine : Entity and DAO changes for Disk provisioning ...................................................................... engine : Entity and DAO changes for Disk provisioning Add new entity 'StorageDevice' and related DAO changes. StorageDevice represents the storage devices in the system like disks, partitions, pvs, lvs, etc. Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/StoageDeviceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/storage_device_sp.sql A packaging/dbscripts/upgrade/03_06_0960_add_storage_device_tables.sql 9 files changed, 601 insertions(+), 0 deletions(-) Approvals: Ramesh N: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix db scheduler test
by masayag＠redhat.com 09 Mar '15

09 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix db scheduler test ...................................................................... engine: Fix db scheduler test The tests fails periodically due to the timing between quartz scheduler thread and main thread Increased sleep duration in main thread. Change-Id: I2ff92a2331dfa3ac7d99e4ef8d858b21f1ffda05 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ff92a2331dfa3ac7d99e4ef8d858b21f1ffda05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use getDbFacade() instead of static access
by masayag＠redhat.com 08 Mar '15

08 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use getDbFacade() instead of static access ...................................................................... engine: Use getDbFacade() instead of static access Change-Id: Ia885bd989f841fee2161034e11b481e3ebe316c4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia885bd989f841fee2161034e11b481e3ebe316c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix <UNKNOWN> VMs count in audit log
by masayag＠redhat.com 08 Mar '15

08 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix <UNKNOWN> VMs count in audit log ...................................................................... engine: Fix <UNKNOWN> VMs count in audit log The audit log should translate the ${VmsCount} placeholder with the expected number of vms within the add/update action. Change-Id: Iac860a6a0bed67f80fa81be13768445af251b8c4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac860a6a0bed67f80fa81be13768445af251b8c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Ensure vm disks are set at initialization
by masayag＠redhat.com 08 Mar '15

08 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Ensure vm disks are set at initialization ...................................................................... engine: Ensure vm disks are set at initialization Ensures the disks and their target destination are set before the command is instantiated. Change-Id: I60273d948086465e637d6eec34445468b7acc0a7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommandTest.java 4 files changed, 24 insertions(+), 22 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60273d948086465e637d6eec34445468b7acc0a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use postConstruct for initialing command state
by masayag＠redhat.com 08 Mar '15

08 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use postConstruct for initialing command state ...................................................................... engine: Use postConstruct for initialing command state Change-Id: I4aafdc4f963c85574c8f10691f013dcdadc3e5af Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommandTest.java 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aafdc4f963c85574c8f10691f013dcdadc3e5af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0