April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Provide meaningful FenceAgent.toString()
by emesika＠redhat.com 01 Apr '15

01 Apr '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Provide meaningful FenceAgent.toString() ...................................................................... core: Provide meaningful FenceAgent.toString() Provide meaningful toString() method for FenceAgent which can be used for logging purposes. Change-Id: I8e83e80f7a1701a42aa06a64501a30b4aa94c244 Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceAgent.java 2 files changed, 19 insertions(+), 7 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e83e80f7a1701a42aa06a64501a30b4aa94c244 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup
by ahadas＠redhat.com 01 Apr '15

01 Apr '15

Arik Hadas has submitted this change and it was merged. Change subject: core: minor cleanup ...................................................................... core: minor cleanup Rename GetDiskAlignmentCommand#getDiskType to getDiskStorageType since it returns DiskStorageType and not to confuse with DiskContentType that is planned to be added Change-Id: If635aa172517945d940a29a3f0f4f4001ee3bc1c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/39141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If635aa172517945d940a29a3f0f4f4001ee3bc1c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: common: Introduce ToStringBuilder
by emesika＠redhat.com 01 Apr '15

01 Apr '15

Eli Mesika has submitted this change and it was merged. Change subject: common: Introduce ToStringBuilder ...................................................................... common: Introduce ToStringBuilder Introduces ToStringBuilder: - it eases implementation of toString() method - it makes output of toString() methods in the project consistent - it can be used with GWT (unlike for example commons-lang) Change-Id: I3d4baa2430a45b0281b7891eb19ad2094c1b3408 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ToStringBuilder.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ToStringBuilderTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 581 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d4baa2430a45b0281b7891eb19ad2094c1b3408 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: webadmin: no auto logout when idle
by tnisan＠redhat.com 01 Apr '15

01 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: no auto logout when idle ...................................................................... webadmin: no auto logout when idle - The general VM sub tab and network interface VM sub tab where executing queries that didn't have their refresh false flag set. Change-Id: I52b9ea108ddca3d2d137860b9425691ffc0a95ef Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206332 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52b9ea108ddca3d2d137860b9425691ffc0a95ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: webadmin: REST API login popup
by tnisan＠redhat.com 01 Apr '15

01 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: REST API login popup ...................................................................... webadmin: REST API login popup - The REST API login popup would appear when one of the following was true: 1 The engine session hard limit was reached (10 hours) and the REST API ping would happen before a refresh that would cause a logout. 2 The REST API ping would not happen due to it detecting that the refresh flag was not set, however the engine would internally set the refresh on a sub query. This causes the REST api http session to expire and on a sub sequent ping would cause the popup to appear. - This patch fixes 1. We take the hard limit into account and if we are close enough to the hard limit the REST API ping is disabled causing the natural logout of the webadmin UI to happen. Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206908 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/EngineSessionTimeoutData.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 5 files changed, 53 insertions(+), 16 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.2_rc3
by sradco＠redhat.com 01 Apr '15

01 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5.2_rc3 ...................................................................... build: post ovirt-engine-reports-3.5.2_rc3 Change-Id: Ief02b56f0c1fed67ff04829fd0a733d1b0401b50 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief02b56f0c1fed67ff04829fd0a733d1b0401b50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.2_rc3
by sradco＠redhat.com 01 Apr '15

01 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5.2_rc3 ...................................................................... build: ovirt-engine-reports-3.5.2_rc3 Change-Id: Ic9d1d4e189bb7a5ca0043b4511c25917e947abad Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9d1d4e189bb7a5ca0043b4511c25917e947abad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: ovirt-hosted-engine-setup-1.2.3-0.1.rc
by sbonazzo＠redhat.com 01 Apr '15

01 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.3-0.1.rc ...................................................................... build: ovirt-hosted-engine-setup-1.2.3-0.1.rc Change-Id: Id70e409ef49bf41e2ba4b82f352ee16aaf6af9c7 Bug-Url: https://bugzilla.redhat.com/1186161 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id70e409ef49bf41e2ba4b82f352ee16aaf6af9c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0