May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Inject QuotaManager and make it a BackendService
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Inject QuotaManager and make it a BackendService ...................................................................... core: Inject QuotaManager and make it a BackendService Change-Id: I272f22c4fdbcb96d27e9d5c84a679af4b9f80801 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotasConsumptionForCurrentUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java 12 files changed, 73 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I272f22c4fdbcb96d27e9d5c84a679af4b9f80801 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Inject AutoStartVmsRunner and make it a BackendService
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Inject AutoStartVmsRunner and make it a BackendService ...................................................................... core: Inject AutoStartVmsRunner and make it a BackendService Change-Id: I5fdf736e8ae33b8b55a6f6294dc0cca4a2603897 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 5 files changed, 41 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fdf736e8ae33b8b55a6f6294dc0cca4a2603897 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make VmpoolMonitor a BackendService and a CDI bean
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Make VmpoolMonitor a BackendService and a CDI bean ...................................................................... core: Make VmpoolMonitor a BackendService and a CDI bean Change-Id: Icaadcc92ae352e8a775dee321b70db0d3dab11f3 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java 4 files changed, 36 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaadcc92ae352e8a775dee321b70db0d3dab11f3 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make DwhHeartBeat a BackendService and a CDI bean
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Make DwhHeartBeat a BackendService and a CDI bean ...................................................................... core: Make DwhHeartBeat a BackendService and a CDI bean Change-Id: I53589a48f302d6b3711afa144b666a1e1694406e Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java 2 files changed, 18 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Roy Golan: Verified Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53589a48f302d6b3711afa144b666a1e1694406e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make Singletons also BackendService and load them
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Make Singletons also BackendService and load them ...................................................................... core: Make Singletons also BackendService and load them - Use CDI programatic API to fetch instances, which initializes them if not exist. - use internal loadService method to get a concise, clean and constant manner of service loading - TODO every service maintainer/creator must follow the same loading manner unless special handling needed. Change-Id: I542278b8511def02fa1b93bdfb0703c7ff2dd462 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 5 files changed, 41 insertions(+), 30 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Roy Golan: Verified Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I542278b8511def02fa1b93bdfb0703c7ff2dd462 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Inject CacheManager instead of jndi lookup
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Inject CacheManager instead of jndi lookup ...................................................................... core: Inject CacheManager instead of jndi lookup - Make CacheManager a @Singleton bean - don't do a jndi lookup for every invocation just to get the internal cache instance Change-Id: I02f480abf1739c717f37f174d968b780f7fbd2a0 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/BackendService.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/utils/CacheManager.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cache/CacheManager.java 5 files changed, 45 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Roy Golan: Verified Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f480abf1739c717f37f174d968b780f7fbd2a0 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Inject Task schedulers instead of JNDI lookups
by rgolan＠redhat.com 28 May '15

28 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Inject Task schedulers instead of JNDI lookups ...................................................................... core: Inject Task schedulers instead of JNDI lookups continue the JNDI and EJB cleanup and move Singleton like task scheduling to CDI. <code> @Inject SchedulUtilBaseImpl taskScheduler; // will inject a SchedulerUtilBaseImpl </code> - getInstance() exist for legacy code. Prefer Injection over it. - all scheulers are loaded first after the DB connection established. See Backend.initialize() Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/scheduler/exclude-filters.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java A backend/manager/modules/scheduler/src/main/resources/META-INF/beans.xml M ear/pom.xml 12 files changed, 91 insertions(+), 89 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: RefreshHostDevicesCommand- remove entries from table...
by masayag＠redhat.com 28 May '15

28 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: RefreshHostDevicesCommand- remove entries from table before adding ...................................................................... engine: RefreshHostDevicesCommand- remove entries from table before adding Removing entries from the tables (host_device, host_nic_vfs_config) should be done before adding new ones- to avoid potential duplicate error of unique columns. Change-Id: Id4e6f88f0e3e6ce43d68709e0ec80b44d951bf96 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImpl.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImplTest.java 4 files changed, 52 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e6f88f0e3e6ce43d68709e0ec80b44d951bf96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: core: Fix typos in Gluster geo-replication
by sabose＠redhat.com 28 May '15

28 May '15

Sahina Bose has submitted this change and it was merged. Change subject: core: Fix typos in Gluster geo-replication ...................................................................... core: Fix typos in Gluster geo-replication Fixed typos: - brocker -> broker - inetrevene -> intervene Change-Id: I426d42c9c24e106aa482768d8e2a187ee5d4ae06 Bug-Url: https://bugzilla.redhat.com/1221052 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I426d42c9c24e106aa482768d8e2a187ee5d4ae06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: change brick creation failure audit log to error
by sabose＠redhat.com 28 May '15

28 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: change brick creation failure audit log to error ...................................................................... gluster: change brick creation failure audit log to error Change the severity of Brick Creation failure to Error. Change-Id: Id87851b03a1581f503ab15ec00e2738b81ef4a77 Bug-Url: https://bugzilla.redhat.com/1220784 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id87851b03a1581f503ab15ec00e2738b81ef4a77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0