Change in ovirt-engine[master]: webadmin: UI plugin API - setSearchString
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin API - setSearchString
......................................................................
webadmin: UI plugin API - setSearchString
This patch adds new UI plugin API function ('setSearchString')
that can be used to apply given search string in WebAdmin's
search panel.
Just like the Search button, calling setSearchString function
triggers transition to the corresponding application place,
e.g. following code:
api.setSearchString('Vms:');
causes the application to reveal following place:
WebAdmin.html#vms // 'VM' main tab place
API signature:
setSearchString(searchString)
Example usage:
api.setSearchString('Hosts: name = abc');
Change-Id: I36eb8647577e974bddefe9462d302165a39b1c27
Bug-Url: https://bugzilla.redhat.com/1081028
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplySearchStringEvent.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
4 files changed, 125 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/40405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36eb8647577e974bddefe9462d302165a39b1c27
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: UI plugin API - revealPlace
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin API - revealPlace
......................................................................
webadmin: UI plugin API - revealPlace
This patch adds new UI plugin API function ('revealPlace')
that can be used to reveal desired application place, e.g.
main or sub tab. An application place denotes a logical
state of the web application, represented as '#placeToken'
in application's URL, for example:
WebAdmin.html#vms // 'VM' main tab place
WebAdmin.html#vms-general // 'VM General' sub tab place
revealPlace function works for both standard (built-in) and
custom (UI-plugin-contributed) places, assuming that given
place to reveal is available at time the function is called.
(Otherwise, WebAdmin will transition to its default place,
currently set to 'VM' main tab.)
API signature:
revealPlace(placeToken)
Example usage:
// switch to 'Hosts' main tab
api.revealPlace('hosts');
// add custom main tab and switch to it
api.addMainTab('Test', 'test', 'plugin/TestPlugin/tab.html');
api.revealPlace('test');
Note: setting place parameters, such as:
WebAdmin.html#placeToken;paramName=paramValue
is not supported (yet) since there currently aren't
any application places utilizing such parameters.
Change-Id: Ib4ae30f62c5bcd6793e19c8be6806f32bf68eee1
Bug-Url: https://bugzilla.redhat.com/1168334
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
2 files changed, 24 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/40404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4ae30f62c5bcd6793e19c8be6806f32bf68eee1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: add validation for create brick popup view
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: add validation for create brick popup view
......................................................................
webadmin: add validation for create brick popup view
Adding validations for entities in create brick popup view.
Change-Id: I16d3a2c377a80f37b6f8aba061ad26ac17d9736b
Bug-Url: https://bugzilla.redhat.com/1211976
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/BrickMountPointValidation.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/BrickMountPointValidationTest.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.ui.xml
6 files changed, 163 insertions(+), 2 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/39439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16d3a2c377a80f37b6f8aba061ad26ac17d9736b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: frontend: Refresh HostDevices on Refresh Host Button
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Refresh HostDevices on Refresh Host Button
......................................................................
frontend: Refresh HostDevices on Refresh Host Button
Changed refreshCapabilities() method to do a full refresh of host
(with host devices).
Also fixed a NPE in RefreshHost command (missing action group) in
VdcActionType definition.
Change-Id: Ice72af739025a1eed63451e0f4083b1f90d84b6b
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/40399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice72af739025a1eed63451e0f4083b1f90d84b6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: support Cinder disks on run VM
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: support Cinder disks on run VM
......................................................................
core: support Cinder disks on run VM
Modified VmInfoBuilder to support Cinder disk
build on 'buildVmDrives' method.
Change-Id: I52521834d049f22c2e9f183b2c57ae558853cfa4
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
2 files changed, 66 insertions(+), 18 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52521834d049f22c2e9f183b2c57ae558853cfa4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: update CinderDisks connections on RunVm
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: update CinderDisks connections on RunVm
......................................................................
core: update CinderDisks connections on RunVm
Invoking updateCinderDisksConnections on RunVmCommand to
retrieve the relevant ConnectionInfo (which should include
a list of available monitors IPs for Ceph) from Cinder.
Change-Id: Ie48e01acd6c3afcbc322603e0358b63e2b2bdf99
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderVolumeDriver.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 41 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie48e01acd6c3afcbc322603e0358b63e2b2bdf99
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: packaging: setup: deploy Cinder and Glance Docker containers
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: deploy Cinder and Glance Docker containers
......................................................................
packaging: setup: deploy Cinder and Glance Docker containers
deploy Cinder and Glance via Docker containers
Change-Id: Id192819a95343df9d9d035f8632d17ac76d2d82f
Bug-Url: https://bugzilla.redhat.com/1195127
Bug-Url: https://bugzilla.redhat.com/1195131
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt-engine.spec.in
M packaging/dbscripts/inst_sp.sql
A packaging/firewalld/dockerc/ovirt-local-cinder.xml.in
A packaging/firewalld/dockerc/ovirt-local-glance.xml.in
A packaging/setup/ovirt_engine_setup/dockerc/__init__.py
A packaging/setup/ovirt_engine_setup/dockerc/constants.py
M packaging/setup/ovirt_engine_setup/hostname.py
A packaging/setup/plugins/ovirt-engine-common/dockerc/__init__.py
A packaging/setup/plugins/ovirt-engine-common/dockerc/core.py
A packaging/setup/plugins/ovirt-engine-remove/dockerc/__init__.py
A packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py
A packaging/setup/plugins/ovirt-engine-setup/dockerc/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py
13 files changed, 1,154 insertions(+), 29 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/39519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id192819a95343df9d9d035f8632d17ac76d2d82f
Gerrit-PatchSet: 48
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: VirtIO console access key management
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: VirtIO console access key management
......................................................................
core: VirtIO console access key management
This change introduces a command to edit of public keys to be used to
grant the user access into a SSH-based proxy that exposes the
serial console of every running VM.
Feature wiki page: http://www.ovirt.org/Features/Serial_Console
Change-Id: I5ff5403823e752e695ebde76a4b7fb83e07099b6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserProfileQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveUserProfileCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UserProfileParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
A packaging/dbscripts/upgrade/03_06_1320_attach_edit_userprofile_permission.sql
17 files changed, 380 insertions(+), 0 deletions(-)
Approvals:
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ff5403823e752e695ebde76a4b7fb83e07099b6
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: improve error checking on import dialog
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: improve error checking on import dialog
......................................................................
webadmin: improve error checking on import dialog
Consider the following scenario:
1. VM with id=1 and name='A' already exists in the system
2. The user is about to import a VM with id=2 and name='A'
We would expect the UI to tell the user that the VM already exists so
he'll choose a different name. However, the actual result is that the UI
pass the request to the backend, and the backend generates the error.
This patch solves it.
Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmData.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
4 files changed, 65 insertions(+), 24 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/40310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: change name of imported vm not as a clone
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: change name of imported vm not as a clone
......................................................................
core: change name of imported vm not as a clone
It was not possible to change the name of a VM that is being imported
not as a clone. The import command is now changed to support that.
Change-Id: I1e315e8bdcb1dd5e0c650878602bfc947a9fa7ae
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/40314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e315e8bdcb1dd5e0c650878602bfc947a9fa7ae
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months