Change in ovirt-engine[master]: backend: Extend vm_device.device column
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: backend: Extend vm_device.device column
......................................................................
backend: Extend vm_device.device column
Increase size of the 'device' column because it is used to store
host_device.device_name values which can be up to 255 characters
long.
Change-Id: I7c02d5c2e84fdc7c843cc6e3ce983d7308c60d61
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_1340_change_vm_device_column_length.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/40489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c02d5c2e84fdc7c843cc6e3ce983d7308c60d61
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: packaging: setup: pki: renew about to expire certificates
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: pki: renew about to expire certificates
......................................................................
packaging: setup: pki: renew about to expire certificates
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210486
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860
Change-Id: I6383b29e131d65cece96e298bb2c7fe6ae305afe
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
2 files changed, 256 insertions(+), 124 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40330
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6383b29e131d65cece96e298bb2c7fe6ae305afe
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: UI plugin revealPlace API - rename parameter
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin revealPlace API - rename parameter
......................................................................
webadmin: UI plugin revealPlace API - rename parameter
Renamed placeToken to historyToken for consistency
with existing APIs such as addMainTab & addSubTab.
No impact on revealPlace API implementation.
Change-Id: I073f51acb95438fbccf1f0c58796a885a44c1a50
Bug-Url: https://bugzilla.redhat.com/1168334
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/40494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I073f51acb95438fbccf1f0c58796a885a44c1a50
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: backup awareness refactoring
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: backup awareness refactoring
......................................................................
core: backup awareness refactoring
This patch introduces the following changes in the backup awareness
mechanism:
1) db_name was renamed to scope and can have values :
{db,dwhdb,reportsdb,files}
2) Adding fqdn field to note that the log is remote
3) Adding log_path for the full log file name
4) Fix hashcode & equals BE methods to include only the BE ID fields
Updated wiki page : http://www.ovirt.org/Features/BackupAwareness
Change-Id: I82c4a5372a9108d8c4d5960112f27a0b94f3b654
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineBackupLogDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/engine_backup_log_sp.sql
A packaging/dbscripts/upgrade/03_06_1330_backup_extensions.sql
9 files changed, 87 insertions(+), 62 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82c4a5372a9108d8c4d5960112f27a0b94f3b654
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: ExtendSANStorageDomain storage type check
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ExtendSANStorageDomain storage type check
......................................................................
core: ExtendSANStorageDomain storage type check
ExtendSANStorageDomainCommand should only be applied on block storage
domains.
The current canDoAction() is wrong, as it theoritically[1] allows the
command to be run on POSIX, Gluster and LocalFS storage domains.
[1] Note: With the current code base this patch has no functional gain,
as this condition is checked in every flow that can potentially call
this command (both GUI and REST), but it is the correct thing to do, and
may serve to prevent future bugs if this command is ever called from a
different flow.
Change-Id: If25b65ba482a1659d5083f06dd76fa42c68e971e
Bug-Url: https://bugzilla.redhat.com/1213969
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/40496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If25b65ba482a1659d5083f06dd76fa42c68e971e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix backported patch
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix backported patch
......................................................................
core: Fix backported patch
Remove duplicate register of unregisterd disks
which introduced in 5c8f7aee464ea935a92837c92718ad5c04e1f02d
Change-Id: Idbed3c37d3beef992eff2343c15a3961bdc93a02
Bug-Url: https://bugzilla.redhat.com/1217339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/40493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbed3c37d3beef992eff2343c15a3961bdc93a02
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-release[master]: support .repo overrides
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: support .repo overrides
......................................................................
support .repo overrides
- add support for overriding url key, url & path
- leave DIST for RPM to handle
- gitignore: project files [idea/eclipse], .spec files
Change-Id: I0453fb472d80a190278a0ffbae4371ad724b4c46
Signed-off-by: Max Kovgan <mvk(a)redhat.com>
---
M .gitignore
M AUTHORS
M ovirt-release-master/configure.ac
M ovirt-release-master/ovirt-release-master.spec.in
M ovirt-release-master/ovirt-snapshot.repo.in
5 files changed, 84 insertions(+), 36 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
Max Kovgan: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0453fb472d80a190278a0ffbae4371ad724b4c46
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: userportal, webadmin: VM console key management
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal, webadmin: VM console key management
......................................................................
userportal, webadmin: VM console key management
This change introduces an editor of public keys to be used to
grant the user access into a SSH-based proxy that exposes the
serial console of every running VM.
A new button was added in both WebAdmin and UserPortal to edit the
public key assigned to the user in the database
Feature wiki page: http://www.ovirt.org/Features/Serial_Console
Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PublicKeyPopupWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PublicKeyPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/PublicKeyModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
A frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ICancelable.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/PublicKeyPopupPresenterWidget.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/PublicKeyPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/PublicKeyPopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/PublicKeyPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
24 files changed, 382 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/35810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: Engine: Change custom script help text
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: Engine: Change custom script help text
......................................................................
Engine: Change custom script help text
Change-Id: I40d2751018897727c5e3c8e9788471be95439c89
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1200300
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shahar Havivi: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40318
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40d2751018897727c5e3c8e9788471be95439c89
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Make Bookmark a Cacheable object
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Make Bookmark a Cacheable object
......................................................................
core: Make Bookmark a Cacheable object
Make Bookmark stored in Hibernate 2nd level cache,
implemented with Infinispan.
This improved API performance (including serialization and network) from ~700ms to get 6K Bookmarks
without JPA, to ~300ms to get 6K Bookmarks.
Change-Id: Id4c758dbca7e8d31a5cbecdd8eb9dc65fa8e6992
Bug-Url: https://bugzilla.redhat.com/1159621
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java
M packaging/services/ovirt-engine/ovirt-engine.xml.in
3 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/35023
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4c758dbca7e8d31a5cbecdd8eb9dc65fa8e6992
Gerrit-PatchSet: 46
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months