June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Check for VM status when activating IDE disks
by derez＠redhat.com 25 Jun '15

25 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Check for VM status when activating IDE disks ...................................................................... webadmin: Check for VM status when activating IDE disks When the VM is down and one tries to attach and activate an IDE disk, he gets an error message that tells him he can't activate it and that he should turn off the VM first. In addition, the disk is attached but not activated although the VM is down. This patch adds a check for the VM status to fix this issue. Change-Id: Ic2fe5e5974890ee591f6a903d9ea9ae024a22ac3 Bug-Url: https://bugzilla.redhat.com/1167248 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/42547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2fe5e5974890ee591f6a903d9ea9ae024a22ac3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add a test for the BooleanParser class
by juan.hernandez＠redhat.com 25 Jun '15

25 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add a test for the BooleanParser class ...................................................................... restapi: Add a test for the BooleanParser class This class has caused regressions in the past, so it is good to have a test to reduce chances of more regressions in the future. Change-Id: I39baf90abd1eae4dab849946e3ae48eae04114d8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/test/java/org/ovirt/engine/api/utils/BooleanParserTest.java 1 file changed, 93 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39baf90abd1eae4dab849946e3ae48eae04114d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Read complete HTTP reason code
by juan.hernandez＠redhat.com 25 Jun '15

25 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Read complete HTTP reason code ...................................................................... sdk: Read complete HTTP reason code Currently the SDK doesn't read the complete HTTP reason code sent by the server, only the first word. For example, if the server sends the following response line: HTTP/1.1 503 Service Unavailable The SDK will only get the first word and then it will generate an incomplete error report: status: 503 reason: Service This patch fixes that problem, so that the error report will contain the complete HTTP reason code: status: 503 reason: Service Unavailable This is a regression that was introduced as part of the changes to use PycURL instead of the builtin Python HTTP module. Change-Id: Ic7fff3d5b5c81aa949985a085afaf67c437365c9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/connectionspool.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/42556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7fff3d5b5c81aa949985a085afaf67c437365c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Handle null user when Adding VM internally
by rgolan＠redhat.com 25 Jun '15

25 Jun '15

Roy Golan has submitted this change and it was merged. Change subject: core: Handle null user when Adding VM internally ...................................................................... core: Handle null user when Adding VM internally a recent change to AddVm commands is making the current user and explicit owner. It didn't check the absent of a user in case of internal command, when adding external VMs and specially the Hosted Engine VM. Change-Id: I64166c38930b79944b57abf4e7312d173b40bcfe Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64166c38930b79944b57abf4e7312d173b40bcfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Clarify prompt text on certs renew
by sbonazzo＠redhat.com 25 Jun '15

25 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Clarify prompt text on certs renew ...................................................................... packaging: setup: Clarify prompt text on certs renew Inform the user that certs can be reniewed by simply running again. Change-Id: Iba3233cd1ab1c4b3a1d83394bc89c3940e515b48 Bug-Url: https://bugzilla.redhat.com/1214860 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba3233cd1ab1c4b3a1d83394bc89c3940e515b48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix unchecked casts warnings
by amureini＠redhat.com 24 Jun '15

24 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix unchecked casts warnings ...................................................................... core: Fix unchecked casts warnings Fixed warning about unchecked cast by using anyListOf(Class) instead of anyList(). Change-Id: Ic77251b2a83b0b27f98b0c5fe9ce58d50f477b1a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic77251b2a83b0b27f98b0c5fe9ce58d50f477b1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Proper mocking for Spy()ed command
by amureini＠redhat.com 24 Jun '15

24 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Proper mocking for Spy()ed command ...................................................................... core: Proper mocking for Spy()ed command A Spy()ed object's mocking should be done with the doSomething().when(object).someMethod() syntax instead of the when(objet.someMethod).thenDoSoemthing() syntax in order to prevent the real object from being executed. This patch fixes the mocking of the spied AddExistingBlockStorageDomainCommand instance in the test. This behavior, apart from being theoretically correct, was observed to remove a warning logged to stderr. Although the specifics of the timestamp and UUID could obviously change, the general form of the error was: """ 2015-06-24 18:48:55,813 SEVERE [org.ovirt.engine.core.bll.storage.AddExistingBlockStorageDomainCommand getLUNsFromVgInfo] Could not get info for VG ID 'ba0d7cea-173f-4b9a-ba29-128891ba9056': null """ This error may be related to recent failures observed in the CI environment (see, e.g., http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms_merged/label=e…) although this is unconfirmed at this time. Change-Id: Id89c834c557e0955bd064c7938a0a2966eed380d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id89c834c557e0955bd064c7938a0a2966eed380d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't mock default behavior
by amureini＠redhat.com 24 Jun '15

24 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't mock default behavior ...................................................................... core: Don't mock default behavior Removed mocking the behavior of returning a null StorageDomainStatic for any id. This is the default behavior of Mockito, and explicitly stating it is not only useless but also confusing. Change-Id: Ief5586e53b3e5f78c414e5729b4fe4527011c460 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief5586e53b3e5f78c414e5729b4fe4527011c460 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use java.util.Collections methods
by amureini＠redhat.com 24 Jun '15

24 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use java.util.Collections methods ...................................................................... core: Use java.util.Collections methods Stopped using ArrayLists and instead used Collections.emptyList() and Collections.singletonList(). This makes the code both shorter and more obvious to read. Change-Id: I0c1b59aa2bcb6b0da85946c37be1cea422bd51c2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c1b59aa2bcb6b0da85946c37be1cea422bd51c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove redundant "constants"
by amureini＠redhat.com 24 Jun '15

24 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant "constants" ...................................................................... core: Remove redundant "constants" Removed the redundant WARNING_LOW_SPACE_INDICATOR and CRITICAL_SPACE_ACTION_BLOCKER "constants". They are only used to inject config values (via the MockConfigRule) to config values which have names that are descriptive enough. The double declaration doesn't add anything besides lines of code. Change-Id: I5068bae9b3414d3ed9eb69c4cc56a703de73e58f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5068bae9b3414d3ed9eb69c4cc56a703de73e58f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0