Change in ovirt-engine[master]: engine: Add NetworkAttachmentValidator
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add NetworkAttachmentValidator
......................................................................
engine: Add NetworkAttachmentValidator
The NetworkAttachmentValidator serves as a validator for the
NetworkAttachment entity.
Unit tests will follow...
Change-Id: I908511f4c0f999d82120074c290eccd9e1006cdc
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/PluralMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
4 files changed, 262 insertions(+), 14 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/33331
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I908511f4c0f999d82120074c290eccd9e1006cdc
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: ReplacementUtils refactor+add method for setting variable
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: ReplacementUtils refactor+add method for setting variable
......................................................................
core: ReplacementUtils refactor+add method for setting variable
added method createSetVariableString for setting variable and
refactored remaining class accordingly to use this method.
Change-Id: I90c39963c58a6433f4e7a5297cf244357247b478
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java
1 file changed, 13 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90c39963c58a6433f4e7a5297cf244357247b478
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Remove unused maven-eclipse-plugin
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused maven-eclipse-plugin
......................................................................
core: Remove unused maven-eclipse-plugin
maven-eclipse-plugin is used for running "mvn eclipse:eclipse", which is
a deprecated way opening maven projects in Eclipse.
The proper way to use Eclipse to develop the oVirt Engine project is by
using the M2E plugin, as explained in
http://www.ovirt.org/Building_oVirt_Engine/IDE#Eclipse .
Change-Id: I9d461d82d6752accab0894fc6fa9ebc8b6e21813
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M pom.xml
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42852
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d461d82d6752accab0894fc6fa9ebc8b6e21813
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-node-plugin-vdsm[master]: spec: Dropping the vdsm-gluster depe
by fabiand＠redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: spec: Dropping the vdsm-gluster depe
......................................................................
spec: Dropping the vdsm-gluster depe
Change-Id: I07e5b51e57bf514baea9cb0a34577ba929ef59b0
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
Reviewed-on: https://gerrit.ovirt.org/42853
Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com>
Continuous-Integration: Fabian Deutsch <fabiand(a)redhat.com>
Tested-by: Fabian Deutsch <fabiand(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42853
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07e5b51e57bf514baea9cb0a34577ba929ef59b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id
......................................................................
core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id
Customer got dead locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id.
This patch sorts by GUID, so that we eliminate the option for deadlocks.
Change-Id: I24ce4b86fc1d6f99a367c39e95fde23160d9923b
Bug-Url: https://bugzilla.redhat.com/1233194
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42745
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24ce4b86fc1d6f99a367c39e95fde23160d9923b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: aaa: built-in: rename sys props to match tool
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: built-in: rename sys props to match tool
......................................................................
aaa: built-in: rename sys props to match tool
Change-Id: I59820a63485d0f95190a843daa9801601761e0d9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java
M packaging/bin/engine-manage-domains.sh
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Moti Asayag: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59820a63485d0f95190a843daa9801601761e0d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: support quota for snapshot with cinder disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: support quota for snapshot with cinder disks
......................................................................
core: support quota for snapshot with cinder disks
Set quotaId on CreateCinderSnapshotCommand.
Change-Id: Ic8dd58319c415bb8d4fa357066ea3d357663dd0b
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42776
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8dd58319c415bb8d4fa357066ea3d357663dd0b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in otopi[master]: miniyum: Do not emit errors if ignoreErrors
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: miniyum: Do not emit errors if ignoreErrors
......................................................................
miniyum: Do not emit errors if ignoreErrors
Change-Id: I43afe46ad17fbcde4627ee1f6d5c95d0b53d38a5
Bug-Url: https://bugzilla.redhat.com/1224799
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/otopi/miniyum.py
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/42809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43afe46ad17fbcde4627ee1f6d5c95d0b53d38a5
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: uutils: cli: support substitutions for usage and default values
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: uutils: cli: support substitutions for usage and default values
......................................................................
uutils: cli: support substitutions for usage and default values
1. global generic substitutions.
2. local argument substitutions: @CLI_PRM_DEFAULT@, @CLI_PRM_PATTERN@.
Change-Id: I75969f6f3ab5fdc9ff2ee3eae9df137731d3197d
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java
M backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java
M backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/arguments.properties
M backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/logger/arguments.properties
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java
M backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/cryptotool/Main.java
M backend/manager/tools/src/main/resources/org/ovirt/engine/core/cryptotool/arguments.properties
10 files changed, 112 insertions(+), 75 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Ondra Machacek: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75969f6f3ab5fdc9ff2ee3eae9df137731d3197d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: webadmin: fix disks layout when quota is enabled
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fix disks layout when quota is enabled
......................................................................
webadmin: fix disks layout when quota is enabled
Fix layout of disks list when quota is enabled for
add vm/template/pool and move/copy disks.
Change-Id: I4f981d9ba9285928f4559cd292aa4720c6716066
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java
7 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/42723
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f981d9ba9285928f4559cd292aa4720c6716066
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months