June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin,engine : fix geo-rep issues
by vszocs＠redhat.com 24 Jun '15

24 Jun '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,engine : fix geo-rep issues ...................................................................... webadmin,engine : fix geo-rep issues This patch fixes the following: 1. Fix column width for long geo-rep config descriptions makes use of ScrollableTextCell. 2. Defaults use_meta_volume to false (changing the order of allowed options as false;true) so that when user wants to set it to true the change is detected by UI as an attempt to set/reset an option.UI assumes the selection to be the first element in list if explictly selectedItem is not passed This appears as supposed be UI fix. But, a. the configs are set as a list in the table So, conditional handling of only this element in list correspoding to the table might not be a better idea. 3. Refactored geo-rep crawl status enum as per current geo-rep session status o/p.Earlier cli used to return Changelog_Crawl and now its changed to Changelog Crawl. 4. Fix UI NPE in updating geo-rep config occuring during new changes detection.This started appearing after introducing the changes to the query to display even those configs that were not listed by cli as the user has no other option to set/ reset them. With this change in query the UI would catch NPE as the set of configs not shown by cli have null value against the config key and during comparison to detect change, NPE used to occur. 5. Fix availability of remove session when session is anything other than Stopped. 6. If the config is reset from cli or from engine, and sync of config is attempted, some of them don't appear in the config list(if the config doesn't have a value), such configs' value need to be reset from db as well. Change-Id: Ie0bb13c54649ce2980e15b36ed363161b8ab679e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232611 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233165 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232699 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233171 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java A packaging/dbscripts/upgrade/03_06_1630_update_config_option.sql 9 files changed, 55 insertions(+), 24 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests anmolbabu: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0bb13c54649ce2980e15b36ed363161b8ab679e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: Fix saved reports path
by sradco＠redhat.com 24 Jun '15

24 Jun '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Fix saved reports path ...................................................................... packaging: setup: Fix saved reports path Bug-Url: https://bugzilla.redhat.com/1224889 Change-Id: I26e4072f065ad1c8bb2ba4e6d94f67315000cbc8 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/42634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26e4072f065ad1c8bb2ba4e6d94f67315000cbc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: bin: add an option to enforce jboss home
by sbonazzo＠redhat.com 24 Jun '15

24 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: bin: add an option to enforce jboss home ...................................................................... packaging: bin: add an option to enforce jboss home this is required for setup time use of tools which requires the correct jboss home before transaction was committed. Change-Id: I99de947dc660dfa335d32aadace0ef9c38b67f52 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-prolog.sh.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99de947dc660dfa335d32aadace0ef9c38b67f52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Added VM_PAUSED event
by ofrenkel＠redhat.com 24 Jun '15

24 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Added VM_PAUSED event ...................................................................... core: Added VM_PAUSED event Added VM_PAUSED event that is logged when VM goes to the paused state. User may subscribe to this event to be notified every time a VM is paused. Change-Id: I3f64d892f44a2cdfe8eccadfcd34e591fb4e06d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1228257 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 6 files changed, 14 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f64d892f44a2cdfe8eccadfcd34e591fb4e06d1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add support for WildFly
by oourfali＠redhat.com 24 Jun '15

24 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add support for WildFly ...................................................................... core: Add support for WildFly 1. Removes compatibility with JBoss 7, only patched WildFly 8+ and JBoss EAP 6.4 are supported platforms 2. Adds detection of provided AS version (WildFly 8+ or EAP 6.4+) and provides content of service configuration file ovirt-engine.xml.in based on detected version during ovirt-engine service startup. 3. Adds dependency on ovirt-engine-wildfly and ovirt-engine-wildfly-overlay packages 4. Enables oVirt engine to use OpenJDK 1.8 (both EAP 6.4 and WildFly 8 supports OpenJDK >= 1.7) 5. Disables linking jar libraries contained in WEB-INF/lib due to WildFly bug https://issues.jboss.org/browse/WFLY-4382 6. Updates README.developer with WildFly installation notes Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Bug-Url: https://bugzilla.redhat.com/1121327 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M README.developer M ovirt-engine.spec.in M packaging/services/ovirt-engine/ovirt-engine.py M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/setup/ovirt_engine_setup/engine_common/config.py.in M packaging/setup/ovirt_engine_setup/engine_common/constants.py 7 files changed, 363 insertions(+), 38 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Reformat ovirt-engine.xml.in
by oourfali＠redhat.com 24 Jun '15

24 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Reformat ovirt-engine.xml.in ...................................................................... core: Reformat ovirt-engine.xml.in Reformats ovirt-engine.xml.in to make it more readable and ease adding changes to support WildFly. Change-Id: I7b4269fc4f8bf99366f76c0201c0fe9e28f974a9 Bug-Url: https://bugzilla.redhat.com/1121327 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 90 insertions(+), 44 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b4269fc4f8bf99366f76c0201c0fe9e28f974a9 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix CDI in dal module to work with EAP/WildFly
by oourfali＠redhat.com 24 Jun '15

24 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix CDI in dal module to work with EAP/WildFly ...................................................................... core: Fix CDI in dal module to work with EAP/WildFly 1. Removes infra for injecting beans from external JARs introduced in I3b3c2c57178b5df4f98b4191ac9a06f9129414d0, because it's incompatible with WildFly 8+. 2. Adds beans.xml into dal module to allow automatic beans discovery. 3. Adds weld:scan extension configuration into beans.xml to prevent CDI 1.0 ambiguity error between constructor of PostgresDbEngineDialect and producer method DbFacadeLocator.produceDbEngineDialect() during automatic beans discovery. Change-Id: I122b02f846cfbb9b861d13792790cf93ca7ee0d6 Bug-Url: https://bugzilla.redhat.com/1121327 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml D backend/manager/dependencies/common/src/main/modules/org/deltaspike/main/module.xml D backend/manager/dependencies/common/src/main/modules/org/reflections/main/module.xml M backend/manager/modules/bll/pom.xml D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java D backend/manager/modules/bll/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml A backend/manager/modules/dal/src/main/resources/META-INF/beans.xml M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml A backend/manager/modules/utils/src/main/resources/META-INF/beans.xml M ear/src/main/resources/META-INF/MANIFEST.MF M pom.xml 12 files changed, 62 insertions(+), 151 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I122b02f846cfbb9b861d13792790cf93ca7ee0d6 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Changing the nightly job to use new node builders
by tlitovsk＠redhat.com 24 Jun '15

24 Jun '15

Anatoly Litovsky has submitted this change and it was merged. Change subject: Changing the nightly job to use new node builders ...................................................................... Changing the nightly job to use new node builders Change-Id: I04244eea904ea114a339ecd856f9259a35e626e5 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Ryan Barry: Looks good to me Anatoly Litovsky: Verified; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/42756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04244eea904ea114a339ecd856f9259a35e626e5 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: autoinstall: Drop reading /var/log/message
by dougsland＠redhat.com 24 Jun '15

24 Jun '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: autoinstall: Drop reading /var/log/message ...................................................................... autoinstall: Drop reading /var/log/message This patch replaces the schema of reading kargs params from /var/log/messages in favor of use /etc/default/ovirt. All karg parms used are stored in /etc/default/ovirt with the prefix OVIRT_. Change-Id: Icc4e25584947b16916169a51bc2ca83d05ba7562 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/42434 Continuous-Integration: Jenkins CI --- M autoinstall/ovirt-node-plugin-vdsm-autoreg M src/engine_page.py 2 files changed, 191 insertions(+), 220 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4e25584947b16916169a51bc2ca83d05ba7562 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:Code is sensitive to spring JDBC impl
by emesika＠redhat.com 23 Jun '15

23 Jun '15

Eli Mesika has submitted this change and it was merged. Change subject: core:Code is sensitive to spring JDBC impl ...................................................................... core:Code is sensitive to spring JDBC impl Using Collection rather than ArrayList since spring JDBC may return LinkedList depends of version used Change-Id: Ie6b1a88e0fcb4667ab294533ae40eebd26b17894 Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6b1a88e0fcb4667ab294533ae40eebd26b17894 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0