Change in ovirt-engine[master]: restapi: add quota mode to data center
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: restapi: add quota mode to data center
......................................................................
restapi: add quota mode to data center
Expose data center's quota mode (enable/disable/audit).
The enum was added to capabilities (since 3.2).
Change-Id: I543068d6207e6cb31a2232616a8187770c7432bc
Bug-Url: https://bugzilla.redhat.com/893927
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QuotaModeType.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/DataCenterValidator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DataCenterMapperTest.java
6 files changed, 103 insertions(+), 5 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I543068d6207e6cb31a2232616a8187770c7432bc
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core:Added affinity Group collision validation.
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core:Added affinity Group collision validation.
......................................................................
core:Added affinity Group collision validation.
CRUD Affinity Group Command's validateParameters() now have a test
that checks for affinity rules collision, To prevent the user from
creating problematic Affinity Rules in the first place.
Change-Id: I56c483023ed14e238c8a67ec0890812158ecd0b2
Bug-Url: https://bugzilla.redhat.com/1057531
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 94 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56c483023ed14e238c8a67ec0890812158ecd0b2
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: uicommonweb: Attach virtual IDE disks new behavior
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
......................................................................
uicommonweb: Attach virtual IDE disks new behavior
When a user tries to hot plug an IDE disk, he gets an error message
after the operation completes, telling him that an IDE disk cannot be
hot plugged. However, the disk is also not attached to the VM.
This patch introduces a new approach:
If the "Activate" check box is checked, a warning is shown if at least
one IDE disk is selected from the Images/LUNs list. The warning tells
the user that the disk will be attached but not activated, and that he
should activate manually after the VM is shut down.
In addition, a new tooltip was added to the "Activate" check box,
explaining that only non IDE disks are activated after attached.
Change-Id: I187c74c7c39f438dfa5e81942f4a6aec41323830
Bug-Url: https://bugzilla.redhat.com/1167248
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/BaseVmDiskAttachPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/BaseVmDiskAttachPopupView.java
7 files changed, 155 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38663
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I187c74c7c39f438dfa5e81942f4a6aec41323830
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: CoCoAsyncTaskHelper: do not clear command if the parent has ...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: CoCoAsyncTaskHelper: do not clear command if the parent has callback
......................................................................
CoCoAsyncTaskHelper: do not clear command if the parent has callback
If the parent (=root) command has a callback, it should be clearing it's
child commands entities - otherwise it has no way to track wether their
execution was succesful or not.
Change-Id: I2f939ebbb498a2ef7c0afd32acf75ba6cc37e301
Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
1 file changed, 21 insertions(+), 14 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f939ebbb498a2ef7c0afd32acf75ba6cc37e301
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-hosted-engine-ha[master]: removing service condition on vm.conf
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: removing service condition on vm.conf
......................................................................
removing service condition on vm.conf
The agent will dinamically load vm.conf from the shared
storage domain so it will not be present anywhere on
the first run on additional hosts.
Change-Id: I3c6d0b1af437d7d0b2f9364493ad1c9b4533fbe7
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M initscripts/ovirt-ha-agent.service
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/42389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c6d0b1af437d7d0b2f9364493ad1c9b4533fbe7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: moving vm.conf to /var/run
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: moving vm.conf to /var/run
......................................................................
packaging: setup: moving vm.conf to /var/run
The local filesystem vm.conf it's now just a temporary instance,
the master version is on the shared storage domain.
Moving it to /var/run
Change-Id: I14957bc5e7511842f2c86f7ec55470ad0ae6ce24
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
3 files changed, 19 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14957bc5e7511842f2c86f7ec55470ad0ae6ce24
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: removing local broker.conf
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: removing local broker.conf
......................................................................
packaging: setup: removing local broker.conf
After https://gerrit.ovirt.org/#/c/42209/ the broker is also
able to get broker.conf from the storage domain.
Removing the local filesystem instance
Change-Id: If8794c5754010cd276cc7d69dd7ac9cc836d11a8
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/core/conf.py
M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py
M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py
4 files changed, 8 insertions(+), 32 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8794c5754010cd276cc7d69dd7ac9cc836d11a8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: host-deploy: support serial console
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: host-deploy: support serial console
......................................................................
host-deploy: support serial console
Change-Id: I4692f73dc388794ed0b3e1ee8732f2916d9591d2
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/firewalld/aio/ovirt-aio.xml.in
5 files changed, 125 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, but someone else must approve
Francesco Romani: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4692f73dc388794ed0b3e1ee8732f2916d9591d2
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-hosted-engine-ha[master]: loading broker.conf and vm.conf from the shared storage
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: loading broker.conf and vm.conf from the shared storage
......................................................................
loading broker.conf and vm.conf from the shared storage
broker.conf and vm.conf are now on the shared storage and not
replicated on each host local filesystem.
Extracting them from there to a local cached copy refreshed
when needed.
Being temporary cache copy they are now placed under
/var/ instead of under /etc/
Change-Id: Ia6a1a6213834f9c8b97834ebd95456fac2ca224d
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M initscripts/ovirt-ha-agent.init.in
M initscripts/ovirt-ha-broker.init.in
M ovirt-hosted-engine-ha.spec.in
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/agent/state_machine.py
M ovirt_hosted_engine_ha/broker/constants.py.in
M ovirt_hosted_engine_ha/broker/notifications.py
M ovirt_hosted_engine_ha/env/config.py
M ovirt_hosted_engine_ha/env/constants.py.in
10 files changed, 125 insertions(+), 37 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6a1a6213834f9c8b97834ebd95456fac2ca224d
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: log the selected storage domain for memory volumes
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: log the selected storage domain for memory volumes
......................................................................
core: log the selected storage domain for memory volumes
This patch adds an info log for the storage domain that was selected to
store the vm's memory volumes.
Change-Id: I8c06e7eaa880c690ef2926b7d41155baaf24518d
Bug-Url: https://bugzilla.redhat.com/1186230
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java
4 files changed, 18 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/42143
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c06e7eaa880c690ef2926b7d41155baaf24518d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months