June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "core: Make VDS a JPA entity"
by oourfali＠redhat.com 16 Jun '15

16 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: Revert "core: Make VDS a JPA entity" ...................................................................... Revert "core: Make VDS a JPA entity" This reverts commit 03ecd690241e302289b3da9337da93ac58b19a6e. Change-Id: I8fb4e9a1434fa8a85455afb8caf7464f20cf779c Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java M backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CpuStatistics.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeCpuMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeStatistics.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeVmVds.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/DistanceUserType.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/GuidGenerator.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStatisticsDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java M backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NumaUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java M packaging/dbscripts/numa_sp.sql M packaging/dbscripts/vds_sp.sql 46 files changed, 2,640 insertions(+), 1,430 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb4e9a1434fa8a85455afb8caf7464f20cf779c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Revert "core: Fix adding host with JPA"
by oourfali＠redhat.com 16 Jun '15

16 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: Revert "core: Fix adding host with JPA" ...................................................................... Revert "core: Fix adding host with JPA" This reverts commit ab24bc9f64ee36e8c52bdf8e5d6d773c6abab57c. Change-Id: Idf0380029586898a4eeb6607d319f85e5f1ee9c5 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf0380029586898a4eeb6607d319f85e5f1ee9c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: KSM enabled checkbox alway start unchecked
by gchaplik＠redhat.com 16 Jun '15

16 Jun '15

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: KSM enabled checkbox alway start unchecked ...................................................................... webadmin: KSM enabled checkbox alway start unchecked Problem: KSM enablement checkbox always start unchecked. Solution: Remove default disablment in version compatability handling Change-Id: I1e40cfb58b9510042c49f7617f01148b63ef79c9 Bug-Url: https://bugzilla.redhat.com/840114 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Dudi Maroshi: Verified Gilad Chaplik: Looks good to me, approved Objections: Jenkins CI: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/42410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e40cfb58b9510042c49f7617f01148b63ef79c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm_create_libgfapi sync
by sbonazzo＠redhat.com 16 Jun '15

16 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm_create_libgfapi sync ...................................................................... vdsm_create_libgfapi sync - dropped Fedora 20 builds not supported anymore by vdsm on master - dropped merged patch refs/changes/37/36237/1 from cherry-pick list Change-Id: I31304763706a299c89ac8cf99a3973415123ae01 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/vdsm/vdsm_create_libgfapi-rpms.yaml 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Verified; Looks good to me; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31304763706a299c89ac8cf99a3973415123ae01 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add timestamp for vm-dynamic updates
by ofrenkel＠redhat.com 16 Jun '15

16 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: add timestamp for vm-dynamic updates ...................................................................... core: add timestamp for vm-dynamic updates added a timestamp in VmManager that save the time vm information updated. this is updated by consumers of the VmManager.lock object, and used by VmsMonitoring, which gets vm data at a time and lock at a different time - using this timestamp, monitoring cycle of 'dirty' vm can be skipped. Change-Id: If858993450cf957babdcf337e9b7867a282657bc Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ManagingVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java 5 files changed, 50 insertions(+), 16 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If858993450cf957babdcf337e9b7867a282657bc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5.4-1
by sradco＠redhat.com 16 Jun '15

16 Jun '15

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5.4-1 ...................................................................... build: post ovirt-engine-dwh-3.5.4-1 Change-Id: I119fbec5d70a52b67058315757ad63fe5143fb91 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I119fbec5d70a52b67058315757ad63fe5143fb91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: ovirt-engine-dwh-3.5.4-1
by sradco＠redhat.com 16 Jun '15

16 Jun '15

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5.4-1 ...................................................................... build: ovirt-engine-dwh-3.5.4-1 Added released notes. Change-Id: I2d2489a44e269d1971067095ffd484e18062b17e Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d2489a44e269d1971067095ffd484e18062b17e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: reset page to 1 on sort
by oourfali＠redhat.com 16 Jun '15

16 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: reset page to 1 on sort ...................................................................... reset page to 1 on sort webadmin: reset page to 1 on sort - In the scenario where you have multiple pages and you select and item, it is possible for a sort operation to make the selected item unavailable on the current page. This leaves the user on a page that is no longer of interest to them. So to not confuse the user too much we will reset the page to the first page when sorting. Change-Id: I0b0a974c65c261081f1c942b2b35e75e806a86a6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223770 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 2 files changed, 26 insertions(+), 53 deletions(-) Approvals: Eli Mesika: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b0a974c65c261081f1c942b2b35e75e806a86a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_...
by emesika＠redhat.com 16 Jun '15

16 Jun '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id ...................................................................... core: Fix Dead Locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id Customer got dead locks in Updatedisk_image_dynamic_by_disk_id_and_vm_id. This patch sorts by GUID, so that we eliminate the option for deadlocks. Change-Id: Ieeba728a0a549e845b5355748e15b00d02381256 Bug-Url: https://bugzilla.redhat.com/1198674 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit https://gerrit.ovirt.org/42403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeba728a0a549e845b5355748e15b00d02381256 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix non-responding logging in case of no PM
by emesika＠redhat.com 16 Jun '15

16 Jun '15

Eli Mesika has submitted this change and it was merged. Change subject: core: fix non-responding logging in case of no PM ...................................................................... core: fix non-responding logging in case of no PM This patch fixes the messages written to application log and to the audit log in the case that the host is non-responsive but does not have any configured power management. Change-Id: I1f7e7a9987be93023309c0b25f35d856d2ec1f04 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1175290 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 3 files changed, 18 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7e7a9987be93023309c0b25f35d856d2ec1f04 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0