June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: let the user configure the appliance vCPU ...
by sbonazzo＠redhat.com 16 Jun '15

16 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: let the user configure the appliance vCPU value ...................................................................... packaging: setup: let the user configure the appliance vCPU value Deploying the appliance: - honouring OVEHOSTED_VM/vmVCpus from answerfile if not interactive - ask using the OVF value as the default otherwise Change-Id: Iee514e9066d69852a60e606a93f6a59e23e26c87 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/cpu.py 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee514e9066d69852a60e606a93f6a59e23e26c87 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Allow simultaneous add of gluster host
by tnisan＠redhat.com 16 Jun '15

16 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Allow simultaneous add of gluster host ...................................................................... engine: Allow simultaneous add of gluster host If multiple hosts are being provisioned using Foreman and being added to the cluster, then this should be allowed The peer probe of hosts to the cluster, will happen when the host finished installation and first moves to UP state Change-Id: I3f1f81c90d2ec727159a2ed4d147a0acffd60ab9 Bug-Url: https://bugzilla.redhat.com/1142779 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/41861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f1f81c90d2ec727159a2ed4d147a0acffd60ab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix adding host with JPA
by oourfali＠redhat.com 16 Jun '15

16 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix adding host with JPA ...................................................................... core: Fix adding host with JPA Adding host with JPA was broken. This patch fixes it. Change-Id: I5ab39faf401651774887aa0bf4096d433d97e8d2 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ab39faf401651774887aa0bf4096d433d97e8d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: VM configuration should not be validated in Export Domain
by mlipchuk＠redhat.com 16 Jun '15

16 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: VM configuration should not be validated in Export Domain ...................................................................... core: VM configuration should not be validated in Export Domain Validating a VM if its disks exists in the Export Domain should be only for a VM in Export Domain since a VM from configuration is already being validated for disks existence in ImportVmFromConfiguration. Change-Id: Iffde1e02cfa9c1c104f1f7057fb4218c44da599b Bug-Url: https://bugzilla.redhat.com/1231849 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 2 files changed, 18 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffde1e02cfa9c1c104f1f7057fb4218c44da599b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: adding prepareImage to the connectStorage cmd
by sbonazzo＠redhat.com 16 Jun '15

16 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: adding prepareImage to the connectStorage cmd ...................................................................... packaging: setup: adding prepareImage to the connectStorage cmd Now VDSM explictly needs prepareImage to be called to made the image availables. Adding it. Change-Id: Ia01b5cde784ff9589cad2e7ef025c839f3fd49d3 Bug-Url: https://bugzilla.redhat.com/1215967 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/bin/hosted-engine.in M src/plugins/ovirt-hosted-engine-setup/core/conf.py M templates/hosted-engine.conf.in 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01b5cde784ff9589cad2e7ef025c839f3fd49d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Update VmPool - Identify Template by name.
by oliel＠redhat.com 16 Jun '15

16 Jun '15

Ori Liel has submitted this change and it was merged. Change subject: restapi: Update VmPool - Identify Template by name. ...................................................................... restapi: Update VmPool - Identify Template by name. When updating a Vm-Pool, if user provides the template name (vs ID), the action currently fails. This patch infers the Template ID using the Template name before sending the request to the engine. Change-Id: Ie807569c42d956630f8a7a0c5f868bd50559300a Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie807569c42d956630f8a7a0c5f868bd50559300a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make VDS a JPA entity
by oourfali＠redhat.com 16 Jun '15

16 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Make VDS a JPA entity ...................................................................... core: Make VDS a JPA entity Make VDS a JPA entity Change-Id: I5d7aa140e20dcd9468ae1ed00af1df0cf3e8b9e6 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java M backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CpuStatistics.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeCpuMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeStatistics.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeVmVds.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNumaNode.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/DistanceUserType.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/GuidGenerator.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStatisticsDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java M backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NumaUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java M packaging/dbscripts/numa_sp.sql M packaging/dbscripts/vds_sp.sql 46 files changed, 1,430 insertions(+), 2,640 deletions(-) Approvals: Liran Zelkha: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d7aa140e20dcd9468ae1ed00af1df0cf3e8b9e6 Gerrit-PatchSet: 62 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix NPE in EditAffinityGroupCommandTest
by dfediuck＠redhat.com 15 Jun '15

15 Jun '15

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix NPE in EditAffinityGroupCommandTest ...................................................................... core: Fix NPE in EditAffinityGroupCommandTest Change-Id: I935213777e6c45471272d22c255eeef6a217b729 Bug-Url: https://bugzilla.redhat.com/1057531 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/EditAffinityGroupCommandTest.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/42398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I935213777e6c45471272d22c255eeef6a217b729 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: implement Quota REST-API
by dfediuck＠redhat.com 15 Jun '15

15 Jun '15

Doron Fediuck has submitted this change and it was merged. Change subject: restapi: implement Quota REST-API ...................................................................... restapi: implement Quota REST-API adding quota element to REST-API: Quota is a subcollection of Data Center and consists limits for consuming cluster (# of vcpus, memory(GB)) and storage (size (GB)) resources. Quota entity: - data_center - link to DC - soft and hard thresholds (in percentage), grace and threshould in UI. - Quota sub collections: QuotaStorageLimit entity - storage_domain - link to specific storage domain, no link means it's a single global limit for all SD in DC - limit- the actual limit in GB (-1 unlimited) - usage- current usage of the limit QuotaClusterLimit entity - cluster - link to specific cluster, no link means it's a single global limit for all cluster in DC - vcpu_limit - limit for vcpus (-1 unlimited) - vcpu_usage - current usage of vcpus - memroy_limit - limit for memory (in GB) - memory_usage - current usage of memroy - Permissions Change-Id: Ifaead35839c2c5f89f1551e67e58a58aa253cab5 Bug-Url: https://bugzilla.redhat.com/893927 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaClusterLimitResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaClusterLimitsResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaLimitResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaLimitsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaStorageLimitResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaStorageLimitsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotasResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotasResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotasResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QuotaMapper.java 24 files changed, 1,163 insertions(+), 28 deletions(-) Approvals: Ori Liel: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit https://gerrit.ovirt.org/39904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaead35839c2c5f89f1551e67e58a58aa253cab5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Quota API engine fixups
by dfediuck＠redhat.com 15 Jun '15

15 Jun '15

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Quota API engine fixups ...................................................................... engine: Quota API engine fixups Since quota was added only via UI till now, some bugs were masked and now smoked out: - Set default values for quota grace and threshold (hard/soft limits). - Enable javax.validation annotations for Quata entity. - Return quota UUID when creating quota (setActionReturnValue). - Fix Error message. - Fix UI's NPEs incase only memory/cpu is defined Change-Id: I51a7e9430c7c494a1608578e1f50e27c0e8a79ad Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/QuotaCRUDParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 64 insertions(+), 9 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit https://gerrit.ovirt.org/39903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51a7e9430c7c494a1608578e1f50e27c0e8a79ad Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0