Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Pass username for non-root geo-rep session sync
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Pass username for non-root geo-rep session sync
......................................................................
engine: Pass username for non-root geo-rep session sync
This patch fixes the previously occuring problem of
unknown session status occuring while syncing non-root
geo-rep session by passing the user name optional
parameter.
Change-Id: I3a51bc0cdbb2a96a396f31cade4587d7154329f4
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42336
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a51bc0cdbb2a96a396f31cade4587d7154329f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: engine: Pass username for non-root geo-rep session sync
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Pass username for non-root geo-rep session sync
......................................................................
engine: Pass username for non-root geo-rep session sync
This patch fixes the previously occuring problem of
unknown session status occuring while syncing non-root
geo-rep session by passing the user name optional
parameter.
Change-Id: I3a51bc0cdbb2a96a396f31cade4587d7154329f4
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
anmolbabu: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a51bc0cdbb2a96a396f31cade4587d7154329f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Pass username to geo-rep config list
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Pass username to geo-rep config list
......................................................................
engine: Pass username to geo-rep config list
Earlier passing username to GeoRep Config List command
was missed out accidentally and hence during sync config
of non-root sessions weren't updated to db.
This patch fixes it.
Change-Id: Id9bb464d152eec066a8c160a6691c758b5516ceb
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42329
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9bb464d152eec066a8c160a6691c758b5516ceb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin, engine : Error handling in geo-rep create
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin, engine : Error handling in geo-rep create
......................................................................
webadmin, engine : Error handling in geo-rep create
The failure message of a command will be set in
1. canDoAction failure
FrontendActionAsyncResult#getReturnValue#getCanDoActionMessages
2. Command failure from Vds
FrontendActionAsyncResult#getReturnValue#getFault#getMessage
3. UI error handling assumed the only source of error to be 2
1, 2 and 3 necessiated to allow UI framework to handle erroneous
conditions as it is capable of doing this conditional handling
as in Frontend#handleActionResult
Along with the above there was an error in propogation of error
from internal commands to the command invoking them and hence
removed error handling from internal commands and propogated(using
CommandBase#propagateFailure)them to the command utilising them.
Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230353
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHostPubKeyToSlaveInternalCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
6 files changed, 68 insertions(+), 42 deletions(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42325
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: CloneCinderDisks - handle command statuses
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: CloneCinderDisks - handle command statuses
......................................................................
core: CloneCinderDisks - handle command statuses
* Handle NOT_STARTED and SUCCEEDED command statuses on
CloneCinderDisksCommandCallback.
* Set parent command and parameters in CloneCinderDisksCommand.
Change-Id: I6f4adecd6289920581857c444d89684f91ed4ae2
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f4adecd6289920581857c444d89684f91ed4ae2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-dwh[ovirt-engine-dwh-3.5]: history: change date format in aggregation
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: history: change date format in aggregation
......................................................................
history: change date format in aggregation
Format lastDayAggr and lastHourAggr timezones
in the aggregation queries, as digits and not as text.
Change-Id: Iccea6549958c68c7e3d2e17853e9648bc28b258a
Bug-Url:https://bugzilla.redhat.com/1228974
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/aggregationtodaily_3_5/AggregationToDaily.java
M etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_5/AggregationToHourly.java
M etl_export/src/ovirt_engine_dwh/configurationsync_3_5/ConfigurationSync.java
M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_5/DailyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_5/DeleteTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/historydelete_3_5/HistoryDelete.java
M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_5/HourlyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/parallelrun_3_5/ParallelRun.java
M etl_export/src/ovirt_engine_dwh/sampletimekeepingjob_3_5/SampleTimeKeepingJob.java
M etl_export/src/routines/RoutineHistoryETL.java
M tos_project/code/routines/RoutineHistoryETL_3.5.item
M tos_project/code/routines/RoutineHistoryETL_3.5.properties
M tos_project/process/AggregationToDaily_3.5.item
M tos_project/process/AggregationToDaily_3.5.properties
M tos_project/process/AggregationToHourly_3.5.item
M tos_project/process/AggregationToHourly_3.5.properties
M tos_project/process/ConfigurationSync_3.5.item
M tos_project/process/ConfigurationSync_3.5.properties
M tos_project/process/DailyTimeKeepingJob_3.5.item
M tos_project/process/DailyTimeKeepingJob_3.5.properties
M tos_project/process/DeleteTimeKeepingJob_3.5.item
M tos_project/process/DeleteTimeKeepingJob_3.5.properties
M tos_project/process/HistoryDelete_3.5.item
M tos_project/process/HistoryDelete_3.5.properties
M tos_project/process/HourlyTimeKeepingJob_3.5.item
M tos_project/process/HourlyTimeKeepingJob_3.5.properties
M tos_project/process/ParallelRun_3.5.item
M tos_project/process/ParallelRun_3.5.properties
M tos_project/process/SampleTimeKeepingJob_3.5.item
M tos_project/process/SampleTimeKeepingJob_3.5.properties
30 files changed, 359 insertions(+), 566 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42015
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccea6549958c68c7e3d2e17853e9648bc28b258a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: validator - include range as constraint message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: validator - include range as constraint message
......................................................................
core: validator - include range as constraint message
when using a @ConfiguredRange it is best to include in the CDA message
the actual range that was used and this patch add a constraint
violations message - which is interpolated on as a CDA variable to use
so now use ${range} in your AppErrors messages
SOME_RANGE_ERROR=input out of range ${range}
Bug-Url: https://bugzilla.redhat.com/1220110
Change-Id: Icc8813288958fdc9a66548c3a013a928d370e28c
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ConfiguredRangeValidator.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc8813288958fdc9a66548c3a013a928d370e28c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: Adding external status to UI
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin: Adding external status to UI
......................................................................
webadmin: Adding external status to UI
This patch actually displays the external status icon in the storage
domain main view.
Change-Id: I569130b66dadbcdce1cd32a5cd8a2a8d7a3501cb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainAdditionalStatusColumn.java
2 files changed, 56 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I569130b66dadbcdce1cd32a5cd8a2a8d7a3501cb
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: REST API: Adding external status to API
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: REST API: Adding external status to API
......................................................................
REST API: Adding external status to API
This patch adds handling the external_status field from the external
event API call
Change-Id: I4d748b1123c4dafc7776d79097eec8e94793bf1d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/EventValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StorageDomainValidator.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ExternalStatusMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
8 files changed, 96 insertions(+), 53 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Eli Mesika: Verified
--
To view, visit https://gerrit.ovirt.org/42137
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d748b1123c4dafc7776d79097eec8e94793bf1d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core[Search]:Add search support to external_status
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core[Search]:Add search support to external_status
......................................................................
core[Search]:Add search support to external_status
This patch adds ability to search in the storage domain view by the new
external_status field
Change-Id: Ie0cf461939344b86ad3567c950dba3dc3585929e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Allon Mureinik: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0cf461939344b86ad3567c950dba3dc3585929e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months