Change in ovirt-engine[master]: core: Use generics in CloneCinderDisksCommandCallback
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use generics in CloneCinderDisksCommandCallback
......................................................................
core: Use generics in CloneCinderDisksCommandCallback
Use generics for CloneCinderDisksCommandCallback to be used also for
preview cinder snapshot.
Change-Id: I60b0b50dcc9e0672168b2ae17924f11fb121f618
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/42253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60b0b50dcc9e0672168b2ae17924f11fb121f618
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: delete Cinder volumes should be surrounded by try catch.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: delete Cinder volumes should be surrounded by try catch.
......................................................................
core: delete Cinder volumes should be surrounded by try catch.
Delete of volume and snapshot from CinderBroker should return a
notification whether it succeeded or not, and should be surrounded with
try catch block to prevent exception when the volume does not exists.
Change-Id: I01811c092f72d8f5409866f308ea7b3c5cfb3ff0
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
1 file changed, 24 insertions(+), 10 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/42252
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01811c092f72d8f5409866f308ea7b3c5cfb3ff0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: add VolumeClassification to DiskImageDAODbFacadeImpl
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: add VolumeClassification to DiskImageDAODbFacadeImpl
......................................................................
core: add VolumeClassification to DiskImageDAODbFacadeImpl
add VolumeClassification to the mapper when fetching disk image from the DB.
Change-Id: I62e139790a4b19e308887cb444e11d1551138d06
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/42251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62e139790a4b19e308887cb444e11d1551138d06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: Add KSM awaremess for NUMA optimization
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: Add KSM awaremess for NUMA optimization
......................................................................
webadmin: Add KSM awaremess for NUMA optimization
Add GUI to manage the KSM policy for NUMA at cluster level.
The simple radio button GUI functionality is describe in here:
http://www.ovirt.org/NumaAwareKsmSupport
Change-Id: I28bf4a0263566d617c2cbb356275d06729121f93
Bug-Url: https://bugzilla.redhat.com/840114
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
5 files changed, 133 insertions(+), 6 deletions(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Gilad Chaplik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42156
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28bf4a0263566d617c2cbb356275d06729121f93
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: engine: Add KSM awaremess for NUMA optimization
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add KSM awaremess for NUMA optimization
......................................................................
engine: Add KSM awaremess for NUMA optimization
Add boolean field to cluster table reflecting KSM policy for NUMA.
Bug-Url: https://bugzilla.redhat.com/840114
Change-Id: I464542fd7a25ccb230ab22f45686dd3c22b394a6
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/upgrade/03_06_1570_add_ksm_with_numa_awareness.sql
M packaging/dbscripts/vds_groups_sp.sql
5 files changed, 36 insertions(+), 6 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39777
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I464542fd7a25ccb230ab22f45686dd3c22b394a6
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-node-plugin-vdsm[master]: spec: Do not pull vdsm-reg
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: spec: Do not pull vdsm-reg
......................................................................
spec: Do not pull vdsm-reg
Registration is done via vdsm-tool register, no
need to pull vdsm-reg.
Change-Id: I1d9c7511b8830651b55e1d46f701541c08cf7cbd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231379
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42304
Reviewed-by: Jenkins CI
Tested-by: Jenkins CI
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42304
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d9c7511b8830651b55e1d46f701541c08cf7cbd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: packaging: setup: fix pyflakes invalid syntax issue
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fix pyflakes invalid syntax issue
......................................................................
packaging: setup: fix pyflakes invalid syntax issue
Change-Id: Iba304f6cbedbb8d4677c93fbc0b47a28b2e7583d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/dialog.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba304f6cbedbb8d4677c93fbc0b47a28b2e7583d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Added new alerts for brick/volume status changes
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Added new alerts for brick/volume status changes
......................................................................
engine: Added new alerts for brick/volume status changes
adds new alerts for server/volume removed from CLI, updates brick state
change alerts and automatically remove alerts once the entity is UP.
Change-Id: Ibad5ed6078bd33cd9c9decdabca6747709be4ba4
Signed-off-by: Karnan TC <kchidamb(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AuditLogDaoMocker.java
M packaging/dbscripts/audit_log_sp.sql
A packaging/dbscripts/upgrade/03_05_1500_add_brickInfo_audit_log_table.sql
14 files changed, 279 insertions(+), 61 deletions(-)
Approvals:
Karnan t c: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42299
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibad5ed6078bd33cd9c9decdabca6747709be4ba4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: geo-rep config entries
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: geo-rep config entries
......................................................................
engine: geo-rep config entries
This patch fixes the issues of :
1. geo-rep config descriptions being not available
in geo-rep session config list.
2. use_meta_volume not available in config list
Change-Id: I5d1defdf69cb256a2a872a82a5e54dc6abf6d77b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219830
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224697
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepConfigListQuery.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/gluster_georep_sp.sql
A packaging/dbscripts/upgrade/03_05_1490_insert_and_update_config_description.sql
7 files changed, 74 insertions(+), 5 deletions(-)
Approvals:
anmolbabu: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d1defdf69cb256a2a872a82a5e54dc6abf6d77b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Show confirmation for geo-rep actions
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin : Show confirmation for geo-rep actions
......................................................................
webadmin : Show confirmation for geo-rep actions
This patch adds confirmation dialogs for stop, pause
and remove geo-rep sessions.
Change-Id: I319072213021cfd130b4521c0b77e5e4ab9cb1fe
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224893
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepActionConfirmationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepActionConfirmPopUpViewPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.ui.xml
6 files changed, 93 insertions(+), 26 deletions(-)
Approvals:
anmolbabu: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I319072213021cfd130b4521c0b77e5e4ab9cb1fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months