Change in ovirt-engine[master]: core[BLL]: Adding external status to command
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core[BLL]: Adding external status to command
......................................................................
core[BLL]: Adding external status to command
This patch handles the required changes in the AddExternalEventCommand
Change-Id: Ic8b8e3c0f6f54336d8ac1a621e69cd22cb79da80
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8b8e3c0f6f54336d8ac1a621e69cd22cb79da80
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core[DAO]: Adding external status to DAOs
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core[DAO]: Adding external status to DAOs
......................................................................
core[DAO]: Adding external status to DAOs
This patch adds external status handling to the DAOs
Change-Id: I8124d0dc5fa1aa97dde67462d7807f2b3ba60411
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
5 files changed, 33 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8124d0dc5fa1aa97dde67462d7807f2b3ba60411
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core[BE]: Adding external status to BE
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core[BE]: Adding external status to BE
......................................................................
core[BE]: Adding external status to BE
This patch adds the new field to the StorageDomain BE
Change-Id: I2141005b16c7a43009f0f5d422687f24781e402e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
2 files changed, 24 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Allon Mureinik: Looks good to me, approved
Objections:
Jenkins CI: I would prefer that you didn't submit this
--
To view, visit https://gerrit.ovirt.org/42133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2141005b16c7a43009f0f5d422687f24781e402e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core[DB]: Adding external status to DB
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core[DB]: Adding external status to DB
......................................................................
core[DB]: Adding external status to DB
This patch set adds external status for the storage domain entity
The Health Status field will be returned as part of the retrieved entity
when a call to display the entity is done using the REST API.
The main use-case for this new status is to provide plugins / external
systems the ability to trigger issues, and allow the administrator to
clearly see there is an issue through the UI
For more information please see the feature page wiki
http://www.ovirt.org/Features/EntityHealthStatus
Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231274
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/storages_san_sp.sql
A packaging/dbscripts/upgrade/03_06_1580_add_sd_external_status.sql
3 files changed, 20 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: engine: Pass username to geo-rep config list
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Pass username to geo-rep config list
......................................................................
engine: Pass username to geo-rep config list
Earlier passing username to GeoRep Config List command
was missed out accidentally and hence during sync config
of non-root sessions weren't updated to db.
This patch fixes it.
Change-Id: Id9bb464d152eec066a8c160a6691c758b5516ceb
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
anmolbabu: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9bb464d152eec066a8c160a6691c758b5516ceb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: centralized manualSetupDispatcher code
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: centralized manualSetupDispatcher code
......................................................................
packaging: setup: centralized manualSetupDispatcher code
The list of options to manipulate the engine vm is relevant in many parts of
the installation process. This patch moves the options list implementation to
check_liveliness module and uses it in few events. This code is aimed to
be reused on communication errors with the engine vm.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188663
Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/check_liveliness.py
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/engine/health.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
4 files changed, 219 insertions(+), 196 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yaniv Bronhaim: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: backend: engine resolving host's active interface
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: backend: engine resolving host's active interface
......................................................................
backend: engine resolving host's active interface
engine will resolve host's active interface by looking
into vdsGetCapabilities and resolve the top link
layer component that the host uses to communicate
with the engine.
Feature-page: http://www.ovirt.org/Features/ResolveActiveInterface
Change-Id: I64a21595e58358fe9e04ea1de5d3e3115c7bc2c6
Bug-Url: https://bugzilla.redhat.com/1117303
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/network/predicate/InterfaceByAddressPredicate.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/network/predicate/InterfaceByNetworkNamePredicate.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/network/predicate/AbstractVdsNetworkInterfacePredicateTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/network/predicate/VdsNetworkInterfaceByAddressPredicateTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/network/predicate/VdsNetworkInterfaceByNetworkNamePredicateTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
8 files changed, 243 insertions(+), 36 deletions(-)
Approvals:
Eliraz Levi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/35895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64a21595e58358fe9e04ea1de5d3e3115c7bc2c6
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: packaging: license: Corrected the license text
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: license: Corrected the license text
......................................................................
packaging: license: Corrected the license text
Corrected the license text in Makefile
Related-To: https://bugzilla.redhat.com/804367
Change-Id: Ie24e3e0b9d2088a787c01c1b0b9583c77d0324c5
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M Makefile
1 file changed, 4 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie24e3e0b9d2088a787c01c1b0b9583c77d0324c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: handling domain status update
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: handling domain status update
......................................................................
core: handling domain status update
this change handles:
1. changing domain status from PreparingToMaintenance to Maintenance
even if the pools stats aren't being collected using the SPM.
2. in data center with SPM the status of an Unknown domain is changed
based on the pool metadata, in data center without SPM it'll change
based on the domain monitoring.
Change-Id: I18a6f2f65252f4033a90e5dfa29f181dd9ac4a1d
Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 32 insertions(+), 11 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18a6f2f65252f4033a90e5dfa29f181dd9ac4a1d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: webadmin, engine : Error handling in geo-rep create
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin, engine : Error handling in geo-rep create
......................................................................
webadmin, engine : Error handling in geo-rep create
The failure message of a command will be set in
1. canDoAction failure
FrontendActionAsyncResult#getReturnValue#getCanDoActionMessages
2. Command failure from Vds
FrontendActionAsyncResult#getReturnValue#getFault#getMessage
3. UI error handling assumed the only source of error to be 2
1, 2 and 3 necessiated to allow UI framework to handle erroneous
conditions as it is capable of doing this conditional handling
as in Frontend#handleActionResult
Along with the above there was an error in propogation of error
from internal commands to the command invoking them and hence
removed error handling from internal commands and propogated(using
CommandBase#propagateFailure)them to the command utilising them.
Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230353
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHostPubKeyToSlaveInternalCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
5 files changed, 64 insertions(+), 42 deletions(-)
Approvals:
anmolbabu: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42300
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months