June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove unused imports in Cinder commands
by tnisan＠redhat.com 14 Jun '15

14 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused imports in Cinder commands ...................................................................... core: Remove unused imports in Cinder commands Change-Id: Ie47b808785f397dfe0b6f0c7bf8d5130ded62e52 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToAllCinderSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToCinderSnapshotCommand.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie47b808785f397dfe0b6f0c7bf8d5130ded62e52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce TryBackToCinderSnapshotCommand.
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce TryBackToCinderSnapshotCommand. ...................................................................... core: Introduce TryBackToCinderSnapshotCommand. Introduce preview command for single Cinder disk. Change-Id: I532fed7fe11a033c8b86251e5ad8b73230801c2d Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToCinderSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 3 files changed, 148 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I532fed7fe11a033c8b86251e5ad8b73230801c2d Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support preview for Cinder snapshot
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support preview for Cinder snapshot ...................................................................... core: Support preview for Cinder snapshot Adding support for Cinder snapshot. Change-Id: Ia8c7f7a9505ff965b0cded35c395e5bfb8529aaa Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 69 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8c7f7a9505ff965b0cded35c395e5bfb8529aaa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce TryBackToAllCinderSnapshotsCommand
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand ...................................................................... core: Introduce TryBackToAllCinderSnapshotsCommand Introduce new command for previewing all Cinder disks in a VM. Change-Id: I36d1c3278c4d251a15ee42b67d5c9fa8177c0e20 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/TryBackToAllCinderSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 117 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d1c3278c4d251a15ee42b67d5c9fa8177c0e20 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add helper in DiskStorageType enum
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add helper in DiskStorageType enum ...................................................................... core: Add helper in DiskStorageType enum Add isSupportsSnapshot helper method for Cinder and Image disks. Change-Id: I3df843c1ac778ef2fe5c64c6b4c8323a66f2001b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskStorageType.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3df843c1ac778ef2fe5c64c6b4c8323a66f2001b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Refactor updateOldImageAsActive to baseImagesCommand
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Refactor updateOldImageAsActive to baseImagesCommand ...................................................................... core: Refactor updateOldImageAsActive to baseImagesCommand Refactor method updateOldImageAsActive to baseImagesCommand so it can be re-used with TryBackToCinderSnapshotCommand. Change-Id: Idbc3563310cc447de19dedf2c6b5302aff27c8f6 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToSnapshotCommand.java 2 files changed, 25 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc3563310cc447de19dedf2c6b5302aff27c8f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix preview snapshot in Cinder broker
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix preview snapshot in Cinder broker ...................................................................... core: Fix preview snapshot in Cinder broker Unset sourceVolId and set volume type before calling Cinder provider to preview a snapshot. Change-Id: I79dd12b66635c1a0d4ffc052ef17268e6f06763b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79dd12b66635c1a0d4ffc052ef17268e6f06763b Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add type to list at CinderDisksProvider
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add type to list at CinderDisksProvider ...................................................................... core: Add type to list at CinderDisksProvider Add CinderDisk type to cinderDisks list at CinderDisksProvider. Change-Id: I519bca45af9ba2b0cb14bb6263ce19bf869b3fbd Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I519bca45af9ba2b0cb14bb6263ce19bf869b3fbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change clone cinder call back to use container id.
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change clone cinder call back to use container id. ...................................................................... core: Change clone cinder call back to use container id. Use container id insted of destinationid in CloneSingleCinderDiskCommandCallback, so it can be used for preview cinder snapshot. Change-Id: I4d5d9a7efad6658d55be8f39c7b52a5b339e2b95 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommandCallback.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d5d9a7efad6658d55be8f39c7b52a5b339e2b95 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use generics in CloneSingleCinderDiskCommandCallback
by mlipchuk＠redhat.com 14 Jun '15

14 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use generics in CloneSingleCinderDiskCommandCallback ...................................................................... core: Use generics in CloneSingleCinderDiskCommandCallback Use generics for CloneSingleCinderDiskCommandCallback to be used also for preview single cinder volume snapshot. Change-Id: I51cf69d746453c9345dc45007c9f983ffbbffaaf Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommandCallback.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cf69d746453c9345dc45007c9f983ffbbffaaf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0