June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Correct VmPool.hashCode() and equals()
by ahadas＠redhat.com 12 Jun '15

12 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Correct VmPool.hashCode() and equals() ...................................................................... core: Correct VmPool.hashCode() and equals() Using the same set of fields for both hashCode() and equals() so two VmPool objects considered equal will have equal hashcodes. Change-Id: I70638a292a7d7ee0ee349721c3b2f8c6d6a0847f Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70638a292a7d7ee0ee349721c3b2f8c6d6a0847f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : fix geo-rep remove unexpected exception
by kmayilsa＠redhat.com 12 Jun '15

12 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine : fix geo-rep remove unexpected exception ...................................................................... engine : fix geo-rep remove unexpected exception The issue resides in the fact that the error code of remove geo-rep session was incorrect. Change-Id: I4cb673aabb9006320011e3596879e73b29cb0a69 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1224895 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cb673aabb9006320011e3596879e73b29cb0a69 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: change defaults in create brick popup
by kmayilsa＠redhat.com 12 Jun '15

12 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: change defaults in create brick popup ...................................................................... webadmin: change defaults in create brick popup Change the default RAID type and stripe size used in Create Brick Pop Up. Also add a note saying RAID config should match with the values which is used while creating the RAID volumes. Bug-Url: https://bugzilla.redhat.com/1228499 Change-Id: Ife6e71a1ff79298bcd68f514263c2f394b3acf54 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/CreateBrickPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.ui.xml 7 files changed, 96 insertions(+), 25 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/42275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6e71a1ff79298bcd68f514263c2f394b3acf54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: filter out volume snapshots from storage devices list
by kmayilsa＠redhat.com 12 Jun '15

12 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: filter out volume snapshots from storage devices list ...................................................................... engine: filter out volume snapshots from storage devices list Filter out all the lvmsnapshots which are created as part of gluster volume snapshot from the storage devices list. All the LVM snapshots created by gluster volume snapshots will be mounted at the location /var/run/gluster/snaps/. Note: Additionally fixing the typo 'Igore' in GlusterStorageDeviceListMountPointsToIgore and GlusterStorageDeviceListFileSystemTypesToIgore Change-Id: Ib8e8fa3049e271db8a4919afc72716fb459d22e5 Bug-Url: https://bugzilla.redhat.com/1227885 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 22 insertions(+), 11 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/42276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e8fa3049e271db8a4919afc72716fb459d22e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: display error message when sync storage device fails
by kmayilsa＠redhat.com 12 Jun '15

12 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: display error message when sync storage device fails ...................................................................... gluster: display error message when sync storage device fails Handle the exceptions properly in StorageDeviceSyncJob so that error in sync storage device will be logged in the audit log when user tries a manual sync from the UI. Change-Id: Ib05b3f0bcaa95fb50440c939f6b07ade9ba8879c Bug-Url: https://bugzilla.redhat.com/1218240 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 28 insertions(+), 8 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/42274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05b3f0bcaa95fb50440c939f6b07ade9ba8879c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: made DynamicMessages accessible in uico...
by tjelinek＠redhat.com 12 Jun '15

12 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin,userportal: made DynamicMessages accessible in uicommonweb ...................................................................... webadmin,userportal: made DynamicMessages accessible in uicommonweb Extracted the DynamicMessages interface to uicommonweb project and made it accessible to the models using the TypeResolver Change-Id: If2430ac25d91b31be05b224d2c860f0905341279 Bug-Url: https://bugzilla.redhat.com/1228275 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java R frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessagesTest.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java 11 files changed, 152 insertions(+), 101 deletions(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2430ac25d91b31be05b224d2c860f0905341279 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: device: add specParams for console devices
by tjelinek＠redhat.com 12 Jun '15

12 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: device: add specParams for console devices ...................................................................... core: device: add specParams for console devices Add the 'enableSocket=True' specParam to instruct instruct VDSM to bind the vm virtual serial console to an Unix Domain Socket. This patch enables the last link to make the Serial Console feature to actually work. We inconditionally do this way because this one being implemented was the original intent of the console device proper, so it doesn't make much sense to have different operational mode for Console Devices. Feature wiki page: http://www.ovirt.org/Features/Serial_Console Bug-Url: https://bugzilla.redhat.com/1223671 Change-Id: I42c1134728dee4b42fc38f13763dac5f7e5b7314 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A packaging/dbscripts/upgrade/03_06_1560_add_spec_param_to_console_devices.sql 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Verified Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/42216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c1134728dee4b42fc38f13763dac5f7e5b7314 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: filter out volume snapshots from storage devices list
by kmayilsa＠redhat.com 12 Jun '15

12 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: filter out volume snapshots from storage devices list ...................................................................... engine: filter out volume snapshots from storage devices list Filter out all the lvmsnapshots which are created as part of gluster volume snapshot from the storage devices list. All the LVM snapshots created by gluster volume snapshots will be mounted at the location /var/run/gluster/snaps/. Note: Additionally fixing the typo 'Igore' in GlusterStorageDeviceListMountPointsToIgore and GlusterStorageDeviceListFileSystemTypesToIgore Change-Id: Ib8e8fa3049e271db8a4919afc72716fb459d22e5 Bug-Url: https://bugzilla.redhat.com/1227885 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 22 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/42225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e8fa3049e271db8a4919afc72716fb459d22e5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix RSDL generation of DELETE methods
by juan.hernandez＠redhat.com 12 Jun '15

12 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix RSDL generation of DELETE methods ...................................................................... restapi: Fix RSDL generation of DELETE methods The DELETE methods have beem moved from collection to entity methods in previous patches. As a side effect they now have one parameter less, as they don't receive the identifier of the entity. The RSDL generator needs to be changed accordingly as it expects this parameter. Change-Id: Ib6d008c46dd2c880479bc553c46578535304b7e7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java 1 file changed, 10 insertions(+), 28 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6d008c46dd2c880479bc553c46578535304b7e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Propagate the scheduler error to UI
by kmayilsa＠redhat.com 12 Jun '15

12 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Propagate the scheduler error to UI ...................................................................... gluster: Propagate the scheduler error to UI Earlier the scheduler execption scenarios were just logged and UI used to show Internal Error. Corrected to porpagate the errors to UI properly. Change-Id: I2630cb8701d394da8a658c3ba677616f026625a2 Bug-Url: https://bugzilla.redhat.com/1224691 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java 7 files changed, 32 insertions(+), 27 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2630cb8701d394da8a658c3ba677616f026625a2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0