June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Mount-Broker setup changes
by sabose＠redhat.com 12 Jun '15

12 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Mount-Broker setup changes ...................................................................... engine: Mount-Broker setup changes Previously mount broker setup used to be done on all nodes of slave volume. But, it was observed that with latest glusterfs nightly it suffices to do it on any one node in slave volume. And if its done on all nodes of slave volume, the glusterds enter a race condition as all of them simultaneously also try to set up mount broker on other nodes. However root-mount broker folder with appropriate privileges need to be cerated on all nodes. This is in accordance with modification in VDSM verb that takes a boolean flag 'partial'. Change-Id: I09f44f8f12e5a49a85b3542793aa5f476ab0ccb3 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/SetUpMountBrokerParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/SetUpGlusterGeoRepMountBrokerVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetupGlusterGeoRepMountBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 9 files changed, 128 insertions(+), 46 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09f44f8f12e5a49a85b3542793aa5f476ab0ccb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine, webadmin : geo-rep status detail
by sabose＠redhat.com 12 Jun '15

12 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: engine,webadmin : geo-rep status detail ...................................................................... engine,webadmin : geo-rep status detail Changes in this patch : 1. session details is added to respective sessions while returing session list. As the list command and session detail command are separate and detail might not be available at the time of passing session list, session detail could potentially be null. 2. Host name of which the brick in the session detail is a part of, is added to the session detail so that UI doesn't need to explicitly make multiple queries to backend inorder to fetch the master server name of respective bricks; that is listed in the UI popup. 3. UI popup to show session details. Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepSessionDetailsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/VolumeGeoRepSessionDetailsPopUpPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java 14 files changed, 528 insertions(+), 4 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Propagate the scheduler error to UI
by sabose＠redhat.com 12 Jun '15

12 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Propagate the scheduler error to UI ...................................................................... gluster: Propagate the scheduler error to UI Earlier the scheduler execption scenarios were just logged and UI used to show Internal Error. Corrected to porpagate the errors to UI properly. Change-Id: I2630cb8701d394da8a658c3ba677616f026625a2 Bug-Url: https://bugzilla.redhat.com/1224691 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java 6 files changed, 15 insertions(+), 11 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2630cb8701d394da8a658c3ba677616f026625a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Alert if volume snapshot max limit reached
by sabose＠redhat.com 12 Jun '15

12 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Alert if volume snapshot max limit reached ...................................................................... gluster: Alert if volume snapshot max limit reached Modified to alert if maximum limit for gluster volume snapshot reached for a volume. Change-Id: I98920caac7e194f8887c0226399ff59fe2942cd9 Bug-Url: https://bugzilla.redhat.com/1224269 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteAllGlusterVolumeSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 9 files changed, 63 insertions(+), 23 deletions(-) Approvals: Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98920caac7e194f8887c0226399ff59fe2942cd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Corrected event log messages
by sabose＠redhat.com 12 Jun '15

12 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Corrected event log messages ...................................................................... gluster: Corrected event log messages Corrected event log messages while creation of bricks to add host name and cluster name as well. Change-Id: Ia3b424f2b46f98ea3a072e796b0537e555f84e7e Bug-Url: https://bugzilla.redhat.com/1228208 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3b424f2b46f98ea3a072e796b0537e555f84e7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Add audit log message while volume snapshot sync
by sabose＠redhat.com 12 Jun '15

12 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Add audit log message while volume snapshot sync ...................................................................... gluster: Add audit log message while volume snapshot sync Added code to log audit log messages while syncing the gluster volume snapshots from the gluster CLI to the engine. Change-Id: I81636a86f48e977f47a4e5cbbd042446e3483ddf Bug-Url: https://bugzilla.redhat.com/1223370 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 105 insertions(+), 16 deletions(-) Approvals: Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81636a86f48e977f47a4e5cbbd042446e3483ddf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Support "basestring" in Python 3
by juan.hernandez＠redhat.com 12 Jun '15

12 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Support "basestring" in Python 3 ...................................................................... sdk: Support "basestring" in Python 3 The code generated by the "generateDS.py" tool uses the "basestring" builtin. This has been removed in Python 3. In order to support both Pyton 2 and Python 3 this patch creates "basestring" as follows: try: basestring = basestring except NameError: basestring = str Change-Id: Ic8f357aafb361e2c5d5d314260222571720def73 Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/XsdCodegen.java A generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/BasestringHackTemplate A generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/BasestringHackTemplate.java M src/ovirtsdk/xml/params.py 4 files changed, 65 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8f357aafb361e2c5d5d314260222571720def73 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: remote-viewer version check
by tjelinek＠redhat.com 12 Jun '15

12 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: remote-viewer version check ...................................................................... frontend: remote-viewer version check Change-Id: I5b42e072926ad097e62d41360f9f08446132261f Bug-Url: https://bugzilla.redhat.com/1228275 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 2 files changed, 16 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b42e072926ad097e62d41360f9f08446132261f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: Add dependency to ovirt-engine-extension-aaa-jdbc
by sbonazzo＠redhat.com 12 Jun '15

12 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Add dependency to ovirt-engine-extension-aaa-jdbc ...................................................................... packaging: Add dependency to ovirt-engine-extension-aaa-jdbc Adds dependency to ovirt-engine-extension-aaa-jdbc, because this extension will replace legacy 'internal' AAA extension, so we need it to be installed with ovirt-engine by default. Change-Id: Ia6e6882ceeb0a3fc7a0c3a52c45440252ba3e357 Bug-Url: https://bugzilla.redhat.com/1076971 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified -- To view, visit https://gerrit.ovirt.org/42220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6e6882ceeb0a3fc7a0c3a52c45440252ba3e357 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-engine-extension-aaa-jdbc: new job
by dcaroest＠redhat.com 12 Jun '15

12 Jun '15

David Caro has submitted this change and it was merged. Change subject: ovirt-engine-extension-aaa-jdbc: new job ...................................................................... ovirt-engine-extension-aaa-jdbc: new job Create RPMs on push and merge Change-Id: Id333967ed402da1ca0731a56754691d2fa0f886c Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-engine-extension-aaa-jdbc.yaml 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me; Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/41606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id333967ed402da1ca0731a56754691d2fa0f886c Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0