June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: refactored 2 overgrown copy-pasted methods
by ahadas＠redhat.com 10 Jun '15

10 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: refactored 2 overgrown copy-pasted methods ...................................................................... core: refactored 2 overgrown copy-pasted methods Bug-Url: https://bugzilla.redhat.com/1200952 Change-Id: Ide9f1559b7b36f2052c1beecc05bbc60b1c52a8b Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 99 insertions(+), 80 deletions(-) Approvals: Martin Mucha: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide9f1559b7b36f2052c1beecc05bbc60b1c52a8b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Log when host in permissive mode with gluster
by sabose＠redhat.com 10 Jun '15

10 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Log when host in permissive mode with gluster ...................................................................... engine: Log when host in permissive mode with gluster Add event logs when the host is running in SELinux permissive mode with gluster service. Enhanced the log message to log current state as well. Change-Id: I81705d8bbafc1e5643aa41bb46ba42a0948da7c5 Bug-Url: https://bugzilla.redhat.com/858940 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Sahina Bose: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81705d8bbafc1e5643aa41bb46ba42a0948da7c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: removed redundant initializers, unused parameters, exp...
by ahadas＠redhat.com 10 Jun '15

10 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: removed redundant initializers, unused parameters, explicit type parameters ...................................................................... core: removed redundant initializers, unused parameters, explicit type parameters Bug-Url: https://bugzilla.redhat.com/1200952 Change-Id: I64bc644328eef2a88c0bc61f5589693350696659 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64bc644328eef2a88c0bc61f5589693350696659 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: error fix & simplification
by ahadas＠redhat.com 10 Jun '15

10 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: error fix & simplification ...................................................................... core: error fix & simplification • it seems that storage_pool_iso_map.status can be null, thus status != StorageDomainStatus.Active produces npe. • refreshIsoDomain was overgrown with several unneeded variables and complex syntax, which could be simplified. Bug-Url: https://bugzilla.redhat.com/1200952 Change-Id: I109fb2036e737e6a7bbc9701ee9e8ca35b1f552d Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 53 insertions(+), 51 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I109fb2036e737e6a7bbc9701ee9e8ca35b1f552d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: pki: cleanup: reset some vars at init
by sbonazzo＠redhat.com 10 Jun '15

10 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: cleanup: reset some vars at init ...................................................................... pki: cleanup: reset some vars at init Change-Id: Ifa9017694aa2df5f533896a7edde4b0be89a2162 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-enroll-request.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/38093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa9017694aa2df5f533896a7edde4b0be89a2162 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: extract ssh public key logic to script
by sbonazzo＠redhat.com 10 Jun '15

10 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: extract ssh public key logic to script ...................................................................... packaging: setup: extract ssh public key logic to script rhel-6 is missing functionality to export public key out of PKCS#8, this is required for setup but soon to pki. Change-Id: Id07ef97cdff510a95c6946e413450de32db631ee Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in A packaging/bin/pki-ssh-keygen.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py 4 files changed, 119 insertions(+), 30 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/38092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id07ef97cdff510a95c6946e413450de32db631ee Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: display error message when sync storage device fails
by sabose＠redhat.com 10 Jun '15

10 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: display error message when sync storage device fails ...................................................................... gluster: display error message when sync storage device fails Handle the exceptions properly in StorageDeviceSyncJob so that error in sync storage device will be logged in the audit log when user tries a manual sync from the UI. Change-Id: Ib05b3f0bcaa95fb50440c939f6b07ade9ba8879c Bug-Url: https://bugzilla.redhat.com/1218240 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 28 insertions(+), 8 deletions(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/40844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05b3f0bcaa95fb50440c939f6b07ade9ba8879c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce import from external provider
by ahadas＠redhat.com 10 Jun '15

10 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce import from external provider ...................................................................... core: introduce import from external provider This command adds the VM into the DB and creates its disks before calling the convert-command. Change-Id: I9328edf7b8f49aa7975e28f651183b1449030dd6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromExternalProviderParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 435 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/33712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9328edf7b8f49aa7975e28f651183b1449030dd6 Gerrit-PatchSet: 68 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: share common import validations
by ahadas＠redhat.com 10 Jun '15

10 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: share common import validations ...................................................................... core: share common import validations Before adding import-from-external-provider, the common validations for all import-vm operations are moved to ImportVmCommandBase. Change-Id: Ic0b7930d130192688d904c2e11ec839d8478ac78 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 2 files changed, 110 insertions(+), 116 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0b7930d130192688d904c2e11ec839d8478ac78 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Create cinder snapshot support
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Create cinder snapshot support ...................................................................... core: Create cinder snapshot support Add Cinder snapshot disk call back also introducing create snapshot for Cinder disk Change-Id: I986b41aba646c84d0d9d7fe771957cba6faf777a Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 3 files changed, 260 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I986b41aba646c84d0d9d7fe771957cba6faf777a Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0