June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add the correlated OVF write logic for Cinder
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add the correlated OVF write logic for Cinder ...................................................................... core: Add the correlated OVF write logic for Cinder We should support diskStorageType for each disk in OVF to support snapshots of cinder disk. We need this for snapshots for the following scenrio: 1. Create a snapshot from a VM with image disk 2. Create a Cinder disk 3. Preview the snapshot 4. Undo the preview The engine then should get the Cinder disk back to the VM as Cinder from the OVF. Change-Id: Idd1b99979e067af41b9d37a982be6da406a9e7e1 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 21 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd1b99979e067af41b9d37a982be6da406a9e7e1 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add DiskStorageType to OVF.
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add DiskStorageType to OVF. ...................................................................... core: Add DiskStorageType to OVF. We should support diskStorageType for each disk in OVF to support snapshots of cinder disk. We need this for snapshots for the following scenrio: 1. Create a snapshot from a VM with image disk 2. Create a Cinder disk 3. Preview the snapshot 4. Undo the preview The engine then should get the Cinder disk back to the VM as Cinder from the OVF. Change-Id: I732a1351cefca09c7f30fd922107db78b4efda9b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I732a1351cefca09c7f30fd922107db78b4efda9b Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce remove Cinder snapshot call back
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce remove Cinder snapshot call back ...................................................................... core: Introduce remove Cinder snapshot call back Add remove cinder snapshot call back. Change-Id: Iba139eacc85b958b7f6475d1dbb1680d0c44513c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java 1 file changed, 99 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba139eacc85b958b7f6475d1dbb1680d0c44513c Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support remove of cinder snapshot
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support remove of cinder snapshot ...................................................................... core: Support remove of cinder snapshot Add support for removing Cinder snapshot disk while removing a VM snapshot. Change-Id: Ic5fdaa6924019cff4b90072afa017e4559dccc52 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 1 file changed, 48 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Verified Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5fdaa6924019cff4b90072afa017e4559dccc52 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add vm snapshot id to Cinder disks on creation
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add vm snapshot id to Cinder disks on creation ...................................................................... core: Add vm snapshot id to Cinder disks on creation Once Cinder snapshots are supported, we can now create Cinder disks with vm snapshot id initialized. Change-Id: Id0bf00082b5a818916b862398cb720c5e8240b52 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0bf00082b5a818916b862398cb720c5e8240b52 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Update Cinder maximum volume validation.
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update Cinder maximum volume validation. ...................................................................... core: Update Cinder maximum volume validation. Change disks validator to use the new private class to validate if the maximum number of disks in Cinder exceeded. Change-Id: If8c3901db7eaf4c9361571fc14ac4b11218a9ff4 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 16 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8c3901db7eaf4c9361571fc14ac4b11218a9ff4 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce parameter class RemoveCinderDiskParameters
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce parameter class RemoveCinderDiskParameters ...................................................................... core: Introduce parameter class RemoveCinderDiskParameters Introduce a new parameter class RemoveCinderDiskParameters to be used for RemoveCinderDisk Change-Id: Ida425e4d187c8d8692f5713234c3e4fc5a399bda Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida425e4d187c8d8692f5713234c3e4fc5a399bda Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change method access modifier in RemoveImageCommand
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change method access modifier in RemoveImageCommand ...................................................................... core: Change method access modifier in RemoveImageCommand Use protected method access for several method to be used for remove of Cinder disk logic Change-Id: I9671d393224e06735c2422ea023ebca1f2414f26 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9671d393224e06735c2422ea023ebca1f2414f26 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Adding cinder snapshot capacity validation.
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding cinder snapshot capacity validation. ...................................................................... core: Adding cinder snapshot capacity validation. Adding a validation for snapshot capacity using the new private Change-Id: Icf8c0a6b59753a1aee6b562c44a9a83cc791e091 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 73 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf8c0a6b59753a1aee6b562c44a9a83cc791e091 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: VM general refresh
by awels＠redhat.com 09 Jun '15

09 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: VM general refresh ...................................................................... webadmin: VM general refresh - Fixed automatic refresh query that had refresh set to true. Change-Id: I80cb6a02e7427d64ffe53e072086d1c21e4df639 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80cb6a02e7427d64ffe53e072086d1c21e4df639 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0