Change in ovirt-engine[master]: core: Introduce remove Cinder snapshot command.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Introduce remove Cinder snapshot command.
......................................................................
core: Introduce remove Cinder snapshot command.
Add new command for remove Cinder snapshot.
Change-Id: I7bccfc24dbddca3052ad794629a066406cbfec75
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveCinderSnapshotDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 86 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41460
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bccfc24dbddca3052ad794629a066406cbfec75
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Use imageId when reomving disk from CinderBroker.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use imageId when reomving disk from CinderBroker.
......................................................................
core: Use imageId when reomving disk from CinderBroker.
Use the imageId to remove disk from CinderBroker.
Change-Id: Idd84f95e134c341a865a573ec9cb97815a407bec
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/42060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd84f95e134c341a865a573ec9cb97815a407bec
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Remove Cinder disk should remove all volume types.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove Cinder disk should remove all volume types.
......................................................................
core: Remove Cinder disk should remove all volume types.
Remove of Ciner disk command should remove all relations from
Cinder provider such as volumes or snapshots.
It should also remove the Cinder disk from the VM snapshot configuration.
Change-Id: I176b0b01d43fc6b9eab051dc93e6bb0a11fb934b
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 207 insertions(+), 71 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I176b0b01d43fc6b9eab051dc93e6bb0a11fb934b
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Validate detach of Cinder disk with snapshots.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Validate detach of Cinder disk with snapshots.
......................................................................
core: Validate detach of Cinder disk with snapshots.
Validate detaching of cinder disk with snapshots.
Change-Id: Ideec729462d13d72b2a58ca34281d36cac427a55
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Verified
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/42059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ideec729462d13d72b2a58ca34281d36cac427a55
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Introduce volume classification
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Introduce volume classification
......................................................................
core: Introduce volume classification
Introduce new column in images table of volume_classification.
volume_classification is a column which determines if the image is a
volume or a snapshot.
It should be mainly used for Cinder, since a previewed snapshot in
Cinder is acctually a new Volume in Cinder and this indication is
needed once the disk is being deleted.
Change-Id: Ia1f37abcc4c5a99076138d7dfb0ffe72f68aef50
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Image.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/images_sp.sql
A packaging/dbscripts/upgrade/03_06_1500_add_column_volume_classification.sql
9 files changed, 56 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1f37abcc4c5a99076138d7dfb0ffe72f68aef50
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Add Cinder disks to snapshot OVF.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add Cinder disks to snapshot OVF.
......................................................................
core: Add Cinder disks to snapshot OVF.
Add also Cinder disks to a list of disks which are initialized with
empty storage domain id while adding a snapshot, so Cinder disks will also
get updated with the accurate Storage Domain id in case of a move operation.
Change-Id: Icaf67979493885ef2f53ac27afd8383942d242ca
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40984
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaf67979493885ef2f53ac27afd8383942d242ca
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Introduce private class at Cinder validator.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Introduce private class at Cinder validator.
......................................................................
core: Introduce private class at Cinder validator.
Adding a private class CinderStorageRelatedDisksAndProxy which
encapsulate the relation between Storage Domain id, list of disks and
CinderProxy.
Change-Id: I45c4584f336c606e48d51858d967b25cbd125aad
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java
1 file changed, 38 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/41461
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45c4584f336c606e48d51858d967b25cbd125aad
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Support Cinder disks for snapshot in VM
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support Cinder disks for snapshot in VM
......................................................................
core: Support Cinder disks for snapshot in VM
Add Cinder for Creating snapshot when CreateAllSnapshotsFromVmCommand is
being called.
Change-Id: Ie60a82160db24c410e10d79da49f528bc2ed22fc
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 46 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40983
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie60a82160db24c410e10d79da49f528bc2ed22fc
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Validate maximum cinder snapshot once creating a snaps...
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Validate maximum cinder snapshot once creating a snapshot.
......................................................................
core: Validate maximum cinder snapshot once creating a snapshot.
Add a validation once a new snapshot gets created to validate if the
maximum number of Cinder snapshot will be exceeded.
Change-Id: Ic0120320f3bbb8570e7b9c7b4300b9617ccf73e9
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
2 files changed, 18 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/41133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0120320f3bbb8570e7b9c7b4300b9617ccf73e9
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Reorder imports in Cinder disks validator.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Reorder imports in Cinder disks validator.
......................................................................
core: Reorder imports in Cinder disks validator.
Change-Id: Id62b12f1258ae19b19089d0d256fd17f6a8f4794
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/41131
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id62b12f1258ae19b19089d0d256fd17f6a8f4794
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months