June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Additional null checks in VmDeviceUtils
by ofrenkel＠redhat.com 07 Jun '15

07 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Additional null checks in VmDeviceUtils ...................................................................... core: Additional null checks in VmDeviceUtils Added null checks that were missing after refactoring VmDeviceUtils. * In updateBootOrder() vm may be null if the method is called with ID of a template. * In getVmDevicesForNextRun() return value of findVmDeviceBy[General]Type() may be null. Change-Id: Ibd3574905fa4dd58e31cd914f4124e7a435c9ee9 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 19 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd3574905fa4dd58e31cd914f4124e7a435c9ee9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Sysprep attached by default on new Windows VMs
by shavivi＠redhat.com 07 Jun '15

07 Jun '15

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Sysprep attached by default on new Windows VMs ...................................................................... engine: Sysprep attached by default on new Windows VMs By default we attach Sysprep to a new Windows VM - now that we have "Initial Run" we will attach Sysprep only to a VM that set this option on. Bug-Url: https://bugzilla.redhat.com/1190663 Change-Id: Ia2a1142457df45843b57483913c8ea518aec0d0b Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2a1142457df45843b57483913c8ea518aec0d0b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks
by derez＠redhat.com 07 Jun '15

07 Jun '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks ...................................................................... core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks Ensuring a unique address unit value for disks attached with VirtIO_SCSI or SPAR_VSCSI interfaces. The selected units may collide as the search process is depended on the VmDevice addresses which are updated asynchronously by the VmsMonitoring. E.g. when hot-plugging multiple disks using a script, identical unit values might be selected for different disks. Hence: * Moved address creation logic to BLL layer (AbstractDiskVmCommand). * Updating VmDevice address in DB right after selecting an available unit value. * Taking an EngineLock on 'getDiskAddressMap' method to avoid races. Change-Id: I5e621618e8891fca52b48bff437cc4c2a1f695db Bug-Url: https://bugzilla.redhat.com/1206374 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugDiskVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java 4 files changed, 122 insertions(+), 61 deletions(-) Approvals: Daniel Erez: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e621618e8891fca52b48bff437cc4c2a1f695db Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: systemd: Use journal
by dougsland＠redhat.com 07 Jun '15

07 Jun '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: systemd: Use journal ...................................................................... systemd: Use journal Instead of using ovirt-node.log use systemd. Change-Id: I179369a84149ac1010e6a25fee60dedc17c6d508 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/42008 Reviewed-by: Jenkins CI Tested-by: Jenkins CI --- M autoinstall/ovirt-node-plugin-vdsm-autoreg M ovirt-node-plugin-vdsm.spec.in 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I179369a84149ac1010e6a25fee60dedc17c6d508 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: set requires HE
by dougsland＠redhat.com 06 Jun '15

06 Jun '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: set requires HE ...................................................................... spec: set requires HE Return the requires Hosted Engine plugin. Change-Id: I02f7505be03587344ab7cd49c5fb372418cb24d1 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/41519 Reviewed-by: Jenkins CI Tested-by: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/41980 --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f7505be03587344ab7cd49c5fb372418cb24d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: auto-detect available appliance images and...
by sbonazzo＠redhat.com 05 Jun '15

05 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: auto-detect available appliance images and suggest them ...................................................................... packaging: setup: auto-detect available appliance images and suggest them Autodetects available appliance images Suggest them if no one is available Validate the sha1sum of the selected appliance Makes the appliance flow the default one Bug-Url: https://bugzilla.redhat.com/1211532 Change-Id: Iaddd10521e71d5c855473817a563c8c1c6a1b0a8 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py 3 files changed, 150 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaddd10521e71d5c855473817a563c8c1c6a1b0a8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Added column ids to Volume main and sub tab
by sabose＠redhat.com 05 Jun '15

05 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin : Added column ids to Volume main and sub tab ...................................................................... webadmin : Added column ids to Volume main and sub tab Added column ids to Volume main and sub tab Change-Id: I930f656e9e867bed5f5675a2401a10476d3c7672 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityCell.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterVolumeSnapshotStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterVolumeSnapshotStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityCompositeCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeBrickStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeBrickStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeInfoColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java 17 files changed, 316 insertions(+), 28 deletions(-) Approvals: anmolbabu: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I930f656e9e867bed5f5675a2401a10476d3c7672 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: Add missing call to prepareImage
by sbonazzo＠redhat.com 05 Jun '15

05 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add missing call to prepareImage ...................................................................... Add missing call to prepareImage adding the missing call to prepareImage for allowing to write the image imported from the OVA to an iSCSI or FC storage. On NFS storage it worked also without this call but it's required on iSCSI. Change-Id: If42529e6f02b5803e0c2e1fd8d0ab7550b1402dd Bug-Url: https://bugzilla.redhat.com/1222058 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/image.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/41965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42529e6f02b5803e0c2e1fd8d0ab7550b1402dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Adding atomic host support to the ovirt guest agent
by vfeenstr＠redhat.com 05 Jun '15

05 Jun '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Adding atomic host support to the ovirt guest agent ...................................................................... Adding atomic host support to the ovirt guest agent Change-Id: Id7c2d8b00ce4fab7dc61e449a012a8a7d32ec4de Bug-Url: https://bugzilla.redhat.com/1201516 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 39 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7c2d8b00ce4fab7dc61e449a012a8a7d32ec4de Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: ovirt-live-3.5.3-rc3
by sbonazzo＠redhat.com 05 Jun '15

05 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-live-3.5.3-rc3 ...................................................................... ovirt-live-3.5.3-rc3 Change-Id: I13e9f9149ea09695d0bc60057b7c5abf74ac5239 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13e9f9149ea09695d0bc60057b7c5abf74ac5239 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0