Change in ovirt-engine[master]: engine: Block provide type change
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Block provide type change
......................................................................
engine: Block provide type change
There is no sense to modify the provider type, i.e. when
an OpenStack provider is created, the ovirt-engine creates
the required storage domain for it. Modifying the type of
a provider to a different type modifies the entire nature
of the provider.
Each provider has its own definition based on its type and
modifying the type will not be supported.
Change-Id: I3f5b0980977bc9fe556b1e3a72b1942bd8d86cdc
Bug-Url: https://bugzilla.redhat.com/1227320
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 15 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, but someone else must approve
Moti Asayag: Verified; Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f5b0980977bc9fe556b1e3a72b1942bd8d86cdc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: update supported emulated machines for 3.6
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: update supported emulated machines for 3.6
......................................................................
core: update supported emulated machines for 3.6
3.6 requires higher level of emulated machines for new features like
hot-plug memory.
for el pc-i440fx-rhel7.1.0
for fedora pc-i440fx-2.1
Change-Id: I55d1ac2bbdca4d9aa6dfc1fbec1236a91866d49c
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55d1ac2bbdca4d9aa6dfc1fbec1236a91866d49c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: webadmin: fix class cast exception in edit vm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: webadmin: fix class cast exception in edit vm
......................................................................
webadmin: fix class cast exception in edit vm
moving to builders changed the hirerachy and caused a class cast
excpetion on edit vm dialog, blocking the ability to change the number
of sockets for running vm -> no hot plug cpu.
Change-Id: If0453e97b2789568b36793d12f34381c98933bd6
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Verified
--
To view, visit https://gerrit.ovirt.org/41887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0453e97b2789568b36793d12f34381c98933bd6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: db:set AutoRegistrationDefaultVdsGroupID correctly
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db:set AutoRegistrationDefaultVdsGroupID correctly
......................................................................
db:set AutoRegistrationDefaultVdsGroupID correctly
This patch fixes an issue in post-upgrade when attempting to set
AutoRegistrationDefaultVdsGroupID in vdc_options to the value of the
default cluster fails and returns null when the default cluster name was
changed from 'Default' to something else.
In that case we will set the configuration value to the first cluster id
we can find.
Change-Id: If1aa05a0d24866dfad3a9d18d90262ec07d2fdac
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1226944
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/upgrade/post_upgrade/0030_set_default_cluster_for_registration.sql
1 file changed, 20 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1aa05a0d24866dfad3a9d18d90262ec07d2fdac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: engine: Validate on network remove/modify
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Validate on network remove/modify
......................................................................
engine: Validate on network remove/modify
Validate that gluster bricks do not use the
network on modification of networks with
gluster role
Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744
Bug-Url: https://bugzilla.redhat.com/1222503
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 80 insertions(+), 11 deletions(-)
Approvals:
Sahina Bose: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: webadmin: Hiding virt network fields in gluster mode
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Hiding virt network fields in gluster mode
......................................................................
webadmin: Hiding virt network fields in gluster mode
Hiding columns and fields not relevant in
gluster only mode of installation
Change-Id: If9380697adc0c6e1d698e7aacc1f9b47be0d3851
Bug-Url: https://bugzilla.redhat.com/1207947
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java
5 files changed, 51 insertions(+), 10 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9380697adc0c6e1d698e7aacc1f9b47be0d3851
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Correct canDoAction message for volume snapshot act...
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Correct canDoAction message for volume snapshot actions
......................................................................
gluster: Correct canDoAction message for volume snapshot actions
Corrected canDoAction messages for gluster volume snapshot
create and restore commands.
Also corrected setting the canDoAction message variables for
other commands.
Change-Id: If311d43f9266c7717891b4698fc041529007532f
Bug-Url: https://bugzilla.redhat.com/1215884
Bug-Url: https://bugzilla.redhat.com/1215878
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ActivateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeactivateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteAllGlusterVolumeSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If311d43f9266c7717891b4698fc041529007532f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Added cluster name with volume names
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Added cluster name with volume names
......................................................................
gluster: Added cluster name with volume names
Modified to add cluster name as well while event
logging any gluster volume related message.
Change-Id: I5c857311f5e187f946325df444bee724c02e8f8d
Bug-Url: https://bugzilla.redhat.com/1220782
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 77 insertions(+), 77 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c857311f5e187f946325df444bee724c02e8f8d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: gluster: Correct canDoAction message for volume snapshot act...
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Correct canDoAction message for volume snapshot actions
......................................................................
gluster: Correct canDoAction message for volume snapshot actions
Corrected canDoAction messages for gluster volume snapshot
create and restore commands.
Also corrected setting the canDoAction message variables for
other commands.
Change-Id: If311d43f9266c7717891b4698fc041529007532f
Bug-Url: https://bugzilla.redhat.com/1215884
Bug-Url: https://bugzilla.redhat.com/1215878
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ActivateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeactivateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteAllGlusterVolumeSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41247
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If311d43f9266c7717891b4698fc041529007532f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: gluster: Added cluster name with volume names
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Added cluster name with volume names
......................................................................
gluster: Added cluster name with volume names
Modified to add cluster name as well while event
logging any gluster volume related message.
Change-Id: I5c857311f5e187f946325df444bee724c02e8f8d
Bug-Url: https://bugzilla.redhat.com/1220782
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 77 insertions(+), 77 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c857311f5e187f946325df444bee724c02e8f8d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months