Change in ovirt-engine[master]: frontend: Fix Column Sizing in AddVmHostDevicePopupView
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix Column Sizing in AddVmHostDevicePopupView
......................................................................
frontend: Fix Column Sizing in AddVmHostDevicePopupView
Change-Id: I4b9a6a3441f95a1dcabaf38105477427aaa85afa
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostDeviceView.java
3 files changed, 17 insertions(+), 16 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Verified; Looks good to me, but someone else must approve
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/41787
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b9a6a3441f95a1dcabaf38105477427aaa85afa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: frontend: Fix random focus change in host main tab
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix random focus change in host main tab
......................................................................
frontend: Fix random focus change in host main tab
The HostListModel was missing the appropriate HashName property
that would match the last part of place token, and thus the GWT-P
reveal failed for non-existing place 'hosts-undefined'.
Also added missing help-tag and title.
Change-Id: Ib232da07c49b7329729f29c00e5013a5d4bb5206
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/HostDeviceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java
3 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Verified; Looks good to me, but someone else must approve
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/41841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib232da07c49b7329729f29c00e5013a5d4bb5206
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5.3]: packaging: setup: pki: use local transaction when extracting...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: pki: use local transaction when extracting PKCS#12
......................................................................
packaging: setup: pki: use local transaction when extracting PKCS#12
as pki is non transactional, setup revert will create inconsistency
between the PKCS#12 and the cert/key files.
so write these files and commit them immediately as other transactions
in this module.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860
Change-Id: Idd564f30ddc9c9bbfd79f70e0f89337ec0a65d61
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 23 insertions(+), 21 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd564f30ddc9c9bbfd79f70e0f89337ec0a65d61
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: pki: use local transaction when extracting...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: pki: use local transaction when extracting PKCS#12
......................................................................
packaging: setup: pki: use local transaction when extracting PKCS#12
as pki is non transactional, setup revert will create inconsistency
between the PKCS#12 and the cert/key files.
so write these files and commit them immediately as other transactions
in this module.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860
Change-Id: Idd564f30ddc9c9bbfd79f70e0f89337ec0a65d61
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 23 insertions(+), 21 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd564f30ddc9c9bbfd79f70e0f89337ec0a65d61
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: restapi: avoid npe on floating disk creation without domain
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: avoid npe on floating disk creation without domain
......................................................................
restapi: avoid npe on floating disk creation without domain
Modified 'BackendDisksResource -> add()' to avoid an NPE
when creating a disk without a specified storage domain
(similar to https://gerrit.ovirt.org/40826/).
Change-Id: I2156d14ec6dc818ab3d0e1a76616d829ac8637c5
Bug-Url: https://bugzilla.redhat.com/1220824
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2156d14ec6dc818ab3d0e1a76616d829ac8637c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core, engine: servlet to support the console proxy
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core, engine: servlet to support the console proxy
......................................................................
core, engine: servlet to support the console proxy
This patch creates two services that provide information to the SSH
server that acts as the VirtIO console proxy in the
/services/consoleproxy endpoint in the engine, this endpoint
accepts two commands:
- "public_keys": Provides to the authkeys script the list of
allowed public keys into the SSH server and the respective ID of
each allowed user.
- "available_consoles": Lists the available VMs to be accessed
by the user given his ID and in which host these VMs are located.
In order to protect these services, a ticket must emitted with the
desired command and arguments by the client to the service.
Feature wiki page: http://www.ovirt.org/Features/Serial_Console
Bug-Url: https://bugzilla.redhat.com/1223671
Change-Id: I53c721da21cefcf4069d14c7016b6f7d97f9eac9
Signed-off-by: Vitor de Lima <vdelima(a)redhat.com>
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M README.oid
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllUserProfilesQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForAnotherUserQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/services/pom.xml
A backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java
A backend/manager/modules/services/src/main/webapp/WEB-INF/beans.xml
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
9 files changed, 305 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/35887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53c721da21cefcf4069d14c7016b6f7d97f9eac9
Gerrit-PatchSet: 38
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Add Cinder snapshot creation at Cinder broker
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add Cinder snapshot creation at Cinder broker
......................................................................
core: Add Cinder snapshot creation at Cinder broker
Add API to create cinder snapshot in cinder broker
Change-Id: Id3305402b0c63aa98e9857a3de17b1800d0298ef
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3305402b0c63aa98e9857a3de17b1800d0298ef
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Add API to create Cinder snapshot.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add API to create Cinder snapshot.
......................................................................
core: Add API to create Cinder snapshot.
Add API for Cinder snapshot creation.
Change-Id: I637b3a0ceacefdf0d85f49d9da9344c3de9b8b70
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I637b3a0ceacefdf0d85f49d9da9344c3de9b8b70
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Add validator in CinderBroker for snapshot exists.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add validator in CinderBroker for snapshot exists.
......................................................................
core: Add validator in CinderBroker for snapshot exists.
Add validaor when removing a snapshot.
Change-Id: I805f1258014142cc2d1a4491d051b62f50671395
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/41458
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I805f1258014142cc2d1a4491d051b62f50671395
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Add Cinder delete snapshot for CinderBroker
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add Cinder delete snapshot for CinderBroker
......................................................................
core: Add Cinder delete snapshot for CinderBroker
Add Cinder delete snapshot for CinderBroker
Change-Id: Ie1a6ca7dcb3cf1bf1f6f7571a6156c2e0c651194
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40971
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1a6ca7dcb3cf1bf1f6f7571a6156c2e0c651194
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months