June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Search templates by version name only
by ofrenkel＠redhat.com 03 Jun '15

03 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Search templates by version name only ...................................................................... core: Search templates by version name only Specifying two fields in BaseConditionFieldAutoCompleter.columnNameDict is not supported. Using only template_version_name for search fixes SQL syntax error and incorrect sorting. Change-Id: I074cb7ebf2a61a762ce7bc95323b400446ad2a2b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1225428 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074cb7ebf2a61a762ce7bc95323b400446ad2a2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Move iSCSI Bond remove from collection to entity
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move iSCSI Bond remove from collection to entity ...................................................................... restapi: Move iSCSI Bond remove from collection to entity This patch moves the method that implements the DELETE operation from the collection interface to the entity interface. This is needed to avoid issues with newer versions of Resteasy. Change-Id: I2ddba7d581b69006f8652dbb384a3fea737a3b5c Related: https://gerrit.ovirt.org/41783 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IscsiBondResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IscsiBondsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResourceTest.java 6 files changed, 94 insertions(+), 57 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ddba7d581b69006f8652dbb384a3fea737a3b5c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Move Network Label remove from collection to entity
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move Network Label remove from collection to entity ...................................................................... restapi: Move Network Label remove from collection to entity This patch moves the method that implements the DELETE operation from the collection interface to the entity interface. This is needed to avoid issues with newer versions of Resteasy. Change-Id: I8d31813da3e6a061d4c70baecbb1801f82382e7e Related: https://gerrit.ovirt.org/41783 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/LabelResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/LabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelsResourceTest.java 10 files changed, 230 insertions(+), 196 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d31813da3e6a061d4c70baecbb1801f82382e7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Move External Host Provider remove from collection ...
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move External Host Provider remove from collection to entity ...................................................................... restapi: Move External Host Provider remove from collection to entity This patch moves the method that implements the DELETE operation from the collection interface to the entity interface. This is needed to avoid issues with newer versions of Resteasy. Change-Id: If3287d0f8daf80ff6d2bb8e814361efabb8a8001 Related: https://gerrit.ovirt.org/41783 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/externalhostproviders/ExternalHostProviderResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/externalhostproviders/ExternalHostProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendExternalHostProviderResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendExternalHostProvidersResource.java 4 files changed, 26 insertions(+), 20 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3287d0f8daf80ff6d2bb8e814361efabb8a8001 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Don't use primitive types from the "types" module
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Don't use primitive types from the "types" module ...................................................................... sdk: Don't use primitive types from the "types" module This is one step towards adding support for Python 3. Change-Id: I95ec21418f9685f5c11e897a0840efbd4b3266a9 Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/EntryPointHeadTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/EntryPointMethodsTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/EntryPointTemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/cache.py M src/ovirtsdk/infrastructure/errors.py 6 files changed, 13 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ec21418f9685f5c11e897a0840efbd4b3266a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Always use UTF-8 for encoding text
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Always use UTF-8 for encoding text ...................................................................... sdk: Always use UTF-8 for encoding text Currently there are several places in the SDK where XML documents are converted to text without specifying the character set to use. In this situation the underlying HTTP library will select a character set that may not match the character set declared in the header of the XML document, resulting in incorrectly encoded documents. To solve this issue this patch changes the SDK so that it always specify explicitly the UTF-8 character set, when generating the XML documents and when encoding them. Change-Id: I560e3b96756ec1ffa1bf0169ba116edc18fa9844 Bug-Url: https://bugzilla.redhat.com/1223186 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/HttpResponseHelper.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/SerializationHelper.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/StringUtils.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBroker.java 4 files changed, 13 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I560e3b96756ec1ffa1bf0169ba116edc18fa9844 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Always use UTF-8 for encoding text
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Always use UTF-8 for encoding text ...................................................................... sdk: Always use UTF-8 for encoding text Currently there are several places in the SDK where XML documents are converted to text without specifying the character set to use. In this situation the underlying HTTP library will select a character set that may not match the character set declared in the header of the XML document, resulting in incorrectly encoded documents. To solve this issue this patch changes the SDK so that it always specify explicitly the UTF-8 character set, when generating the XML documents and when encoding them. Change-Id: I560e3b96756ec1ffa1bf0169ba116edc18fa9844 Bug-Url: https://bugzilla.redhat.com/1223186 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk/utils/HttpResponseHelper.java M sdk/src/main/java/org/ovirt/engine/sdk/utils/SerializationHelper.java M sdk/src/main/java/org/ovirt/engine/sdk/utils/StringUtils.java M sdk/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBroker.java 4 files changed, 13 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I560e3b96756ec1ffa1bf0169ba116edc18fa9844 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Move OpenStackVolume Providers remove to entity
by juan.hernandez＠redhat.com 03 Jun '15

03 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move OpenStackVolume Providers remove to entity ...................................................................... restapi: Move OpenStackVolume Providers remove to entity This patch moves the method that implements the DELETE operation from the collection interface to the entity interface. This is needed to avoid issues with newer versions of Resteasy. Change-Id: I21e9b69a1f47e5b55c79115cf7113c93d1404d07 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeProviderResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResourceTest.java 5 files changed, 30 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21e9b69a1f47e5b55c79115cf7113c93d1404d07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Fix cancel on remove VM host device dialog
by tjelinek＠redhat.com 03 Jun '15

03 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix cancel on remove VM host device dialog ...................................................................... frontend: Fix cancel on remove VM host device dialog The remove command of VmHostDeviceListModel uses setConfirmWindow so it has to be also cleared in the cancel() method. Change-Id: Ic50b92fe4b926f3f738be724aaa1ec97499cda3a Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/41836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic50b92fe4b926f3f738be724aaa1ec97499cda3a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Add missing columns to HostDevice subtabs
by tjelinek＠redhat.com 03 Jun '15

03 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Add missing columns to HostDevice subtabs ...................................................................... frontend: Add missing columns to HostDevice subtabs Added missing columns and fixed column sizes of host device table in VM and Host sub tabs to make it consistent with AddVmHostDevicePopupView. Also since in VM and Host sub tabs is always displayed the same information, extracted the commonalities to HostDeviceModelBaseTable. Change-Id: I484d0607bb27118058bef08c628c8a3bc8587fc9 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/HostDeviceColumnHelper.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostDeviceModelBaseTable.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostDeviceModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostDeviceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/VmHostDeviceModelTable.java 6 files changed, 143 insertions(+), 143 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/41830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I484d0607bb27118058bef08c628c8a3bc8587fc9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0